Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

implement :q to close tab #348

Merged
merged 2 commits into from
May 10, 2018
Merged

Conversation

luanpotter
Copy link
Contributor

As per suggestion on issue #260 , add the :q (or :quit) command to close the current tab.

The behavior is very similar to vim's, so I think it's a great addition.

It's good to allow for a effective option to close tab to users who would like to disable the d key (because of accidental usage).

@hoshsadiq
Copy link

Imo we should get rid of d and !d as part of this. @ueokande what do you think?

@ueokande
Copy link
Owner

ueokande commented May 1, 2018

@hoshsadiq
Vim-Vixen weigh a backward compatibility, heavily. Removing keys break it, and d and !d will be kept in the future releases.

@hoshsadiq
Copy link

So maybe it can be deprecated in one way or another. Anyway, no worries if it can't.

@luanpotter
Copy link
Contributor Author

The idea is to add this option so that people can disable d in the config if so desired. IMHO there is no need to change the default behavior, as it could break expectations and also because customization is easily achieved by changing the configs.

@ueokande Is there any other consideration about the PR? I can change it if needed; would love to see it merged :)

Copy link
Owner

@ueokande ueokande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ueokande ueokande merged commit b0dddc9 into ueokande:master May 10, 2018
@gmarmstrong gmarmstrong mentioned this pull request May 20, 2018
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants