Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stopImmediatePropagation to stopPropagation #233

Closed
wants to merge 1 commit into from
Closed

Change stopImmediatePropagation to stopPropagation #233

wants to merge 1 commit into from

Conversation

wishfulthinkerme
Copy link
Contributor

Change stopImmediatePropagation to stopPropagation onFocusChange, as on Firefox caret is invisible.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.844% when pulling e21d052 on crotoan:fix/firefox_on_focus into 387f034 on udos86:master.

@udos86 udos86 changed the base branch from master to development January 4, 2017 09:04
@udos86 udos86 changed the base branch from development to master January 4, 2017 09:04
@udos86
Copy link
Owner

udos86 commented Jan 6, 2017

@crotoan Thanks very much for your pull request! If you'd like to appear as contributor please follow the contribution guide the next time and branch off udos86:development instead of udos86:master. I had to cherry-pick your commit this time in order to not pollute the commit history. Thanks again!

@udos86 udos86 closed this Jan 6, 2017
@wishfulthinkerme
Copy link
Contributor Author

wishfulthinkerme commented Jan 6, 2017 via email

@udos86
Copy link
Owner

udos86 commented Jan 6, 2017

@crotoan No problem! Despite the cherry-pick you appear as contributor! That's great! Patch 1.3.6 is published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants