Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to control antenna_trim_shape #811

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Add setting to control antenna_trim_shape #811

merged 1 commit into from
Oct 22, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Oct 21, 2023

Default is stlil stripe, as before. This could be a way to fix some DRCs where trimming the strap back results in a bad via shape to the lower layer straps.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@jerryz123
Copy link
Contributor Author

Thanks!

@jerryz123 jerryz123 added this pull request to the merge queue Oct 22, 2023
Merged via the queue into master with commit c11ec35 Oct 22, 2023
3 checks passed
@jerryz123 jerryz123 deleted the antenna_trim branch October 22, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants