Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky130 revision #805

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Sky130 revision #805

merged 9 commits into from
Oct 10, 2023

Conversation

kenhoberkeley
Copy link
Contributor

@kenhoberkeley kenhoberkeley commented Oct 10, 2023

Re-targets SKY130A plugin to work with most updated EFabless SKY130A distribution.

  • Post processes verilog to ensure that timing models will work. Syntax errors, nonexistent nets. Can run gl sims cleanly.
  • Post processes LEF due to definition error.
  • Some minor tech json changes.
  • Some minor repointing.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File some issues, and let's remove some of these hacks if they get fixed.

@kenhoberkeley kenhoberkeley added this pull request to the merge queue Oct 10, 2023
Merged via the queue into master with commit 5306b86 Oct 10, 2023
3 checks passed
@kenhoberkeley kenhoberkeley deleted the sky130_revision branch October 10, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants