Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forgotten AppendBinary to ArrayEncoder #669

Closed
wants to merge 1 commit into from

Conversation

NWilson
Copy link
Contributor

@NWilson NWilson commented Jan 22, 2019

For some reason, ObjectEncoder has AddBinary and AddByteString methods, but ArrayEncoder only has AppendByteString. This PR adds the missing (forgotten?) AppendBinary method.

I realise this will have to wait until zap v2, since it's a breaking API change.

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #669 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files          40       40           
  Lines        2102     2105    +3     
=======================================
+ Hits         2047     2050    +3     
  Misses         47       47           
  Partials        8        8           
Impacted Files Coverage Δ
zapcore/encoder.go 83.13% <ø> (ø)
zapcore/json_encoder.go 100.00% <100.00%> (ø)
zapcore/memory_encoder.go 98.68% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bc79d...6b1f695. Read the comment docs.

@NWilson
Copy link
Contributor Author

NWilson commented Apr 24, 2019

Ping - could you create a "v2-unstable" branch (or similar) where API breaking changes can be merged that will go into the v2 release, whenever it is? Otherwise without a branch, any future improvements can't be developed.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2020

CLA assistant check
All committers have signed the CLA.

@prashantv
Copy link
Collaborator

We've been tracking improvements in #388

I'd suggest leaving a comment linking to this PR in that task as we're not currently maintaining a v2 branch.

@prashantv prashantv closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants