Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make user-supplied sinks operate on URIs #606

Merged
merged 6 commits into from
Jul 19, 2018
Merged

Make user-supplied sinks operate on URIs #606

merged 6 commits into from
Jul 19, 2018

Commits on Jun 29, 2018

  1. Newlines after defers 

    Small formatting change for readability.
    @akshayjshah
    akshayjshah committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    f8b6d35 View commit details
    Browse the repository at this point in the history

  2. Make user-supplied sinks operate on URIs 

    For future extensibility, make user-supplied factories for log sinks
operate on URIs. Each user-supplied factory owns a scheme, and
double-registering constructors for a scheme is an error. For
back-compat, zap automatically registers a factory for the `file` scheme
and treats URIs without a scheme as though they were for files.
    @akshayjshah
    akshayjshah committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    f5eee05 View commit details
    Browse the repository at this point in the history

  3. Fix import ordering

    @akshayjshah
    akshayjshah committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    0db234b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Disallow filepaths with fragments, queries, etc

    @akshayjshah
    akshayjshah committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    6e33ddf View commit details
    Browse the repository at this point in the history

  2. Clean up normalizeScheme

    @akshayjshah
    akshayjshah committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    8dccd5c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. Fix RFC terminology

    @akshayjshah
    akshayjshah committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    c7f4f5e View commit details
    Browse the repository at this point in the history