Test on Go 1.10 and 1.9 #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update our Travis configuration to test on Go 1.9 and 1.10, dropping 1.8.
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 97.49% 97.47% -0.03%
==========================================
Files 40 39 -1
Lines 2035 2017 -18
==========================================
- Hits 1984 1966 -18
Misses 43 43
Partials 8 8
Continue to review full report at Codecov.
|
prashantv
approved these changes
Apr 13, 2018
abhinav
approved these changes
Apr 13, 2018
added 3 commits
April 13, 2018 14:44
Drop support for Go 1.8. Since all supported versions of Go now have type aliases, we can drop some duplicated code.
The `Field` union struct is defined in `zapcore`, but most of its constructors are in the top-level `zap` package. This makes the zap GoDoc really unfriendly, since the field constructors are mixed in with other top-level functions instead of being grouped together under the field type. This commit adds a `zap.Field` type which is just an alias for `zapcore.Field`. It then changes all the top-level zap code to use the alias. For validation, this commit leaves all test code unchanged.
Update zap's tests to use the new `zap.Field` alias. Keeping this change in a separate commit lets us verify that changing to an alias is backward-compatible for callers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our Travis configuration to test on Go 1.9 and 1.10, dropping
1.8.