Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open should only return close on success #396

Merged
merged 2 commits into from
Mar 29, 2017
Merged

Open should only return close on success #396

merged 2 commits into from
Mar 29, 2017

Commits on Mar 29, 2017

  1. Open should only return close on success 

    Config assumes that Open will always return a close function
which causes a panic when Open returns an error, since it doesn't
return a close function.

We can instead clean up the assumption that we return partial values
on error, and instead use a more common pattern:
 - On success, `err == nil` and all other return values are valid
 - On error, `err != nil` and all other return values are zero values
    @prashantv
    prashantv committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    f84f3ac View commit details
    Browse the repository at this point in the history

  2. Remove unused wantErr field

    @prashantv
    prashantv committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    83243b9 View commit details
    Browse the repository at this point in the history