Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand/Model Support with Minimal changes #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsonntag
Copy link

I have added brand and model support with the goal of altering the existing code base as little as possible. This differs from the approach taken in pull request #4. By making an effort to make only small changes to the code base, the flow and readability of the code remains in tact.

Thank you for maintaining such a great repository. Please let me know if you have any questions or comments.

@nsonntag
Copy link
Author

All tests passing.

mbarbon added a commit to mbarbon/uap-java that referenced this pull request Sep 2, 2017
@mormegil-cz
Copy link

Works great. As this repository seems not maintained much, I applied the patch locally. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants