Skip to content

Commit

Permalink
address https://www.reddit.com/r/uBlockOrigin/comments/12ox00r/
Browse files Browse the repository at this point in the history
  • Loading branch information
@stephenhawk8054
stephenhawk8054 committed Apr 17, 2023
1 parent 206fa15 commit 2cb3181
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions filters/unbreak.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4902,3 +4902,8 @@ doodle.com##.AdsLayout__top-container

! https://github.com/AdguardTeam/AdguardFilters/issues/148485
||hager.com/*/youtubeblocker.js$script,1p

! https://www.reddit.com/r/uBlockOrigin/comments/12ox00r/
||ensighten.com^$badfilter
||ensighten.com^$3p
||measure.ensighten.com^

11 comments on commit 2cb3181

@gorhill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this commit:

  • Redirects through ensighten.com will no longer be stopped by strict blocking
  • All filters in Peter Lowe's could be argued to be 3rd-party, at which point it no longer make sense to use the list

The resolution for this sort of issue when a user wants to visit a provider of advertisement and/or tracking service is to ask them to disable their blocker: the vast majority of uBO users have no interest in visiting such sites, and I don't like the idea of lowering uBO's defense against these services advertiser/tracker everywhere for everybody for the sake of a handful of people who somehow are interested in visiting the site of these providers.

@stephenhawk8054
Copy link
Member Author

@stephenhawk8054 stephenhawk8054 commented on 2cb3181 Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. I totally forgot about redirection cases. Yeah, I agree that switching it to 3p will lower defense against redirection. I'll revert the commit.

Should we check other cases that were switched to 3p, since I'm honestly not sure how to check if a domain is used for those purposes?

Reverted: ac8afa5

@gorhill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a discussion a while ago, we should just stop converting to 3p, and leave things unchanged for now for other cases we may have changed in the past -- we might revisit eventually.

@stephenhawk8054
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@stephenhawk8054
Copy link
Member Author

@stephenhawk8054 stephenhawk8054 commented on 2cb3181 Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill I wonder if could there be any ways to implement a redirection that's just based on part of the URL (not creating totally new URL). Some pre-defined simple patterns like ?url=. For example ||example.com^$redirect-url

It's not for this specific case of 1p-3p, since we don't know how each of these domains can be used for that purpose. But it would be useful for other common cases and it could reduce the complaints of strict-blocking

@gorhill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell my opinion without seeing specific cases related to what you suggest.

@stephenhawk8054
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. For example previously, there's a case of reddit when users are not logged in, they will automatically add an outbound link https://out.reddit.com/t3_tiak32?url= before the link of any reddit's post after user clicking on it. This might not happen when users are logged in.

Issue report: https://www.reddit.com/r/uBlockOrigin/comments/tihpyw/comment/i1f290z/?context=3

Steps to reproduce:

@gorhill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case you show is not a case of overzealous strict-blocking users complain about. You want to add strict blocking when a user click a reddit link?

@stephenhawk8054
Copy link
Member Author

@stephenhawk8054 stephenhawk8054 commented on 2cb3181 Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was intended to ask if we should add ||out.reddit.com/t3_*?url=$doc as a click tracking prevent filter when seeing the report, but I was afraid that it could cause quite big trouble for a big site like reddit.

But yes, I will need to find some better cases that were already strict-blocked with redirection links, but I think I would open an issue/discussion thread in uBlock-issues since it's better for discussions than commit comments.

@gorhill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could cause quite big trouble for a big site like reddit

Best to discuss this with other contributors in a discussion thread.

@stephenhawk8054
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, will do.

Please sign in to comment.