Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip empty lines #259

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Skip empty lines #259

merged 1 commit into from
Mar 20, 2020

Conversation

todeveni
Copy link
Contributor

Google Calendar public ICS calendars have an empty line at the end of the file and ics-parser tries to parse it into an key:value array.

  1   Illuminate\Foundation\Bootstrap\HandleExceptions::handleError("Trying to access array offset on value of type bool", "/vendor/johngrogg/ics-parser/src/ICal/ICal.php")
      /vendor/johngrogg/ics-parser/src/ICal/ICal.php:627

@u01jmg3 u01jmg3 self-assigned this Feb 10, 2020
@u01jmg3 u01jmg3 self-requested a review February 10, 2020 09:56
@u01jmg3 u01jmg3 assigned todeveni and unassigned u01jmg3 Feb 10, 2020
@u01jmg3
Copy link
Owner

u01jmg3 commented Feb 10, 2020 •
edited
Loading

Thanks for reporting

@u01jmg3 u01jmg3 added this to the v2.x.x milestone Mar 20, 2020
@u01jmg3 u01jmg3 merged commit c28e606 into u01jmg3:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u01jmg3 u01jmg3 u01jmg3 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@todeveni @u01jmg3