Check if the TZID provided is an invalid time zone #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-worked your code in 5c30627 |
u01jmg3
reviewed
Jun 22, 2017
| if($this->isValidTimeZoneId($dateArray[0]['TZID'])){ | ||
| $dateTime->setTimezone(new \DateTimeZone($dateArray[0]['TZID'])); | ||
| }else{ | ||
| $dateTime->setTimezone($this->defaultTimeZone); |
There was a problem hiding this comment.
Assume this should be $dateTime->setTimezone(new \DateTimeZone($this->defaultTimeZone));
u01jmg3
reviewed
Jun 22, 2017
| $dateTime->setTimezone(new \DateTimeZone($dateArray[0]['TZID'])); | ||
| }else{ | ||
| $dateTime->setTimezone($this->defaultTimeZone); | ||
| } |
There was a problem hiding this comment.
Next time please abide by the PSR-2 standard already used by this repo
u01jmg3
changed the title
|
Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at 668ea04 I wasn't able to parse my ICS files containing a non-valid DateTimeZoneId
W. Europe Standard Timewith https://github.com/u01jmg3/ics-parser/tree/v2.0.6, which reopened #116 for me. Since I assume that all changes were done on purpose and there was no mismatch between my composer-installed package and the v2.0.6 release I'm trying to offer this (hopefully none-intrusive) pull request!Any feedback is much appreciated, since I don't have a lot of experience with pull requests at all!
Best regards