Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual section on RLC inference #6340

Merged
merged 16 commits into from
Jan 28, 2024

Conversation

msridhar
Copy link
Contributor

@msridhar msridhar commented Dec 4, 2023

This uncomments a previously-written manual section on the RLC inference algorithm and edits it to reflect that RLC inference has fully landed in the master branch (once #6278 lands).

@msridhar
Copy link
Contributor Author

msridhar commented Dec 4, 2023

@kelloggm I left this as a draft as I think it'd be good if you could make a pass. The text currently refers to an -Ainfer flag but that is only mentioned in the WPI chapter section "How whole-program inference works". Maybe this text should instead refer to wpi.sh? When you have time (not urgent), if you could take a look that would be great.

@mernst
Copy link
Member

mernst commented Jan 16, 2024

@kelloggm A ping in case this fell through the cracks.

kelloggm
kelloggm previously approved these changes Jan 17, 2024
Copy link
Contributor

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mernst - you are right that this fell through the cracks over the holidays.

I think this can be merged as soon as my one comment is addressed.

docs/manual/resource-leak-checker.tex Outdated Show resolved Hide resolved
@mernst mernst assigned msridhar and unassigned kelloggm Jan 18, 2024
@msridhar msridhar marked this pull request as ready for review January 19, 2024 04:47
@msridhar msridhar assigned kelloggm and unassigned msridhar Jan 19, 2024
@msridhar
Copy link
Contributor Author

@kelloggm this is ready for another look

kelloggm
kelloggm previously approved these changes Jan 19, 2024
Copy link
Contributor

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msridhar msridhar enabled auto-merge (squash) January 19, 2024 17:17
@mernst
Copy link
Member

mernst commented Jan 22, 2024

Should there be a CHANGELOG entry for this feature?

@msridhar
Copy link
Contributor Author

Should there be a CHANGELOG entry for this feature?

@mernst full RLC inference landed as of Checker Framework version 3.42.0. Should I update the release notes for that version?

@msridhar msridhar requested a review from mernst January 26, 2024 18:47
@msridhar msridhar assigned mernst and unassigned kelloggm Jan 26, 2024
@msridhar
Copy link
Contributor Author

Should there be a CHANGELOG entry for this feature?

@mernst full RLC inference landed as of Checker Framework version 3.42.0. Should I update the release notes for that version?

@mernst ping on the question above. Let me know where we should add a CHANGELOG entry for this feature, if you think it is needed.

@mernst
Copy link
Member

mernst commented Jan 26, 2024

Please put the changelog entry for the upcoming release.

  1. We don't change release notes for previous releases (they are already out in the world).
  2. If a feature isn't documented, it isn't really done, so we can think of this release as the one that implements the feature.

Thank you!

docs/manual/resource-leak-checker.tex Outdated Show resolved Hide resolved
docs/manual/resource-leak-checker.tex Outdated Show resolved Hide resolved
docs/manual/resource-leak-checker.tex Outdated Show resolved Hide resolved
@mernst mernst assigned msridhar and unassigned mernst Jan 26, 2024
msridhar and others added 3 commits January 26, 2024 12:45
Co-authored-by: Michael Ernst <mernst@alum.mit.edu>
Co-authored-by: Michael Ernst <mernst@alum.mit.edu>
@msridhar msridhar removed their assignment Jan 27, 2024
@msridhar msridhar requested a review from mernst January 27, 2024 00:37
Copy link
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msridhar msridhar merged commit d4c9732 into typetools:master Jan 28, 2024
29 checks passed
@msridhar msridhar deleted the rlc-inference-manual branch January 28, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants