-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual section on RLC inference #6340
Conversation
@kelloggm I left this as a draft as I think it'd be good if you could make a pass. The text currently refers to an |
@kelloggm A ping in case this fell through the cracks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mernst - you are right that this fell through the cracks over the holidays.
I think this can be merged as soon as my one comment is addressed.
@kelloggm this is ready for another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should there be a CHANGELOG entry for this feature? |
@mernst full RLC inference landed as of Checker Framework version 3.42.0. Should I update the release notes for that version? |
@mernst ping on the question above. Let me know where we should add a CHANGELOG entry for this feature, if you think it is needed. |
Please put the changelog entry for the upcoming release.
Thank you! |
Co-authored-by: Michael Ernst <mernst@alum.mit.edu>
Co-authored-by: Michael Ernst <mernst@alum.mit.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This uncomments a previously-written manual section on the RLC inference algorithm and edits it to reflect that RLC inference has fully landed in the master branch (once #6278 lands).