Handle EnsuresCalledMethods.List when checking field ownership

[Calvin-L]

Fixes #5911.

Please let me know if there is a shorter or more canonical way to write getEnsuresCalledMethodsAnnotations; this seems like something a lot of checkers have to do, but I couldn't find an appropriate helper method.

[kelloggm]

Please let me know if there is a shorter or more canonical way to write getEnsuresCalledMethodsAnnotations; this seems like something a lot of checkers have to do, but I couldn't find an appropriate helper method.

I'm not aware of an appropriate helper method, and the existence of CreatesMustCallForToJavaExpression#getCreatesMustCallForAnnos, which your implementation is patterned on, suggests that I wasn't aware of one when I wrote it, either.

I think such a helper method could be useful. I would put it in one of the subclasses of AnnotatedTypeFactory or maybe in AnnotatedTypeFactory itself; its signature would look something like:

AnnotationMirrorSet getRepeatableDeclAnnotation(AnnotatedTypeFactory this, ExecutableElement target, Class<?> annoClazz, Class<?> annoListClazz, ExecutableElement listValueElt);

The implementation could be patterned on the code in this PR for @EnsuresCalledMethods and the code in getCreatesMustCallForAnnos for @CreatesMustCallFor.

@smillst does this helper method sound reasonable to you? Is there an existing alternative that I'm unaware of?

[smillst]

I couldn't find a helper method that looked for a specific repeatable annotation. AnnotatedTypeFactory#getDeclAnnotationWithMetaAnnotation looks for repeated annotations with a specific meta annotation. We could copy the functionality for repeated annotations into a more general helper method like @kelloggm suggests. But implementing that helper method doesn't need to hold up this PR.