Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CFGTranslationPhaseOne#findOwner() for lambdas #5045

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Fix CFGTranslationPhaseOne#findOwner() for lambdas #5045

merged 6 commits into from
Feb 8, 2022

Conversation

smillst
Copy link
Member

@smillst smillst commented Feb 8, 2022

Fixes #5042.

(I didn't change CFAbstractTransfer#initialStore because I think that method is doing something different with initializer blocks.)

mernst
mernst approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The comments are very informative, thanks.

@mernst mernst enabled auto-merge (squash) February 8, 2022 18:48
@mernst mernst merged commit 4c9c5d9 into typetools:master Feb 8, 2022
@mernst mernst deleted the issue5042 branch February 8, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mernst mernst mernst approved these changes

Assignees

@mernst mernst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.21.2 infers wrong type for locals assigned to by conditional expression
2 participants
@smillst @mernst