#804 - correct types for Set and Seq derived types with interpreted serde - basis for #803 #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit caed43956187a52f1a37d8192b70bd9ecf297a1f)
…shtrieset no longer there on 2.13
…shtrieset no longer there on 2.13
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 95.46% 95.58% +0.11%
==========================================
Files 67 68 +1
Lines 1257 1290 +33
Branches 42 49 +7
==========================================
+ Hits 1200 1233 +33
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chris-twiner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is included in #806
per #804 existing encoder derivation for Seqs does not support interpreted evaluation with the correct types, similar for Set.
This PR adds wrappers around the types and MapObjects to ensure correct type usage and moves Set to it allowing TreeSet and ListSet encoder derivation.
based on master without #803 or #787 related code.