Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility asJoinColValue to allow join on Value class dataset #695

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

cchantep
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #695 (d675046) into master (65fad0a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          65       65           
  Lines        1183     1184    +1     
  Branches       39       28   -11     
=======================================
+ Hits         1124     1125    +1     
  Misses         59       59           
Flag Coverage Δ
2.12.16 95.01% <100.00%> (+<0.01%) ⬆️
2.13.10 95.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ataset/src/main/scala/frameless/TypedDataset.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@cchantep cchantep merged commit 0c05bcf into master Mar 19, 2023
@cchantep cchantep deleted the feature/asJoinColValue branch March 19, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants