Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date time functions #355

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Date time functions #355

merged 1 commit into from
Jan 3, 2019

Conversation

kujon
Copy link
Contributor

@kujon kujon commented Dec 20, 2018

#164

  • quarter
  • month
  • dayofweek
  • dayofmonth
  • dayofyear
  • hour
  • minute
  • second
  • weekofyear

@codecov-io
Copy link

codecov-io commented Dec 20, 2018

Codecov Report

Merging #355 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   96.89%   96.92%   +0.02%     
==========================================
  Files          60       60              
  Lines        1032     1041       +9     
  Branches       10       10              
==========================================
+ Hits         1000     1009       +9     
  Misses         32       32
Impacted Files Coverage Δ
...la/frameless/functions/NonAggregateFunctions.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09422e1...626df1a. Read the comment docs.

@imarios
Copy link
Contributor

imarios commented Dec 20, 2018

@kujon thank you! I went through the PR quickly and it looks good. Can you do me a favor? We just merge into master an upgrade to Spark 2.4 and cross compilation with Scala 2.11 and 2.12. Can you try to rebase this PR with master?

@kujon
Copy link
Contributor Author

kujon commented Dec 21, 2018

@imarios happily. will do it today.

@kujon
Copy link
Contributor Author

kujon commented Dec 21, 2018

Done

@kujon
Copy link
Contributor Author

kujon commented Jan 3, 2019

Hi @imarios, could you please give any estimates on when you're gonna be able to release this? Could use some of those functions in my project ^^

@imarios
Copy link
Contributor

imarios commented Jan 3, 2019

@kujon I wanted to merge this before the release went out and totally forgotten about it :( ... Let me merge it now

@imarios imarios merged commit 68667d5 into typelevel:master Jan 3, 2019
@kujon
Copy link
Contributor Author

kujon commented Jan 3, 2019

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants