Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: django_stubs_ext: monkeypatch reveal_{type,locals} into builtins #591

Merged
merged 4 commits into from
Apr 14, 2021
Merged

WIP: django_stubs_ext: monkeypatch reveal_{type,locals} into builtins #591

merged 4 commits into from
Apr 14, 2021

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 13, 2021

Closes #590.

@blueyed blueyed mentioned this pull request Apr 13, 2021
Closed
@blueyed
Copy link
Contributor Author

blueyed commented Apr 13, 2021

Any suggestions for a test, and/or how to proceed here in general?

sobolevn
sobolevn reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

django_stubs_ext/django_stubs_ext/patch.py Outdated Show resolved Hide resolved
django_stubs_ext/django_stubs_ext/patch.py Outdated Show resolved Hide resolved
@sobolevn
Copy link
Member

Any suggestions for a test, and/or how to proceed here in general?

We can test that after calling monkeypatch, we can use reveal_type in our regular python code.

@blueyed
Copy link
Contributor Author

blueyed commented Apr 13, 2021

Added some rough test for now - happy to improve it later.

sobolevn
sobolevn approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@sobolevn sobolevn merged commit ee58b18 into typeddjango:master Apr 14, 2021
@sobolevn
Copy link
Member

Looks like I need to release django_stubs_ext. Will do later today!

@blueyed blueyed deleted the monkeypatch-reveal branch April 14, 2021 09:35
@blueyed
Copy link
Contributor Author

blueyed commented Apr 14, 2021

Looks like I need to release django_stubs_ext. Will do later today!

Let's hold this back a bit: #590 (comment)

@blueyed blueyed mentioned this pull request May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'reveal_type' is not defined when using mypy_django_plugin
2 participants
@blueyed @sobolevn