Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list-dropdown): restore display of secondaryLabel #690

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(list-dropdown): restore display of secondaryLabel #690

wants to merge 2 commits into from
+11 −5

Conversation

MikeMatusz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: n/a
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? n/a

Describe the new behavior?

The secondaryLabel property of list dropdown options now uses the correct slot to display as it did in Forge 2.0.

Additional information

@MikeMatusz MikeMatusz requested a review from a team as a code owner September 19, 2024 18:53
@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the patch Increment the patch version when merged label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MikeMatusz