Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): keep native submit or reset button in the dom for implicit form submission #640

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samrichardsontylertech
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: N
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

This adds a persistent slotted, hidden <button type="submit"></button> or <button type="reset"></button> to the base button component to enable implicit form submission, e.g. when a user presses the enter key while a form input is focused.

@samrichardsontylertech samrichardsontylertech added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Jun 27, 2024
@samrichardsontylertech samrichardsontylertech requested a review from a team as a code owner June 27, 2024 19:54
Copy link

stackblitz bot commented Jun 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants