Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chip-field): refactor to use <forge-field> #518

Merged
merged 8 commits into from
Apr 4, 2024
Merged

feat(chip-field): refactor to use <forge-field> #518

merged 8 commits into from
Apr 4, 2024

Conversation

DRiFTy17
Copy link
Collaborator

@DRiFTy17 DRiFTy17 commented Apr 3, 2024

  • Refactor to use <forge-field> internally
  • Update styles, patterns, and logic
  • Migrate tests to WTR
  • Fix small bugs in field styles

@DRiFTy17 DRiFTy17 added minor Increment the minor version when merged skip-release Preserve the current version when merged @next labels Apr 3, 2024
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner April 3, 2024 16:50
@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

samrichardsontylertech
samrichardsontylertech requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@samrichardsontylertech samrichardsontylertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though I found two small issues with it. When you switch to the extra-small density with an inset label a little space remains above the chips. Also, changing the theme should also change the them of the chips.

@DRiFTy17 DRiFTy17 merged commit 20a9d3a into next Apr 4, 2024
6 checks passed
@DRiFTy17 DRiFTy17 deleted the next-chip-field-refactor branch April 4, 2024 17:24
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.22 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Apr 11, 2024
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Merged
Merged
This was referenced May 17, 2024
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech