Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dialog] refactor to use native <dialog> #513

Merged
merged 20 commits into from
Apr 1, 2024
Merged

[dialog] refactor to use native <dialog> #513

merged 20 commits into from
Apr 1, 2024

Conversation

DRiFTy17
Copy link
Collaborator

  • Uses native <dialog> for :top-layer support
  • Adds a new "preset" mechanism for the common "sheet" design
  • Removed open/close callbacks in favor of equivalent events
  • Removed escapeClose and backdropClose properties/attributes in favor of a new persistent property/attribute
  • Animates out on hide

@DRiFTy17
chore: initial work to use native <dialog>
a9554a7
@DRiFTy17
Merge branch 'next' into next-dialog-refactor
5b395cc
@DRiFTy17
chore: refactor backdrop and animations
0877d60
@DRiFTy17
chore: added presets, fixed bugs, started migrated APIs from 2.x impl
a307b4a
@DRiFTy17
chore: fix containment bugs
81f7f40
@DRiFTy17
chore: position strategy and preset adjustments
2bbd75b
@DRiFTy17
Merge branch 'next' into next-dialog-refactor
558971f
@DRiFTy17
chore: fix lint error
edf560f
@DRiFTy17
feat(dialog): implemented moveable functionality
439020e
@DRiFTy17
chore(dialog): organize styles and tokens
c628f5e
@DRiFTy17
chore(dialog): replace persistent with dismissible and set modal …
4469518 
…dialogs to not be dismissible via escape or backdrop click by default
@DRiFTy17
chore(dialog): separate spacing tokens and update placement overrides…
50144bb 
… for specific logical spacing adjustments
@DRiFTy17
chore(dialog): write initial tests
4371ba8
@DRiFTy17 DRiFTy17 added minor Increment the minor version when merged skip-release Preserve the current version when merged @next labels Mar 29, 2024
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner March 29, 2024 17:28
@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 25708ee into next Apr 1, 2024
6 checks passed
@DRiFTy17 DRiFTy17 deleted the next-dialog-refactor branch April 1, 2024 20:49
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.22 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Apr 11, 2024
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Merged
Merged
This was referenced May 17, 2024
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech