Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(switch): remove input elements and bring up to date with latest patterns #511

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

samrichardsontylertech
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: Y
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? Y

Describe the new behavior?

Removed the internal input element and support for slotting an input. The host element itself is now the semantic switch. Other changes have been made to use the more current patterns being employed by other form-associated components, such as default ARIA and mixins.

Closes #510

@samrichardsontylertech samrichardsontylertech added skip-release Preserve the current version when merged @next labels Mar 26, 2024
@samrichardsontylertech samrichardsontylertech requested a review from a team as a code owner March 26, 2024 21:39
Copy link

stackblitz bot commented Mar 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Collaborator

@DRiFTy17 DRiFTy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but we should probably remove the "Exposed input" demo from the switch.ejs page as well.

src/lib/switch/switch-foundation.ts Outdated Show resolved Hide resolved
@DRiFTy17 DRiFTy17 added the minor Increment the minor version when merged label Mar 28, 2024
@DRiFTy17 DRiFTy17 merged commit a050c39 into next Mar 28, 2024
9 checks passed
@DRiFTy17 DRiFTy17 deleted the switch-next branch March 28, 2024 12:56
Copy link
Contributor

🚀 PR was released in v3.0.0-next.22 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants