feat(expansion-panel): refactor to use CSS (grid) based animation and convert to use tokens and updated patterns #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… convert to use tokens and updated patterns
DRiFTy17
added
minor
DRiFTy17
requested review from
MikeMatusz,
nickonometry and
samrichardsontylertech
|
|
samrichardsontylertech
previously approved these changes
Mar 12, 2024
MikeMatusz
approved these changes
Mar 12, 2024
DRiFTy17
added
skip-release
|
🚀 PR was released in |
This was referenced Apr 11, 2024
This was referenced May 1, 2024
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Refactored the expansion panel to use CSS-based animation, added support for design tokens, and updated to use new component patterns/structure.
We no longer need the older CSS variables so those were all removed. Additionally, scrollable content is now to be managed by the slotted content. This could cause a scrollbar to show briefly when the panel is animating, but this can be hidden using the following selector: