Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(banner): refactor to use design tokens and updated patterns #464

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

DRiFTy17
Copy link
Collaborator

@DRiFTy17 DRiFTy17 commented Feb 6, 2024

  • Updated to use design tokens
  • Refactored and simplified logic
  • Removed forge-banner-undimissed event
  • Only dispatch forge-banner-dismissed event when user clicks dismiss button
  • Use grid-based transition for dismiss animation
  • Simplified template and styles
  • Use inert attribute when dismissed
  • Deprecated canDismiss property/attribute in favor of inverted persistent property/attribute
  • Use @container query for responsiveness

Version

Published prerelease version: v3.0.0-next.18

Changelog

🚀 Enhancement

🐛 Bug Fix

  • [@next] refactor setDefaultAria to use ElementInternals as fallback #445 (@DRiFTy17)
  • [@next] general cleanup, fixes, and organization #444 (@DRiFTy17)
  • chore: refactor token organization and usage patterns #440 (@DRiFTy17)
  • [@next] chore: refactor slider to extend BaseFormComponent #427 (@DRiFTy17)
  • chore(list-item): improve anchor handling and semantics #423 (@DRiFTy17)
  • chore: general cleanup and consistency sweep #421 (@DRiFTy17)
  • fix: fix publish automation (@DRiFTy17)
  • fix: fix auto version calculation (@DRiFTy17)
  • [next] fix dialog story #211 (@DRiFTy17)
  • fix: package-lock sync (@DRiFTy17)
  • fix: remove base branch from shipit command (@DRiFTy17)
  • fix: update release workflow to only publish on pre-release tags (@DRiFTy17)

⚠️ Pushed to next

Authors: 3

@DRiFTy17 DRiFTy17 added minor Increment the minor version when merged @next labels Feb 6, 2024
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner February 6, 2024 15:05
Copy link

stackblitz bot commented Feb 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 33b106c into next Feb 6, 2024
12 checks passed
@DRiFTy17 DRiFTy17 deleted the next-refactor-banner branch February 6, 2024 17:18
Copy link
Contributor

github-actions bot commented Feb 6, 2024

🚀 PR was released in v3.0.0-next.18 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants