Prefer unittest.mock but require mock for python < 3.3. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit tests require mock but don't specify it, which causes
problems for any usages outside tox (e.g. testing that changes to
twisted don't break klein). Use PEP508 to specify environment markers
and only install mock when required. Tests can then conditionally
import unittest.mock and fall back to mock.
The conditional imports do raise a mypy error, discussed here:
python/mypy#1153
So an annotation is required to silence this specific warning.
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=========================================
+ Coverage 95.89% 95.9% +0.01%
=========================================
Files 12 12
Lines 1558 1564 +6
Branches 86 86
=========================================
+ Hits 1494 1500 +6
Misses 52 52
Partials 12 12
Continue to review full report at Codecov.
|
wsanchez
approved these changes
Nov 28, 2017
|
Looks good, thanks! |
|
Fixes #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests require mock but don't specify it, which causes
problems for any usages outside tox (e.g. testing that changes to
twisted don't break klein). Use PEP508 to specify environment markers
and only install mock when required. Tests can then conditionally
import unittest.mock and fall back to mock.
The conditional imports do raise a mypy error, discussed here:
python/mypy#1153
So an annotation is required to silence this specific warning.