feat(badge): add notification variant #3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3a5f112 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:M
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3a5f112. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: +45 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a5f112:
|
Passing run #8265 ↗︎
Details:
Review all test suite changes for PR #3993 ↗︎ |
|||||||||||||||
github-actions
bot
added
Type: Documentation
serifluous
reviewed
Jul 18, 2024
| @@ -405,6 +405,19 @@ Use a small Badge only when vertical density is a concern. The guidelines for us | |||
| `.trim()} | |||
| </LivePreview> | |||
|
|
|||
| ### Notification Counter | |||
There was a problem hiding this comment.
suggestion: Combine this section with the existing "Counter" section and replace the content with this:
Use the counter Badge to visually highlight a count in a UI, like the number of pending invitations or the number of errors.
Counter Badges have neutral, error, and notification variants. The error variant should always include an error icon. The notification variant informs users of new or unread items, such as messages, notifications, or updates.
There was a problem hiding this comment.
I like it, added to upcoming commit
nkrantz
previously approved these changes
Jul 18, 2024
|
TODO/nit-pick: add notification badge example to first code example of badges on the docs. |
dosubot
bot
added
size:L
serifluous
approved these changes
Jul 18, 2024
roxanagomez
approved these changes
Jul 18, 2024
krisantrobus
added
the
🕵🏻♀️ Run website visual regression
Passing run #8267 ↗︎
Details:
Review all test suite changes for PR #3993 ↗︎ |
|||||||||||||||
nkrantz
approved these changes
Jul 18, 2024
krisantrobus
added
🚀 merge it!
and removed
Status: Do Not Merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily introduces a new badge variant,
notification_counter, to the badge component inpackages/paste-core/components/badge.It uses the new design tokens for notifications