-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add brand badges #3798
feat: add brand badges #3798
Conversation
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: f9b1149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f9b1149. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
Size Change: +1.09 kB (0%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9b1149:
|
fbe2977
to
149f15b
Compare
Passing run #7873 ↗︎
Details:
Review all test suite changes for PR #3798 ↗︎ |
@@ -78,6 +78,21 @@ export const badgeVariantStyles: { | |||
color: "colorTextDecorative40", | |||
boxShadow: "shadowBorderDecorative40Weaker", | |||
}, | |||
brand10: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why are using brand10/20/30
instead of brandTwilio/Segment/Sendgrid
? I don't think we will ever have brands in between Twilio and SendGrid, so we don't need the 10gap to fill in missed values. Each brand is unique and probably doesn't need to be guessable, since they are known entities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @serifluous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The brand team wants to move away from having brand colors map to specific products, which makes sense since Email is going to be moved into Console soon. The brand10/20/30 naming makes it a little more flexible to whatever happens when the products are more unified.
Passing run #7874 ↗︎
Details:
Review all test suite changes for PR #3798 ↗︎ |
This pull request primarily focuses on adding new badge variants and related design tokens to the Twilio Paste design system. The new badge variants are
brand10
,brand20
, andbrand30
, and the new design tokens are shadow border tokens for these new badge variants.Here are the most significant changes:
New Badge Variants:
packages/paste-core/components/badge/src/constants.ts
: Addedbrand10
,brand20
, andbrand30
to theBadgeVariants
constant.packages/paste-core/components/badge/src/styles.ts
: Added styles for the new badge variants inbadgeVariantStyles
andbadgeButtonStyles
. [1] [2]packages/paste-core/components/badge/stories/index.stories.tsx
: Added examples of the new badge variants in theAllBadges
,SmallBadges
,Brand10Badge
,Brand20Badge
, andBrand30Badge
components. [1] [2] [3]New Design Tokens:
.changeset/bright-steaks-rhyme.md
&.changeset/soft-files-film.md
: Added new design tokens for the new badge variants. [1] [2]packages/paste-design-tokens/__tests__/__snapshots__/index.test.tsx.snap
: Updated snapshots to reflect the new design tokens. [1] [2] [3] [4] [5]Type Updates:
packages/paste-core/components/badge/type-docs.json
,packages/paste-core/components/menu/type-docs.json
,packages/paste-core/components/popover/type-docs.json
,packages/paste-core/primitives/box/type-docs.json
,packages/paste-core/primitives/sibling-box/type-docs.json
,packages/paste-core/primitives/text/type-docs.json
: Updated thevariant
type to include the new badge variants. [1] [2] [3] [4] [5] [6]Other Changes:
packages/paste-core/components/badge/stories/index.stories.tsx
: Imported new icons to be used in the badge examples.