Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, cache): add support for join raid and mention raid protection #2204

Merged
merged 6 commits into from
Jun 13, 2023
Merged

feat(model, cache): add support for join raid and mention raid protection #2204

merged 6 commits into from
Jun 13, 2023

Conversation

suneettipirneni
Copy link
Member

@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature labels May 6, 2023
@suneettipirneni suneettipirneni self-assigned this May 6, 2023
laralove143
laralove143 requested changes May 6, 2023
View reviewed changes
Copy link
Member

@laralove143 laralove143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are possibly missing, and I can't find the docs at https://discord.com/developers/docs, have these documentation changes been merged

twilight-cache-inmemory/src/test.rs Outdated Show resolved Hide resolved
twilight-cache-inmemory/src/event/guild.rs Outdated Show resolved Hide resolved
twilight-model/src/guild/auto_moderation/mod.rs Outdated Show resolved Hide resolved
@suneettipirneni
Copy link
Member Author

Some tests are possibly missing, and I can't find the docs at https://discord.com/developers/docs, have these documentation changes been merged

The PR is merged. Sometimes the docs don't get regenerated right after the PRs are merged.

@laralove143
Copy link
Member

Let’s hold it off until the docs are updated then, unless it takes too long

@suneettipirneni
Copy link
Member Author

The docs are now live for this feature.

@laralove143
Copy link
Member

could you also resolve the conversations?

HTGAzureX1212
HTGAzureX1212 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@suneettipirneni @Gelbpunkt
Update twilight-cache-inmemory/src/model/guild.rs
c5d3818 
Co-authored-by: Jens Reidel <adrian@travitia.xyz>
@Gelbpunkt Gelbpunkt merged commit c992f93 into twilight-rs:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilgotf vilgotf vilgotf approved these changes

@Gelbpunkt Gelbpunkt Gelbpunkt approved these changes

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

@laralove143 laralove143 laralove143 approved these changes

@itohatweb itohatweb Awaiting requested review from itohatweb

Assignees

@suneettipirneni suneettipirneni

Labels
c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suneettipirneni @laralove143 @vilgotf @Gelbpunkt @HTGAzureX1212