refactor(model): abstract null boolean visitor #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract the `RoleTags::premium_subscriber` null boolean visitor to the visitor module. Work is being done on adding a new field that functions exactly like `RoleTags::premium_subscriber`, where a missing field means false and a null value means true. It's best to abstract the visitor built for the field so it can be re-used elsewhere.
github-actions
bot
added
c-model
zeylahellyer
added a commit
that referenced
this pull request
Jan 5, 2023
Add support for guild role subscriptions. This involves: - a new `RoleSubscriptionPurchase` variant on `MessageType` - four new guild features: - `CreatorMonetizableProvisional` - `CreatorStorePage` - `RoleSubscriptionsAvailableForPurchase` - `RoleSubscriptionsEnabled` - a new `GuildSubscription` variant on `GuildIntegrationType` - two new role tag fields: - `available_for_purchase` (bool) - `subscription_listing_id` (optional snowflake) Depends on PR #2030 since it makes `GuildIntegrationType` into an enum which this adds a variant to, is related to #2032 since it abstracts the optional null boolean, and relates to #2033 since it reworks tests this adds to. API docs: discord/discord-api-docs@e003051 Closes #2027.
zeylahellyer
added a commit
that referenced
this pull request
Jan 5, 2023
Add support for guild role subscriptions. This involves: - a new `RoleSubscriptionPurchase` variant on `MessageType` - four new guild features: - `CreatorMonetizableProvisional` - `CreatorStorePage` - `RoleSubscriptionsAvailableForPurchase` - `RoleSubscriptionsEnabled` - a new `GuildSubscription` variant on `GuildIntegrationType` - two new role tag fields: - `available_for_purchase` (bool) - `subscription_listing_id` (optional snowflake) Relates to #2032 since it abstracts the optional null boolean, and relates to #2033 since it reworks tests this adds to. API docs: discord/discord-api-docs@e003051 Closes #2027.
zeylahellyer
added a commit
that referenced
this pull request
Jan 5, 2023
Add support for guild role subscriptions. This involves: - a new `RoleSubscriptionPurchase` variant on `MessageType` - four new guild features: - `CreatorMonetizableProvisional` - `CreatorStorePage` - `RoleSubscriptionsAvailableForPurchase` - `RoleSubscriptionsEnabled` - a new `GuildSubscription` variant on `GuildIntegrationType` - two new role tag fields: - `available_for_purchase` (bool) - `subscription_listing_id` (optional snowflake) Relates to #2032 since it abstracts the optional null boolean, and relates to #2033 since it reworks tests this adds to. API docs: discord/discord-api-docs@e003051 Closes #2027.
vilgotf
approved these changes
Jan 6, 2023
7596ff
approved these changes
Jan 6, 2023
7596ff
pushed a commit
that referenced
this pull request
Jan 17, 2023
Add support for guild role subscriptions. This involves: - a new `RoleSubscriptionPurchase` variant on `MessageType` - four new guild features: - `CreatorMonetizableProvisional` - `CreatorStorePage` - `RoleSubscriptionsAvailableForPurchase` - `RoleSubscriptionsEnabled` - a new `GuildSubscription` variant on `GuildIntegrationType` - two new role tag fields: - `available_for_purchase` (bool) - `subscription_listing_id` (optional snowflake) Relates to #2032 since it abstracts the optional null boolean, and relates to #2033 since it reworks tests this adds to. Closes #2027.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract the
RoleTags::premium_subscribernull boolean visitor to the visitor module. Work is being done on adding a new field that functions exactly likeRoleTags::premium_subscriber, where a missing field means false and a null value means true. It's best to abstract the visitor built for the field so it can be re-used elsewhere.