Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix desc around deprecated Sass mixins for alerts and list groups #39537

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 29, 2023

Description

This PR fixes the Alerts and List group documentation pages based on the deprecation of their respective alert-variant() and list-group-item-variant() mixins:

  • in the Sass loops section, don't mention anymore the mixin but the override of CSS variables
  • in the Sass mixins section, drop entirely the sentence that isn't true anymore

This PR also fixes some minor issues in the migration guide:

  • Drop the dot prefixing the name of the mixins
  • Use the right name for the deprecated list group mixin

Type of changes

  • Documentation fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review December 29, 2023 07:53
@julien-deramond julien-deramond merged commit 85b1d1c into main Dec 30, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-sass-mixins-for-alerts-and-list-groups branch December 30, 2023 07:48
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants