Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: stop running coveralls in forks #39096

Merged
merged 3 commits into from
Jan 9, 2024
Merged

CI: stop running coveralls in forks #39096

merged 3 commits into from
Jan 9, 2024

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Aug 23, 2023

No description provided.

@XhmikosR
Copy link
Member Author

Not sure if this will work for PRs... It probably won't. My plan is to stop this from running when we are not on our repo or a PR against our repo.

@@ -46,6 +46,7 @@ jobs:

- name: Run Coveralls
uses: coverallsapp/github-action@v2
if: github.repository == 'twbs/bootstrap'
Copy link
Member

@julien-deramond julien-deramond Oct 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe both are working but I've seen and used another approach to do that:

Suggested change
if: github.repository == 'twbs/bootstrap'
if: github.repository_owner == 'twbs'

If I remember well, the job starts but is canceled because of the condition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could probably just use this too:

if: ${{ !github.event.repository.fork }}

@XhmikosR XhmikosR changed the title CI: Run Coveralls action only in our repo CI: stop running coveralls in forks Dec 23, 2023
@XhmikosR XhmikosR marked this pull request as ready for review December 23, 2023 17:37
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it on a forked Bootstrap and it seems to work quite well. Didn't tried inside a PR against our repo.

@XhmikosR XhmikosR merged commit a34ffb3 into main Jan 9, 2024
14 checks passed
@XhmikosR XhmikosR deleted the xmr/ci branch January 9, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants