Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a base class style display for toggle buttons #38708

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

ZhangChengLin
Copy link
Contributor

@ZhangChengLin ZhangChengLin commented Jun 5, 2023

Description

The basic style of the button, in the display of the toggle button state, looks better than the normal color button from the visual difference. Does not include the Outlined style.

In addition, I hope that Bootstrap can provide the corresponding component function of this switch button, that is, the switch event of the corresponding button state. The button component is a rare component among Bootstrap's excellent components that has not yet provided JavaScript events.

Motivation & Context

Type of changes

  • [N/A] Bug fix (non-breaking change which fixes an issue)
  • [N/A] New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • [N/A] Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • [N/A] I have added tests to cover my changes
  • [N/A] All new and existing tests passed

Live previews

Related issues

@ZhangChengLin ZhangChengLin marked this pull request as ready for review June 5, 2023 15:20
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this just adds more examples, I'm fine adding it.

@mdo mdo merged commit 2c7f888 into twbs:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants