Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Issues assignment' section to the Contributing Guidelines #38616

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 17, 2023

Description

This PR suggests adding a new section to our Contributing Guidelines named 'Issues assignment' that explains that we don't assign issues to contributors and why.

Motivation & Context

As maintainers, we often get asked to assign issues to contributors. We don't do that for several reasons.
IMO it's important to explain why we don't do that in our Contributing Guidelines to avoid frustration and confusion for contributors.
On our side, it will allow us having a link to point to when we get asked to assign issues.

On my side, if it is merged, I'll update my GitHub Saved reply to point to this section that I'll be able to share here as a comment right after if you're interested.
Having the same kind of answers would bring consistency and coherence to our answers.

Improvement 1

I wanted to add to this PR a message at the end of all newly created issues (via the issues template) to point to this section but it's not possible to do it. Some sources that confirm it:

So I'll try to provide a GitHub Action later, as a second step, to add this message to all newly created issues.
Edit: done via #38622

Improvement 2

Still IMHO, at some point, it would be nice to have a kind of "pr welcome" label to add to issues when they are ready to develop for maintainers or contributors, and/or a kind of "core team only" if this can't be treated outside because of the complexity or any other reasons. It would be a good way to help contributors to find issues to work on and would bring some clarity on who can do what to help us.

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • (N/A) All new and existing tests passed

Live previews

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mdo mdo merged commit 1a82228 into main Jun 1, 2023
@mdo mdo deleted the main-jd-add-issue-assignment-section-to-contributing-guidelines branch June 1, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants