Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] Update lint-staged: 10.2.11 → 10.5.3 (minor) #116

Merged
merged 1 commit into from
Feb 2, 2021
Merged

[js] Update lint-staged: 10.2.11 → 10.5.3 (minor) #116

merged 1 commit into from
Feb 2, 2021

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented Feb 2, 2021

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ lint-staged (10.2.11 → 10.5.3) · Repo

Release Notes

10.5.3

10.5.3 (2020-12-04)

Bug Fixes

  • better logging for errors in js config files (#935) (292e882)

10.5.2

10.5.2 (2020-11-24)

Bug Fixes

  • use bibliography-style links in related posts section of readme (#932) (0ff2917), closes #931

10.5.1

10.5.1 (2020-10-31)

Bug Fixes

10.5.0

10.5.0 (2020-10-26)

Features

10.4.2

10.4.2 (2020-10-17)

Bug Fixes

  • update docs on supported config file extensions (#917) (78782f9)

10.4.1

10.4.1 (2020-10-16)

Bug Fixes

10.4.0

10.4.0 (2020-09-16)

Features

  • Add ability to use function as config (#913) (67a4d06)

10.3.0

10.3.0 (2020-09-03)

Features

  • Add support for adding lint-staged using pre-commit.com (#910) (d404d7d)

10.2.13

10.2.13 (2020-08-25)

Bug Fixes

10.2.12

10.2.12 (2020-08-25)

Bug Fixes

  • always use the default short diff format for submodules #902 (c7923ad)
  • ensure supportsColor.level exists before stringifying it (aa9898e)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 15 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Feb 2, 2021
@auto-add-label auto-add-label bot added the staged label Feb 2, 2021
@guardrails
Copy link

guardrails bot commented Feb 2, 2021

⚠️ We detected security issues in this pull request:
Mode: paranoid | Total findings: 629 | Considered vulnerability: 0

Hard-Coded Secrets (76)

electron/DEPS

Line 17 in 99c48c6

'b943d006a33ec5bc1743792d64724693eb357083',

electron/DEPS

Line 21 in 99c48c6

'2c4ee8a32a299eada3cd6e468bbd0a473bfea96d',

electron/DEPS

Line 23 in 99c48c6

'44468f858ce0d25c27bd5e674abfa104e0119738',

electron/DEPS

Line 26 in 99c48c6

'requests_version': 'e4d59bedfd3c7f4f254f4f5d036587bcd8152458',

electron/build/install-build-deps.sh

Line 303 in 99c48c6

EM_ARCHIVE_KEY_FINGER="084C6C6F39159EDB67969AA87DE089671804772E"

electron/script/external-binaries.json

Line 7 in 99c48c6

"sha": "3bfe114b49a15e4f15e2e3a9ee6699f1acdb89446badbaa4144869c72a7690ca"

electron/script/external-binaries.json

Line 12 in 99c48c6

"sha": "ceb3e10e8a860467efc327c7bbb473481268cc8575bdd39d51acf6eba635e343"

electron/script/external-binaries.json

Line 17 in 99c48c6

"sha": "b6a20fd1c2026f3792e7286bc768a7ebc261847b76449b49f55455e1f841fecd"

electron/script/sysroots.json

Line 3 in 99c48c6

"Sha1Sum": "a6a16cdd28137cb7f786b64fe5c872fd9eabb89a",

electron/script/sysroots.json

Line 8 in 99c48c6

"Sha1Sum": "38f276058c74e7485ca72b4cf0249bb3e01a56fe",

electron/script/sysroots.json

Line 13 in 99c48c6

"Sha1Sum": "3d4f737e30635690e43133140c810347bc951810",

electron/script/sysroots.json

Line 18 in 99c48c6

"Sha1Sum": "6550e92b11906c5120c72052cf5261354dd40611",

electron/script/sysroots.json

Line 23 in 99c48c6

"Sha1Sum": "03a127d932a07bbc245aafe995b8d6d8d6c18fa7",

electron/script/sysroots.json

Line 28 in 99c48c6

"Sha1Sum": "c1b4584e3d9b40d068f978354cb323f645ca0350",

electron/script/sysroots.json

Line 33 in 99c48c6

"Sha1Sum": "434009087a18f8013b1c5c633c5cc8d2c5eb759d",

electron/spec-main/fixtures/api/print-to-pdf.html

Line 75 in 99c48c6

<meta name="html-safe-nonce" content="5e93f4740f191dd83343db10ac53334e5a9a3f7b" data-pjax-transient="true" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 77 in 99c48c6

content="eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjVBOjUxMDc6QTJGQzE3OkRFMTVBMDo1RUM3NDZGMiIsInZpc2l0b3JfaWQiOiI4MTg3MjM0NjA4NzU3NjU0OTAiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ=="

electron/spec-main/fixtures/api/print-to-pdf.html

Line 79 in 99c48c6

<meta name="visitor-hmac" content="c5baf7885e92967e35a14d94695dc03bdd7cec4ca219828403b675434382bf18"

electron/spec-main/fixtures/api/print-to-pdf.html

Line 91 in 99c48c6

<meta name="google-site-verification" content="KT5gs8h0wvaagLKAVWq8bbeNwnZZK1r1XQysX3xurLU">

electron/spec-main/fixtures/api/print-to-pdf.html

Line 121 in 99c48c6

<meta http-equiv="x-pjax-version" content="772c1d3a4a9debb57d1f878d43eafbe7">

electron/spec-main/fixtures/api/print-to-pdf.html

Line 206 in 99c48c6

data-hydro-click-hmac="520d87e8f83281e6946b192f0f840552721c7fcba9b9c36d802e898a816314e2"

electron/spec-main/fixtures/api/print-to-pdf.html

Line 435 in 99c48c6

value="RSIooxAmiXbwwr2AtBbdxgaH5ciQ8sbcLnDSfjKDj3fwo94n/BMK6Mv0l2mZxBCyAMPCUvNmIQ/0yv1kcRrMlQ==" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 651 in 99c48c6

data-hydro-click-hmac="cd4f672ed9a2fa51ea92c28de162e81edb2d11a2aad6884ec89a6d60b21b1cfb"

electron/spec-main/fixtures/api/print-to-pdf.html

Line 722 in 99c48c6

value="25HybID6DyJ2KCHm2hfjEh2ztAl7t4n8lFwwFkyWV4rOhxOP1clnUv7GXchdpdIWmeJ87CjTJtJEHtPk4Tfy+Q==" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 738 in 99c48c6

value="b8jta+JWyPIfngTZggyQaKwwZrqEqwd087Gmf5GtgxA4NulBAPRbV0Fushc9nrqRhxUzlGj0ylDDFDKYDK7lqQ==" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 751 in 99c48c6

value="6Jz5l80LwuhLPkZXHyiYisT6yQpe8h8GjoGFGXiN2mZ5cVNdUOQxQ+PBw6gV4hoA+KCz0ELGXA42hjrZycudNQ==" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 777 in 99c48c6

value="91d16c57f6691aa48ace0ce3ed3b8858a5cc17971888875be86f58e78d6e184c" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 1504 in 99c48c6

data-hydro-click-hmac="e36501fbe26e81166c30178192f6644085f83ba404af98e05cdb482d5456175a"

electron/spec-main/fixtures/api/print-to-pdf.html

Line 2064 in 99c48c6

value="7U8TFujbBFYSubMu3xfPn0hVhqPKjIz67S3jmBcfjFP4WfL1vehsJppXzwBYpf6bzARORpnoI9Q9bwBqur4pIA==" /> <input

electron/spec-main/fixtures/api/print-to-pdf.html

Line 2082 in 99c48c6

value="gSimCfGSdxRvC9BVzqEVjVi55RD7WPdcQ9/1/FgDGfXW1qIjEzDksTH7ZptxMz90c5ywPhcHOnhzemEbxQB/TA==" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 2098 in 99c48c6

value="KLF3p/JQ8Hext+JndDBgWUcF/g/MCrA/gjLg6W0CLpK5XN1tb78D3BlIZ5h++uLTe1+E1dA+8zc6NV8p3ERpwQ==" />

electron/spec-main/fixtures/api/print-to-pdf.html

Line 2116 in 99c48c6

value="ffa795cb17c32595cf3ac5ccf6c714ebcd944aa5c19b8637da8323213a66757a" />

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-0600420bac25439fc2067d51c6aaa4ee11770577

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/0600420bac25439fc2067d51c6aaa4ee11770577/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:42:26 GMT","etag":"W/\"3601649b1f433390bb296fd32be0d785\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"C9A4:6695:0E0D:2D25:5ECD46F2","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4996","x-ratelimit-reset":"1590514322","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/23635","id":419611668,"node_id":"MDExOlB1bGxSZXF1ZXN0NDE5NjExNjY4","html_url":"https://github.com/electron/electron/pull/23635","diff_url":"https://github.com/electron/electron/pull/23635.diff","patch_url":"https://github.com/electron/electron/pull/23635.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/23635","number":23635,"state":"open","locked":false,"title":"fix: nativeImage remote serialization","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #23543\n\nSee that PR for details.\n\n\r\nNotes: Fixed an issue where `nativeImage`s might throw conversion errors in the renderer process.\r\n","created_at":"2020-05-18T16:29:50Z","updated_at":"2020-05-19T00:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e45fdd07a5b54443182641f836cee03ce8faf1c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true}],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/23635/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/23635/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/23635/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/d054631d21e77838d91a34b275c21e52e1f72108","head":{"label":"electron:trop/9-x-y-bp-fix-nativeimage-remote-serialization-1589819384759","ref":"trop/9-x-y-bp-fix-nativeimage-remote-serialization-1589819384759","sha":"d054631d21e77838d91a34b275c21e52e1f72108","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"29af2312ca179201733b709288c1d7a0f1367580","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/23635"},"html":{"href":"https://github.com/electron/electron/pull/23635"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/23635"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/23635/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/23635/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/23635/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/d054631d21e77838d91a34b275c21e52e1f72108"}},"author_association":"CONTRIBUTOR"},{"url":"https://api.github.com/repos/electron/electron/pulls/23773","id":423260522,"node_id":"MDExOlB1bGxSZXF1ZXN0NDIzMjYwNTIy","html_url":"https://github.com/electron/electron/pull/23773","diff_url":"https://github.com/electron/electron/pull/23773.diff","patch_url":"https://github.com/electron/electron/pull/23773.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/23773","number":23773,"state":"open","locked":false,"title":"fix: trigger activate event when app is activated via app switcher","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #23727\n\nSee that PR for details.\n\n\r\nNotes: none\r\n","created_at":"2020-05-26T14:59:15Z","updated_at":"2020-05-26T15:04:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1bc78f9ef1cd4f367ca9e1ff712767063eb6f96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/23773/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/23773/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/23773/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/dce3357f4d056f52a9f03fc2ce4742d10853679d","head":{"label":"electron:trop/9-x-y-bp-fix-trigger-activate-event-when-app-is-activated-via-app-switcher-1590505146122","ref":"trop/9-x-y-bp-fix-trigger-activate-event-when-app-is-activated-via-app-switcher-1590505146122","sha":"dce3357f4d056f52a9f03fc2ce4742d10853679d","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"448a645128b7548fdfcd47eb50e846f096c21d7e","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/23773"},"html":{"href":"https://github.com/electron/electron/pull/23773"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/23773"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/23773/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/23773/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/23773/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/dce3357f4d056f52a9f03fc2ce4742d10853679d"}},"author_association":"CONTRIBUTOR"},{"url":"https://api.github.com/repos/electron/electron/pulls/22828","id":393345723,"node_id":"MDExOlB1bGxSZXF1ZXN0MzkzMzQ1NzIz","html_url":"https://github.com/electron/electron/pull/22828","diff_url":"https://github.com/electron/electron/pull/22828.diff","patch_url":"https://github.com/electron/electron/pull/22828.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/22828","number":22828,"state":"closed","locked":false,"title":"fix: don't allow window to go behind menu bar on mac","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #22770\n\nSee that PR for details.\n\n\r\nNotes: don't allow window to go behind menu bar on mac\r\n","created_at":"2020-03-25T02:14:01Z","updated_at":"2020-03-25T15:45:37Z","closed_at":"2020-03-25T15:45:33Z","merged_at":"2020-03-25T15:45:33Z","merge_commit_sha":"0600420bac25439fc2067d51c6aaa4ee11770577","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/22828/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/22828/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/22828/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/5d7b551db68d672816e47da4bf31d7c3cc29b241","head":{"label":"electron:trop/9-x-y-bp-fix-don-t-allow-window-to-go-behind-menu-bar-on-mac-1585102436930","ref":"trop/9-x-y-bp-fix-don-t-allow-window-to-go-behind-menu-bar-on-mac-1585102436930","sha":"5d7b551db68d672816e47da4bf31d7c3cc29b241","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"a6ff42c190cb5caf8f3e217748e49183a951491b","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/22828"},"html":{"href":"https://github.com/electron/electron/pull/22828"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/22828"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/22828/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/22828/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/22828/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/5d7b551db68d672816e47da4bf31d7c3cc29b241"}},"author_association":"CONTRIBUTOR"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-2955c67c4ea712fa22773ac9113709fc952bfd49

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/2955c67c4ea712fa22773ac9113709fc952bfd49/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:25:38 GMT","etag":"W/\"7be19eed3b62d434bcbc8ed63e9c6fe9\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"CC2A:2EDB:AF2650:12289C2:5ECD4301","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4975","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/21946","id":368254138,"node_id":"MDExOlB1bGxSZXF1ZXN0MzY4MjU0MTM4","html_url":"https://github.com/electron/electron/pull/21946","diff_url":"https://github.com/electron/electron/pull/21946.diff","patch_url":"https://github.com/electron/electron/pull/21946.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/21946","number":21946,"state":"closed","locked":false,"title":"fix: prevent print crash on bad deviceName","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"body":"#### Description of Change\r\n\r\nOn [Windows](https://source.chromium.org/chromium/chromium/src/+/master:printing/printing_context_win.cc;l=157?originalUrl=https:%2F%2Fcs.chromium.org%2F) and [macOS](https://source.chromium.org/chromium/chromium/src/+/master:printing/printing_context_mac.mm;l=226?originalUrl=https:%2F%2Fcs.chromium.org%2F), Chromium's printing code will crash if a `deviceName` is provided, but is invalid on the network, i.e does not correspond to a printer that the caller machine is aware of. This bug has been present for a long time, but after playing around a bit I've determined that it's possible to catch faulty `deviceName`s by pulling out some of the printer validation code from Chromium. This PR adds that check for Windows and macOS as well as tests for the same.\r\n\r\nTested with:\r\n```js\r\nwin.webContents.on('did-finish-load', () => {\r\n win.webContents.print({deviceName: 'bad-printer-name'}, (success, reason) => {\r\n console.log(`printing ${success ? 'did' : 'did not'} succeed: ${reason}`)\r\n })\r\n})\r\n```\r\n\r\ncc @ckerr @zcbenz \r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [x] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Fixed a potential crash on faulty `deviceName`s in `webContents.print()`.\r\n","created_at":"2020-01-28T22:02:08Z","updated_at":"2020-05-18T18:15:29Z","closed_at":"2020-01-31T02:49:14Z","merged_at":"2020-01-31T02:49:14Z","merge_commit_sha":"2955c67c4ea712fa22773ac9113709fc952bfd49","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ckerr","id":70381,"node_id":"MDQ6VXNlcjcwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/70381?v=4","gravatar_id":"","url":"https://api.github.com/users/ckerr","html_url":"https://github.com/ckerr","followers_url":"https://api.github.com/users/ckerr/followers","following_url":"https://api.github.com/users/ckerr/following{/other_user}","gists_url":"https://api.github.com/users/ckerr/gists{/gist_id}","starred_url":"https://api.github.com/users/ckerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckerr/subscriptions","organizations_url":"https://api.github.com/users/ckerr/orgs","repos_url":"https://api.github.com/users/ckerr/repos","events_url":"https://api.github.com/users/ckerr/events{/privacy}","received_events_url":"https://api.github.com/users/ckerr/received_events","type":"User","site_admin":true}],"requested_teams":[],"labels":[{"id":1657635084,"node_id":"MDU6TGFiZWwxNjU3NjM1MDg0","url":"https://api.github.com/repos/electron/electron/labels/merged/7-1-x","name":"merged/7-1-x","color":"61a3c6","default":false,"description":"PR was merged to the \"7-1-x\" branch."},{"id":1634462328,"node_id":"MDU6TGFiZWwxNjM0NDYyMzI4","url":"https://api.github.com/repos/electron/electron/labels/merged/8-x-y","name":"merged/8-x-y","color":"61a3c6","default":false,"description":"PR was merged to the \"8-x-y\" branch."}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/21946/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/21946/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/21946/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/858dbc690b159ecf767e6ae55e476f73ead931f6","head":{"label":"electron:sanity-check-devicename","ref":"sanity-check-devicename","sha":"858dbc690b159ecf767e6ae55e476f73ead931f6","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:02:47Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"0979bfc9c1a3ad2d9a8d32eb63db6940d278ff02","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:02:47Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/21946"},"html":{"href":"https://github.com/electron/electron/pull/21946"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/21946"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/21946/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/21946/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/21946/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/858dbc690b159ecf767e6ae55e476f73ead931f6"}},"author_association":"MEMBER"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-2fad53e66b1a2cb6f7dad88fe9bb62d7a461fe98

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/2fad53e66b1a2cb6f7dad88fe9bb62d7a461fe98/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:31:06 GMT","etag":"W/\"a02a824c8e984accc4fa3c78f76c0ab3\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"C1E2:5089:126DC:28ABA:5ECD4449","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4971","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/20214","id":316715466,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NzE1NDY2","html_url":"https://github.com/electron/electron/pull/20214","diff_url":"https://github.com/electron/electron/pull/20214.diff","patch_url":"https://github.com/electron/electron/pull/20214.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","number":20214,"state":"closed","locked":false,"title":"refactor: use v8 serialization for ipc","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\n\r\nBREAKING CHANGE\r\n\r\nThis changes IPC communication to use v8's [Structured Clone](https://html.spec.whatwg.org/multipage/structured-data.html#safe-passing-of-structured-data) algorithm instead of using the `base::Value` serialization defined in `native_mate_converters/v8_value_converter.cc`. This is be faster, more featureful, and less surprising than the existing logic, since it more-or-less matches the logic that backs `postMessage`.\r\n\r\nThis brings about a 2x performance boost for large buffers and complex objects. Latency for small messages is not significantly affected.\r\n\r\nUser-observable differences from the existing IPC API:\r\n- It's about 2x faster.\r\n- `NaN`, `Infinity`, and `undefined` are transferred as such, rather than being converted to `null`.\r\n- Cyclic objects can be transmitted.\r\n- `Set` and `Map`, `Error`, `RegExp`, `Date` and `BigInt` can be transmitted.\r\n- `Buffer` will be converted to `Uint8Array`.\r\n- Typed arrays (`Float32Array` and friends) will be transmitted as they are, instead of being converted to `Buffer`.\r\n- Sparse arrays will be transferred as sparse arrays, instead of being converted to dense arrays with `null`s.\r\n\r\n> **NOTE**: Objects that aren't serializable with V8's Structured Clone algorithm, such as functions, DOM objects, special Node/Electron objects like `process.env` or `WebContents`, or any objects containing such items will be serialized with the old `base::Value`-based algorithm. However, this behavior is deprecated and will throw an exception beginning with Electron 9.\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [x] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: IPC between main and renderer processes now uses the Structured Clone Algorithm.","created_at":"2019-09-12T03:41:25Z","updated_at":"2020-04-13T15:54:22Z","closed_at":"2019-10-09T17:59:09Z","merged_at":"2019-10-09T17:59:09Z","merge_commit_sha":"2fad53e66b1a2cb6f7dad88fe9bb62d7a461fe98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/20214/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/20214/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/20214/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/55076a368ea11a3408e390067b7cfe420707eb7d","head":{"label":"electron:cloneable-message-ipc","ref":"cloneable-message-ipc","sha":"55076a368ea11a3408e390067b7cfe420707eb7d","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"fe956f87ec6628f93bda11785e7860b97c61b085","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/20214"},"html":{"href":"https://github.com/electron/electron/pull/20214"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/20214"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/20214/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/20214/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/20214/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/55076a368ea11a3408e390067b7cfe420707eb7d"}},"author_association":"MEMBER"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-467409458e716c68b35fa935d556050ca6bed1c4

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/467409458e716c68b35fa935d556050ca6bed1c4/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 15:50:00 GMT","etag":"W/\"4541690410aaff6d5131f40248d2aa1c\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"BF14:68F2:966D8C:1003C0D:5ECD3AA7","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4991","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/20620","id":329363864,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MzYzODY0","html_url":"https://github.com/electron/electron/pull/20620","diff_url":"https://github.com/electron/electron/pull/20620.diff","patch_url":"https://github.com/electron/electron/pull/20620.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/20620","number":20620,"state":"closed","locked":false,"title":"build: add support for automated minor releases","user":{"login":"jkleinsc","id":609052,"node_id":"MDQ6VXNlcjYwOTA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/609052?v=4","gravatar_id":"","url":"https://api.github.com/users/jkleinsc","html_url":"https://github.com/jkleinsc","followers_url":"https://api.github.com/users/jkleinsc/followers","following_url":"https://api.github.com/users/jkleinsc/following{/other_user}","gists_url":"https://api.github.com/users/jkleinsc/gists{/gist_id}","starred_url":"https://api.github.com/users/jkleinsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkleinsc/subscriptions","organizations_url":"https://api.github.com/users/jkleinsc/orgs","repos_url":"https://api.github.com/users/jkleinsc/repos","events_url":"https://api.github.com/users/jkleinsc/events{/privacy}","received_events_url":"https://api.github.com/users/jkleinsc/received_events","type":"User","site_admin":true},"body":"#### Description of Change\r\n<!--\r\nThank you for your Pull Request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nContributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md\r\n-->\r\nStarting with the 8-x series we are going to switch to having an 8-x-y branch from which we can publish 8-0-x releases as well as (if necessary) 8-x-y releases. This means that if we want to release a minor version we will no longer have to create a new branch for that minor. \r\n\r\nThis PR changes our release scripts to allow for minor bumps. There will need to be corresponding changes made to sudowoodo and trop to support this change.\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: <!-- Please add a one-line description for app developers to read in the release notes, or `no-notes` if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/master/README.md#examples -->no-notes\r\n","created_at":"2019-10-17T16:54:58Z","updated_at":"2019-10-23T18:07:14Z","closed_at":"2019-10-23T18:07:10Z","merged_at":"2019-10-23T18:07:10Z","merge_commit_sha":"467409458e716c68b35fa935d556050ca6bed1c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/20620/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/20620/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/20620/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/3e83f35e702d90667842c15781f84dcb786673a8","head":{"label":"electron:support-n-x-y-branches","ref":"support-n-x-y-branches","sha":"3e83f35e702d90667842c15781f84dcb786673a8","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:39:23Z","pushed_at":"2020-05-26T15:46:58Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82995,"watchers_count":82995,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1223,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1223,"watchers":82995,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"86258c6cff88c60d730c0d1f050bb68c12c41d99","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:39:23Z","pushed_at":"2020-05-26T15:46:58Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82995,"watchers_count":82995,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1223,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1223,"watchers":82995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/20620"},"html":{"href":"https://github.com/electron/electron/pull/20620"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/20620"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/20620/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/20620/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/20620/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/3e83f35e702d90667842c15781f84dcb786673a8"}},"author_association":"MEMBER"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-61dc1c88fd34a3e8fff80c80ed79d0455970e610

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/61dc1c88fd34a3e8fff80c80ed79d0455970e610/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 03 Sep 2020 15:54:53 GMT","etag":"W/\"e652f44ba05ca6b1c87dfa5ecd1f2e73\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"B8DC:664C:1A39C7D:3F64817:5F5111C7","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4974","x-ratelimit-reset":"1599149937","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/25304","id":478695338,"node_id":"MDExOlB1bGxSZXF1ZXN0NDc4Njk1MzM4","html_url":"https://github.com/electron/electron/pull/25304","diff_url":"https://github.com/electron/electron/pull/25304.diff","patch_url":"https://github.com/electron/electron/pull/25304.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/25304","number":25304,"state":"open","locked":false,"title":"chore: sync 10-x-y release notes script to master","user":{"login":"ckerr","id":70381,"node_id":"MDQ6VXNlcjcwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/70381?v=4","gravatar_id":"","url":"https://api.github.com/users/ckerr","html_url":"https://github.com/ckerr","followers_url":"https://api.github.com/users/ckerr/followers","following_url":"https://api.github.com/users/ckerr/following{/other_user}","gists_url":"https://api.github.com/users/ckerr/gists{/gist_id}","starred_url":"https://api.github.com/users/ckerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckerr/subscriptions","organizations_url":"https://api.github.com/users/ckerr/orgs","repos_url":"https://api.github.com/users/ckerr/repos","events_url":"https://api.github.com/users/ckerr/events{/privacy}","received_events_url":"https://api.github.com/users/ckerr/received_events","type":"User","site_admin":true},"body":"#### Description of Change\r\n\r\nSync 10-x-y release note generation to be up-to-date with master.\r\n\r\nManually backport #24672\r\nManually backport #25279\r\nManually backport #24923 \r\n\r\n* adds the '(Also in N-x-y)' annotations (#24672)\r\n* handle sublists in release notes (#25279)\r\n* has prepare-release.js catch thrown exceptions (#24923)\r\n* syncs related tests\r\n\r\nCC @codebytere @MarshallOfSound \r\n\r\n#### Checklist\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [ ] `npm test` passes\r\n- [x] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: none","created_at":"2020-09-03T15:01:20Z","updated_at":"2020-09-03T15:06:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b80d8e5f99db07a4685639c67722ebe1f11293f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"wg-releases","id":3098261,"node_id":"MDQ6VGVhbTMwOTgyNjE=","slug":"wg-releases","description":"Releases Working Group","privacy":"closed","url":"https://api.github.com/organizations/13409222/team/3098261","html_url":"https://github.com/orgs/electron/teams/wg-releases","members_url":"https://api.github.com/organizations/13409222/team/3098261/members{/member}","repositories_url":"https://api.github.com/organizations/13409222/team/3098261/repos","permission":"pull","parent":{"name":"gov","id":3132543,"node_id":"MDQ6VGVhbTMxMzI1NDM=","slug":"gov","description":"Electron Governance","privacy":"closed","url":"https://api.github.com/organizations/13409222/team/3132543","html_url":"https://github.com/orgs/electron/teams/gov","members_url":"https://api.github.com/organizations/13409222/team/3132543/members{/member}","repositories_url":"https://api.github.com/organizations/13409222/team/3132543/repos","permission":"pull"}}],"labels":[{"id":1858180153,"node_id":"MDU6TGFiZWwxODU4MTgwMTUz","url":"https://api.github.com/repos/electron/electron/labels/10-x-y","name":"10-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/25304/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/25304/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/25304/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/87e3181270517d8883a89b8f4e67bf33fa768626","head":{"label":"electron:ckerr/10-x-y/multiline-release-notes","ref":"ckerr/10-x-y/multiline-release-notes","sha":"87e3181270517d8883a89b8f4e67bf33fa768626","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"base":{"label":"electron:10-x-y","ref":"10-x-y","sha":"5067b012d406969590c9659438b09483cace1d54","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/25304"},"html":{"href":"https://github.com/electron/electron/pull/25304"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/25304"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/25304/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/25304/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/25304/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/87e3181270517d8883a89b8f4e67bf33fa768626"}},"author_association":"MEMBER","active_lock_reason":null},{"url":"https://api.github.com/repos/electron/electron/pulls/25299","id":478572927,"node_id":"MDExOlB1bGxSZXF1ZXN0NDc4NTcyOTI3","html_url":"https://github.com/electron/electron/pull/25299","diff_url":"https://github.com/electron/electron/pull/25299.diff","patch_url":"https://github.com/electron/electron/pull/25299.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/25299","number":25299,"state":"open","locked":false,"title":"fix: multiple dock icons when calling dock.show/hide","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #25269\n\nSee that PR for details.\n\n\r\nNotes: Fix multiple dock icons being left in system when calling `dock.show`/`hide` on macOS.","created_at":"2020-09-03T11:46:51Z","updated_at":"2020-09-03T11:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5ad2c5890f6f0b7d540dad5750c89969d921bb1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true}],"requested_teams":[],"labels":[{"id":1858180153,"node_id":"MDU6TGFiZWwxODU4MTgwMTUz","url":"https://api.github.com/repos/electron/electron/labels/10-x-y","name":"10-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/25299/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/25299/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/25299/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/d7217daf9f1465521e46750c7890ebe27b8e611d","head":{"label":"electron:trop/10-x-y-bp-fix-multiple-dock-icons-when-calling-dock-show-hide-1599133604608","ref":"trop/10-x-y-bp-fix-multiple-dock-icons-when-calling-dock-show-hide-1599133604608","sha":"d7217daf9f1465521e46750c7890ebe27b8e611d","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"base":{"label":"electron:10-x-y","ref":"10-x-y","sha":"5067b012d406969590c9659438b09483cace1d54","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/25299"},"html":{"href":"https://github.com/electron/electron/pull/25299"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/25299"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/25299/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/25299/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/25299/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/d7217daf9f1465521e46750c7890ebe27b8e611d"}},"author_association":"CONTRIBUTOR","active_lock_reason":null},{"url":"https://api.github.com/repos/electron/electron/pulls/25280","id":478006648,"node_id":"MDExOlB1bGxSZXF1ZXN0NDc4MDA2NjQ4","html_url":"https://github.com/electron/electron/pull/25280","diff_url":"https://github.com/electron/electron/pull/25280.diff","patch_url":"https://github.com/electron/electron/pull/25280.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/25280","number":25280,"state":"open","locked":false,"title":"fix: provide asynchronous cleanup hooks in n-api","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #25135\n\nSee that PR for details.\n\n\r\nNotes: none\r\n","created_at":"2020-09-02T17:22:23Z","updated_at":"2020-09-02T17:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9abfc4b7d8015d53fabc7b24aa8cd703589eb40f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true}],"requested_teams":[{"name":"wg-upgrades","id":3118509,"node_id":"MDQ6VGVhbTMxMTg1MDk=","slug":"wg-upgrades","description":"Upgrades Working Group","privacy":"closed","url":"https://api.github.com/organizations/13409222/team/3118509","html_url":"https://github.com/orgs/electron/teams/wg-upgrades","members_url":"https://api.github.com/organizations/13409222/team/3118509/members{/member}","repositories_url":"https://api.github.com/organizations/13409222/team/3118509/repos","permission":"pull","parent":{"name":"gov","id":3132543,"node_id":"MDQ6VGVhbTMxMzI1NDM=","slug":"gov","description":"Electron Governance","privacy":"closed","url":"https://api.github.com/organizations/13409222/team/3132543","html_url":"https://github.com/orgs/electron/teams/gov","members_url":"https://api.github.com/organizations/13409222/team/3132543/members{/member}","repositories_url":"https://api.github.com/organizations/13409222/team/3132543/repos","permission":"pull"}}],"labels":[{"id":1858180153,"node_id":"MDU6TGFiZWwxODU4MTgwMTUz","url":"https://api.github.com/repos/electron/electron/labels/10-x-y","name":"10-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/25280/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/25280/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/25280/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/3ec728e23051692285f2d530a563d313c348d93e","head":{"label":"electron:trop/10-x-y-bp-fix-provide-asynchronous-cleanup-hooks-in-n-api-1599067338450","ref":"trop/10-x-y-bp-fix-provide-asynchronous-cleanup-hooks-in-n-api-1599067338450","sha":"3ec728e23051692285f2d530a563d313c348d93e","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"base":{"label":"electron:10-x-y","ref":"10-x-y","sha":"5067b012d406969590c9659438b09483cace1d54","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/25280"},"html":{"href":"https://github.com/electron/electron/pull/25280"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/25280"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/25280/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/25280/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/25280/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/3ec728e23051692285f2d530a563d313c348d93e"}},"author_association":"CONTRIBUTOR","active_lock_reason":null},{"url":"https://api.github.com/repos/electron/electron/pulls/25216","id":476409290,"node_id":"MDExOlB1bGxSZXF1ZXN0NDc2NDA5Mjkw","html_url":"https://github.com/electron/electron/pull/25216","diff_url":"https://github.com/electron/electron/pull/25216.diff","patch_url":"https://github.com/electron/electron/pull/25216.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/25216","number":25216,"state":"closed","locked":false,"title":"fix: client area inset calculation when maximized for framless windows","user":{"login":"deepak1556","id":964386,"node_id":"MDQ6VXNlcjk2NDM4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/964386?v=4","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\n\r\nBackports https://github.com/electron/electron/pull/25052\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [ ] `npm test` passes\r\n- [ ] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [ ] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n- [x] This is **NOT A BREAKING CHANGE**. Breaking changes may not be merged to master until 11-x-y is branched.\r\n\r\n#### Release Notes\r\n\r\nNotes:\r\n* Fixes the following issues for frameless when maximized on Windows:\r\n* fix unreachable task bar when auto hidden with position top\r\n* fix 1px extending to secondary monitor\r\n* fix 1px overflowing into taskbar at certain resolutions\r\n* fix white line on top of window under 4k resolutions","created_at":"2020-08-31T16:42:51Z","updated_at":"2020-08-31T20:23:06Z","closed_at":"2020-08-31T20:22:47Z","merged_at":"2020-08-31T20:22:47Z","merge_commit_sha":"61dc1c88fd34a3e8fff80c80ed79d0455970e610","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1858180153,"node_id":"MDU6TGFiZWwxODU4MTgwMTUz","url":"https://api.github.com/repos/electron/electron/labels/10-x-y","name":"10-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/25216/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/25216/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/25216/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/b9a5849e07e0fca6c3ceb66dddac69106d21310a","head":{"label":"electron:robo/bp_25052_10","ref":"robo/bp_25052_10","sha":"b9a5849e07e0fca6c3ceb66dddac69106d21310a","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"base":{"label":"electron:10-x-y","ref":"10-x-y","sha":"615dce32759a5d34797f2445f06622aba1fb6b21","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/25216"},"html":{"href":"https://github.com/electron/electron/pull/25216"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/25216"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/25216/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/25216/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/25216/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/b9a5849e07e0fca6c3ceb66dddac69106d21310a"}},"author_association":"MEMBER","active_lock_reason":null}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-89eb309d0b22bd4aec058ffaf983e81e56a5c378

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/89eb309d0b22bd4aec058ffaf983e81e56a5c378/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 04:04:06 GMT","etag":"W/\"442672ace5270531a2ffdc83b3b51f20\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"8118:3989:536BFA:8CED70:5ECC9535","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4999","x-ratelimit-reset":"1590469446","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/21891","id":367058148,"node_id":"MDExOlB1bGxSZXF1ZXN0MzY3MDU4MTQ4","html_url":"https://github.com/electron/electron/pull/21891","diff_url":"https://github.com/electron/electron/pull/21891.diff","patch_url":"https://github.com/electron/electron/pull/21891.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/21891","number":21891,"state":"closed","locked":false,"title":"feat: allow GUID parameter to avoid systray demotion on Windows ","user":{"login":"bitdisaster","id":5191943,"node_id":"MDQ6VXNlcjUxOTE5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5191943?v=4","gravatar_id":"","url":"https://api.github.com/users/bitdisaster","html_url":"https://github.com/bitdisaster","followers_url":"https://api.github.com/users/bitdisaster/followers","following_url":"https://api.github.com/users/bitdisaster/following{/other_user}","gists_url":"https://api.github.com/users/bitdisaster/gists{/gist_id}","starred_url":"https://api.github.com/users/bitdisaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitdisaster/subscriptions","organizations_url":"https://api.github.com/users/bitdisaster/orgs","repos_url":"https://api.github.com/users/bitdisaster/repos","events_url":"https://api.github.com/users/bitdisaster/events{/privacy}","received_events_url":"https://api.github.com/users/bitdisaster/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\nEnhances the Tray API on Windows to avoid demotion of the icon position in the system tray. With normal usage of the Windows API https://docs.microsoft.com/en-us/windows/win32/api/shellapi/ns-shellapi-notifyicondataa a user customized position of the icon is linked to the absolute file path of the executable. If the path changes, mostly by updater frameworks such Squirrel.Windows, the position is lost, and the icon will be placed back in the overflow area.\r\nHowever, the combination of a code signed binary and GUID parameter can make the positioning of the icon persistent even if the path to the executable changes.\r\nThe use of the GUID parameter also fixes a behavior where the position of a second or third icon will be lost on each restart of the App. Even if the path has not changed. \r\n\r\nI’m aware of a previous attempt https://github.com/electron/electron/pull/2328 to introduce the GUID parameter. The reason why it failed and had to be rolled back is bases on Microsofts somewhat incomplete/confusing documentation. A couple of gotchas:\r\n\r\n- The GUID is not a replacement/alternative for the uID. The uID parameter is still needed to identify the icon via Hwnd messages. \r\n- The GUID parameter is no global Id for the app that seeks to create icons in the system tray. Each icon needs its own GUID if multiple icons are created.\r\n- The GUID is best used in combination with a code signed binary. Once it is used with code signature, the GUID is permanently bound to it.\r\n- The code signature has to contain CN, OU, O in the subject line. \r\n- The GUID parameter can be used with none code signed binary. However, now the GUID is permanently bound to the path of the binary. If the path changes and the same GUID is used the creation the Tray icon will fail. Since the GUID was statically derived from the AppUserModelId, PR 2328 had to be reverted because it broke all Apps without code signature when they updated and changed there executable path.\r\n\r\nBased on above behaviors of the Windows API its best to make this an opt-in. The developer has to be aware of the behavior/requirements using the GUID parameter. It also allows the mitigation of unexpected problems with the Tray creation by providing a new GUID.\r\n\r\n<!--\r\nThank you for your Pull Request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nContributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] PR description included and stakeholders cc'd\r\n- [X] `npm test` passes\r\n- [X] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [X] relevant documentation is changed or added\r\n- [X] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Added GUID parameter to Tray API to avoid system tray icon demotion on Windows <!-- Please add a one-line description for app developers to read in the release notes, or `no-notes` if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/master/README.md#examples -->\r\n","created_at":"2020-01-24T23:45:33Z","updated_at":"2020-01-31T05:37:07Z","closed_at":"2020-01-31T05:37:04Z","merged_at":"2020-01-31T05:37:04Z","merge_commit_sha":"89eb309d0b22bd4aec058ffaf983e81e56a5c378","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/21891/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/21891/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/21891/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/e72c7ec1aa0d52e4fe5a6d77f1fa558c0dde6e4d","head":{"label":"bitdisaster:fix-systray-demotion-on-windows","ref":"fix-systray-demotion-on-windows","sha":"e72c7ec1aa0d52e4fe5a6d77f1fa558c0dde6e4d","user":{"login":"bitdisaster","id":5191943,"node_id":"MDQ6VXNlcjUxOTE5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5191943?v=4","gravatar_id":"","url":"https://api.github.com/users/bitdisaster","html_url":"https://github.com/bitdisaster","followers_url":"https://api.github.com/users/bitdisaster/followers","following_url":"https://api.github.com/users/bitdisaster/following{/other_user}","gists_url":"https://api.github.com/users/bitdisaster/gists{/gist_id}","starred_url":"https://api.github.com/users/bitdisaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitdisaster/subscriptions","organizations_url":"https://api.github.com/users/bitdisaster/orgs","repos_url":"https://api.github.com/users/bitdisaster/repos","events_url":"https://api.github.com/users/bitdisaster/events{/privacy}","received_events_url":"https://api.github.com/users/bitdisaster/received_events","type":"User","site_admin":false},"repo":{"id":216672113,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY2NzIxMTM=","name":"electron","full_name":"bitdisaster/electron","private":false,"owner":{"login":"bitdisaster","id":5191943,"node_id":"MDQ6VXNlcjUxOTE5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5191943?v=4","gravatar_id":"","url":"https://api.github.com/users/bitdisaster","html_url":"https://github.com/bitdisaster","followers_url":"https://api.github.com/users/bitdisaster/followers","following_url":"https://api.github.com/users/bitdisaster/following{/other_user}","gists_url":"https://api.github.com/users/bitdisaster/gists{/gist_id}","starred_url":"https://api.github.com/users/bitdisaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitdisaster/subscriptions","organizations_url":"https://api.github.com/users/bitdisaster/orgs","repos_url":"https://api.github.com/users/bitdisaster/repos","events_url":"https://api.github.com/users/bitdisaster/events{/privacy}","received_events_url":"https://api.github.com/users/bitdisaster/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bitdisaster/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":true,"url":"https://api.github.com/repos/bitdisaster/electron","forks_url":"https://api.github.com/repos/bitdisaster/electron/forks","keys_url":"https://api.github.com/repos/bitdisaster/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitdisaster/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitdisaster/electron/teams","hooks_url":"https://api.github.com/repos/bitdisaster/electron/hooks","issue_events_url":"https://api.github.com/repos/bitdisaster/electron/issues/events{/number}","events_url":"https://api.github.com/repos/bitdisaster/electron/events","assignees_url":"https://api.github.com/repos/bitdisaster/electron/assignees{/user}","branches_url":"https://api.github.com/repos/bitdisaster/electron/branches{/branch}","tags_url":"https://api.github.com/repos/bitdisaster/electron/tags","blobs_url":"https://api.github.com/repos/bitdisaster/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitdisaster/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitdisaster/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitdisaster/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitdisaster/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/bitdisaster/electron/languages","stargazers_url":"https://api.github.com/repos/bitdisaster/electron/stargazers","contributors_url":"https://api.github.com/repos/bitdisaster/electron/contributors","subscribers_url":"https://api.github.com/repos/bitdisaster/electron/subscribers","subscription_url":"https://api.github.com/repos/bitdisaster/electron/subscription","commits_url":"https://api.github.com/repos/bitdisaster/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitdisaster/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitdisaster/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitdisaster/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitdisaster/electron/contents/{+path}","compare_url":"https://api.github.com/repos/bitdisaster/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitdisaster/electron/merges","archive_url":"https://api.github.com/repos/bitdisaster/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitdisaster/electron/downloads","issues_url":"https://api.github.com/repos/bitdisaster/electron/issues{/number}","pulls_url":"https://api.github.com/repos/bitdisaster/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/bitdisaster/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/bitdisaster/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitdisaster/electron/labels{/name}","releases_url":"https://api.github.com/repos/bitdisaster/electron/releases{/id}","deployments_url":"https://api.github.com/repos/bitdisaster/electron/deployments","created_at":"2019-10-21T21:53:10Z","updated_at":"2020-01-20T18:30:37Z","pushed_at":"2020-01-28T23:56:20Z","git_url":"git://github.com/bitdisaster/electron.git","ssh_url":"git@github.com:bitdisaster/electron.git","clone_url":"https://github.com/bitdisaster/electron.git","svn_url":"https://github.com/bitdisaster/electron","homepage":"https://electronjs.org","size":68832,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"28fb2b7ed5c96fdae559ea015e99f3acb6b12023","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T03:18:11Z","pushed_at":"2020-05-26T02:52:23Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75421,"stargazers_count":82973,"watchers_count":82973,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11130,"open_issues":1224,"watchers":82973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/21891"},"html":{"href":"https://github.com/electron/electron/pull/21891"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/21891"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/21891/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/21891/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/21891/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/e72c7ec1aa0d52e4fe5a6d77f1fa558c0dde6e4d"}},"author_association":"MEMBER"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-8bc0c92137f4a77dc831ca644a86a3e48b51a11e

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/8bc0c92137f4a77dc831ca644a86a3e48b51a11e/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 04:04:13 GMT","etag":"W/\"ec4682709ef52766317ea4b47c247d68\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"811A:6500:2B2B5B:60C764:5ECC9537","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4998","x-ratelimit-reset":"1590469445","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/21591","id":355863062,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1ODYzMDYy","html_url":"https://github.com/electron/electron/pull/21591","diff_url":"https://github.com/electron/electron/pull/21591.diff","patch_url":"https://github.com/electron/electron/pull/21591.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/21591","number":21591,"state":"closed","locked":false,"title":"feat: [extensions] background pages","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\nThis adds support for lazy background pages when building with ENABLE_ELECTRON_EXTENSIONS. One step closer to a functional React DevTools!\r\n\r\nNB. no release notes because this feature is still behind the ENABLE_ELECTRON_EXTENSIONS flag, which is not enabled in Electron release builds.\r\n\r\nRef #19447\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] PR description included and stakeholders cc'd\r\n- [ ] `npm test` passes\r\n- [ ] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [ ] relevant documentation is changed or added\r\n- [ ] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [ ] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: none\r\n","created_at":"2019-12-20T19:06:41Z","updated_at":"2020-01-13T22:56:03Z","closed_at":"2020-01-13T22:55:58Z","merged_at":"2020-01-13T22:55:58Z","merge_commit_sha":"8bc0c92137f4a77dc831ca644a86a3e48b51a11e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/21591/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/21591/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/21591/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/391bf72b0bdad568d8e36300e47c8c3915ab751e","head":{"label":"electron:extensions-background-pages","ref":"extensions-background-pages","sha":"391bf72b0bdad568d8e36300e47c8c3915ab751e","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T03:18:11Z","pushed_at":"2020-05-26T02:52:23Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75421,"stargazers_count":82973,"watchers_count":82973,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11130,"open_issues":1224,"watchers":82973,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"7161b2f57c8a0da87d8e2d54f240c16f5b2afe4b","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T03:18:11Z","pushed_at":"2020-05-26T02:52:23Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75421,"stargazers_count":82973,"watchers_count":82973,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11130,"open_issues":1224,"watchers":82973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/21591"},"html":{"href":"https://github.com/electron/electron/pull/21591"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/21591"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/21591/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/21591/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/21591/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/391bf72b0bdad568d8e36300e47c8c3915ab751e"}},"author_association":"MEMBER"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-commit-a6ff42c190cb5caf8f3e217748e49183a951491b

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/a6ff42c190cb5caf8f3e217748e49183a951491b/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 17:01:40 GMT","etag":"W/\"0efacfb47a3fe381a80ea2cc1cfc1bab\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"B824:2157:A9EDEF:128DDCF:5ECD4B73","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4992","x-ratelimit-reset":"1590514322","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/pulls/23635","id":419611668,"node_id":"MDExOlB1bGxSZXF1ZXN0NDE5NjExNjY4","html_url":"https://github.com/electron/electron/pull/23635","diff_url":"https://github.com/electron/electron/pull/23635.diff","patch_url":"https://github.com/electron/electron/pull/23635.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/23635","number":23635,"state":"open","locked":false,"title":"fix: nativeImage remote serialization","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #23543\n\nSee that PR for details.\n\n\r\nNotes: Fixed an issue where `nativeImage`s might throw conversion errors in the renderer process.\r\n","created_at":"2020-05-18T16:29:50Z","updated_at":"2020-05-19T00:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e45fdd07a5b54443182641f836cee03ce8faf1c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true}],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/23635/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/23635/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/23635/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/d054631d21e77838d91a34b275c21e52e1f72108","head":{"label":"electron:trop/9-x-y-bp-fix-nativeimage-remote-serialization-1589819384759","ref":"trop/9-x-y-bp-fix-nativeimage-remote-serialization-1589819384759","sha":"d054631d21e77838d91a34b275c21e52e1f72108","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"29af2312ca179201733b709288c1d7a0f1367580","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/23635"},"html":{"href":"https://github.com/electron/electron/pull/23635"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/23635"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/23635/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/23635/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/23635/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/d054631d21e77838d91a34b275c21e52e1f72108"}},"author_association":"CONTRIBUTOR"},{"url":"https://api.github.com/repos/electron/electron/pulls/23773","id":423260522,"node_id":"MDExOlB1bGxSZXF1ZXN0NDIzMjYwNTIy","html_url":"https://github.com/electron/electron/pull/23773","diff_url":"https://github.com/electron/electron/pull/23773.diff","patch_url":"https://github.com/electron/electron/pull/23773.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/23773","number":23773,"state":"open","locked":false,"title":"fix: trigger activate event when app is activated via app switcher","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #23727\n\nSee that PR for details.\n\n\r\nNotes: none\r\n","created_at":"2020-05-26T14:59:15Z","updated_at":"2020-05-26T15:04:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1bc78f9ef1cd4f367ca9e1ff712767063eb6f96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/23773/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/23773/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/23773/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/dce3357f4d056f52a9f03fc2ce4742d10853679d","head":{"label":"electron:trop/9-x-y-bp-fix-trigger-activate-event-when-app-is-activated-via-app-switcher-1590505146122","ref":"trop/9-x-y-bp-fix-trigger-activate-event-when-app-is-activated-via-app-switcher-1590505146122","sha":"dce3357f4d056f52a9f03fc2ce4742d10853679d","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"448a645128b7548fdfcd47eb50e846f096c21d7e","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/23773"},"html":{"href":"https://github.com/electron/electron/pull/23773"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/23773"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/23773/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/23773/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/23773/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/dce3357f4d056f52a9f03fc2ce4742d10853679d"}},"author_association":"CONTRIBUTOR"},{"url":"https://api.github.com/repos/electron/electron/pulls/22750","id":390602476,"node_id":"MDExOlB1bGxSZXF1ZXN0MzkwNjAyNDc2","html_url":"https://github.com/electron/electron/pull/22750","diff_url":"https://github.com/electron/electron/pull/22750.diff","patch_url":"https://github.com/electron/electron/pull/22750.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/22750","number":22750,"state":"closed","locked":false,"title":"fix: workaround for hang when preventDefault-ing nativeWindowOpen","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #21497\n\nSee that PR for details.\n\n\r\nNotes: Added workaround for nativeWindowOpen hang.\r\n","created_at":"2020-03-18T18:38:17Z","updated_at":"2020-03-25T01:40:17Z","closed_at":"2020-03-25T01:40:13Z","merged_at":"2020-03-25T01:40:13Z","merge_commit_sha":"a6ff42c190cb5caf8f3e217748e49183a951491b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"loc","id":1815863,"node_id":"MDQ6VXNlcjE4MTU4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1815863?v=4","gravatar_id":"","url":"https://api.github.com/users/loc","html_url":"https://github.com/loc","followers_url":"https://api.github.com/users/loc/followers","following_url":"https://api.github.com/users/loc/following{/other_user}","gists_url":"https://api.github.com/users/loc/gists{/gist_id}","starred_url":"https://api.github.com/users/loc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loc/subscriptions","organizations_url":"https://api.github.com/users/loc/orgs","repos_url":"https://api.github.com/users/loc/repos","events_url":"https://api.github.com/users/loc/events{/privacy}","received_events_url":"https://api.github.com/users/loc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/22750/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/22750/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/22750/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/f24780c35de76aabbc24aa9cb4373380081210d8","head":{"label":"electron:trop/9-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556691390","ref":"trop/9-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556691390","sha":"f24780c35de76aabbc24aa9cb4373380081210d8","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"9b14ae770dd5f4bb5ec4cfdb803c40174a8a555e","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/22750"},"html":{"href":"https://github.com/electron/electron/pull/22750"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/22750"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/22750/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/22750/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/22750/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/f24780c35de76aabbc24aa9cb4373380081210d8"}},"author_association":"CONTRIBUTOR"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-20214-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/20214/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:31:14 GMT","etag":"W/\"3a1b7642c1edb42f6a13611136ff55a5\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"C1E4:508A:20B53:39898:5ECD444B","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4970","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/530855479","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-530855479","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":530855479,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDg1NTQ3OQ==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-12T14:35:55Z","updated_at":"2019-09-12T14:35:55Z","author_association":"MEMBER","body":"I did some preliminary performance testing. The numbers below are the average time taken, in milliseconds, to send a Uint8Array buffer of a given size, across 200 calls to `send()`.\r\n\r\nWith the existing mojo-based `base::Value` serialization:\r\n```\r\n200 x 2k: 0.42\r\n200 x 4k: 0.60\r\n200 x 8k: 0.93\r\n200 x 16k: 1.61\r\n200 x 32k: 2.88\r\n200 x 64k: 5.50\r\n200 x 128k: 10.74\r\n200 x 256k: 21.07\r\n200 x 512k: 42.62\r\n```\r\n\r\nWith this PR, using v8's ValueSerializer:\r\n```\r\n200 x 2k: 0.44\r\n200 x 4k: 0.55\r\n200 x 8k: 0.76\r\n200 x 16k: 1.08\r\n200 x 32k: 1.90\r\n200 x 64k: 3.44\r\n200 x 128k: 6.53\r\n200 x 256k: 12.59\r\n200 x 512k: 23.99\r\n```\r\n\r\n\r\nSo this seems to be a little less than twice as fast for this use case."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/530916907","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-530916907","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":530916907,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDkxNjkwNw==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-12T17:05:11Z","updated_at":"2019-09-12T17:05:11Z","author_association":"MEMBER","body":"Ref https://github.com/electron/electron/issues/18758"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/530917146","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-530917146","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":530917146,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDkxNzE0Ng==","user":{"login":"jkleinsc","id":609052,"node_id":"MDQ6VXNlcjYwOTA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/609052?v=4","gravatar_id":"","url":"https://api.github.com/users/jkleinsc","html_url":"https://github.com/jkleinsc","followers_url":"https://api.github.com/users/jkleinsc/followers","following_url":"https://api.github.com/users/jkleinsc/following{/other_user}","gists_url":"https://api.github.com/users/jkleinsc/gists{/gist_id}","starred_url":"https://api.github.com/users/jkleinsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkleinsc/subscriptions","organizations_url":"https://api.github.com/users/jkleinsc/orgs","repos_url":"https://api.github.com/users/jkleinsc/repos","events_url":"https://api.github.com/users/jkleinsc/events{/privacy}","received_events_url":"https://api.github.com/users/jkleinsc/received_events","type":"User","site_admin":true},"created_at":"2019-09-12T17:05:48Z","updated_at":"2019-09-12T17:05:48Z","author_association":"MEMBER","body":"Could we possibly support both the existing serialization and the sca approach at the same time? I'm wondering if we can follow a deprecation path here or if this will have to be all or nothing."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/530925525","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-530925525","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":530925525,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDkyNTUyNQ==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-12T17:27:54Z","updated_at":"2019-09-12T17:27:54Z","author_association":"MEMBER","body":"Tried this with some larger buffers:\r\n\r\nBefore:\r\n```\r\n10 x 1024k: 93.44\r\n10 x 2048k: 183.62\r\n10 x 4096k: 352.30\r\n10 x 8192k: 727.64\r\n10 x 16384k: 1443.97\r\n10 x 32768k: 2845.11\r\n10 x 65536k: 5565.72\r\n---crashed with buffers of size 128M---\r\n```\r\n\r\nafter:\r\n```\r\n10 x 1024k: 69.51\r\n10 x 2048k: 100.01\r\n10 x 4096k: 194.63\r\n10 x 8192k: 386.91\r\n10 x 16384k: 774.37\r\n10 x 32768k: 1606.11\r\n10 x 65536k: 3262.18\r\n10 x 131072k: 6703.16\r\n10 x 262144k: 13136.74\r\n```"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/530981366","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-530981366","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":530981366,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDk4MTM2Ng==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-12T19:57:09Z","updated_at":"2019-09-12T19:57:09Z","author_association":"MEMBER","body":"@jkleinsc I'd like to first try to find a way we can make this at least _more_ compatible with the existing structure, if not 1:1. If we can find a way that works for 99% of use cases, then I think we should cut over directly and accept the breakage. If we find fundamental issues that are not paper-over-able, then we should investigate ways we can expose this functionality differently (perhaps a new set of APIs like `ipcRenderer.post()`, or perhaps a deprecation cycle of some sort)."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/531005426","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-531005426","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":531005426,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMTAwNTQyNg==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-12T21:02:15Z","updated_at":"2019-09-12T21:02:15Z","author_association":"MEMBER","body":"I also tried this with complex objects. The numbers below are for NxM objects, where N is the breadth and M is the depth. For example, a 2x3 object is:\r\n```\r\n{'key-0': {'key-0': {'key-0': {'key-0': {}, 'key-1': {}}, 'key-1': {'key-0': {}, 'key-1': {}}}, 'key-1': {'key-0': {'key-0': {}, 'key-1': {}}, 'key-1': {'key-0': {}, 'key-1': {}}}}, 'key-1': {'key-0': {'key-0': {'key-0': {}, 'key-1': {}}, 'key-1': {'key-0': {}, 'key-1': {}}}, 'key-1': {'key-0': {'key-0': {}, 'key-1': {}}, 'key-1': {'key-0': {}, 'key-1': {}}}}}\r\n```\r\n\r\nA NaN represents a renderer crash.\r\n\r\nBefore:\r\n```\r\n10 x 1x1: 3.34\r\n10 x 1x2: 3.34\r\n10 x 1x4: 3.26\r\n10 x 1x8: 3.30\r\n10 x 1x16: 3.35\r\n10 x 2x1: 3.48\r\n10 x 2x2: 3.42\r\n10 x 2x4: 3.77\r\n10 x 2x8: 10.01\r\n10 x 2x16: 1736.84\r\n10 x 4x1: 3.21\r\n10 x 4x2: 3.41\r\n10 x 4x4: 7.92\r\n10 x 4x8: 1142.82\r\n10 x 4x16: NaN\r\n10 x 8x1: 3.52\r\n10 x 8x2: 4.08\r\n10 x 8x4: 64.33\r\n10 x 8x8: NaN\r\n10 x 8x16: NaN\r\n10 x 16x1: 4.52\r\n10 x 16x2: 7.23\r\n10 x 16x4: 1003.91\r\n10 x 16x8: NaN\r\n10 x 16x16: NaN\r\n```\r\nAfter:\r\n```\r\n10 x 1x1: 3.38\r\n10 x 1x2: 4.00\r\n10 x 1x4: 3.37\r\n10 x 1x8: 3.01\r\n10 x 1x16: 3.06\r\n10 x 2x1: 4.38\r\n10 x 2x2: 4.14\r\n10 x 2x4: 3.67\r\n10 x 2x8: 5.41\r\n10 x 2x16: 409.08\r\n10 x 4x1: 3.07\r\n10 x 4x2: 3.65\r\n10 x 4x4: 3.85\r\n10 x 4x8: 234.70\r\n10 x 4x16: NaN\r\n10 x 8x1: 3.51\r\n10 x 8x2: 3.29\r\n10 x 8x4: 15.58\r\n10 x 8x8: 87138.07\r\n10 x 8x16: NaN\r\n10 x 16x1: 3.93\r\n10 x 16x2: 4.05\r\n10 x 16x4: 181.39\r\n10 x 16x8: NaN\r\n10 x 16x16: NaN\r\n```\r\n\r\nSo, quite a bit faster. I think the crashes are when _constructing_ those stupidly large objects, rather than serializing them. And the new code does succeed on the 8x8 case, where the old code crashed."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/533729544","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-533729544","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":533729544,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMzcyOTU0NA==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-20T22:22:22Z","updated_at":"2019-09-25T19:58:17Z","author_association":"MEMBER","body":"Remaining TODOs as of latest commit:\r\n\r\n- [x] Handle errors gracefully & correctly.\r\n- [x] Investigate whether we can discriminate between `Buffer` and `Uint8Array` wisely, and deserialize `Buffer`s as `Buffer`s where we can, and `Uint8Array` where we can't (e.g. in sandboxed renderers).\r\n- [x] Convert the remaining methods to the new serialization algorithm (`webContents.send`, `messageTo`, and `messageHost`).\r\n- [x] Clean up the somewhat hacky delegates in blink_converter.cc"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/534217625","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-534217625","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":534217625,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDIxNzYyNQ==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-23T18:09:10Z","updated_at":"2019-09-23T18:09:10Z","author_association":"MEMBER","body":"OK, there's a choice to make about how we handle when non-POJO objects are passed to IPC functions (things like DOM objects, `WebContents`, `process.env`, etc.).\r\n\r\n1. Throw an exception.\r\n - This is the safest option, but also the most disruptive. (e.g. many of Electron's internal APIs pass such objects to IPC methods, and will need to be refactored.)\r\n2. JSON.stringify()/JSON.parse() them.\r\n - This is roughly similar to current behavior of the IPC methods, in that it can't handle NaN or Infinity, or cyclic objects. However, it might be somewhat confusing to have some objects work differently based on whether they're referenced from a non-POJO object or not. It's a fairly obscure corner case though, so maybe nobody would notice?\r\n3. Iterate the keys/values of such objects and recurse in the serialization algorithm.\r\n - This gives us cyclic object support and correct handling of Infinity/NaN/etc.\r\n - But most non-trivial non-POJO objects contain unserializable things like functions.\r\n - We can attempt to replace those unserializable things with `undefined`, but it only works one layer deep. i.e. if there's a non-POJO object like `{ fn: () => {} }`, it'll be turned into `{ fn: undefined }`, but if it's like `{ events: { fn: () => {} } }`, then the entire serialization operation must be aborted and an error thrown.\r\n\r\nI'm leaning towards (1), since I don't think it really makes sense to be trying to send `window.location` or a `WebContents` value over IPC, and places where we're doing that are likely error-prone. Thoughts?"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/534692035","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-534692035","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":534692035,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDY5MjAzNQ==","user":{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false},"created_at":"2019-09-24T18:37:09Z","updated_at":"2019-09-24T18:37:09Z","author_association":"MEMBER","body":"I don't like the idea of existing code throwing errors in an obscure and un-lintable way. i.e. we can't provide a lint rule or other tool to detect invalid usages of `ipc.send` so folks will only find out at runtime when it's too late and hard to spot.\r\n\r\nI'm leaning towards something equivalent to (2) where if the v8 serializer fails we fall back to the old one. Maybe log a console warning that you tried to send an unserializable object and we fell back to a less accurate converter?"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/534705193","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-534705193","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":534705193,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDcwNTE5Mw==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-24T19:08:48Z","updated_at":"2019-09-24T19:08:48Z","author_association":"MEMBER","body":"Does that leave any path towards eventually eliminating the old converter? I'm disinclined to leave it there forever... but maybe it would make sense as a less-dramatic deprecation strategy? e.g. \"Looks like you sent a non-standard object over IPC. This is probably not what you intended to do, but we obliged and serialized it anyway. Look out, this will throw an exception in Electron 9.\""},{"url":"https://api.github.com/repos/electron/electron/issues/comments/534740833","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-534740833","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":534740833,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDc0MDgzMw==","user":{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false},"created_at":"2019-09-24T20:46:20Z","updated_at":"2019-09-24T20:46:20Z","author_association":"MEMBER","body":"I'd be down for a **very** long term deprecation strategy here. Like we should support serialization for I'd say 4 versions beyond when this lands (number picked to match the number of versions we used for the native module deprecation).\r\n\r\nThe deprecation log should include the object itself as well if possible 🤔 "},{"url":"https://api.github.com/repos/electron/electron/issues/comments/534770157","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-534770157","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":534770157,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDc3MDE1Nw==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-24T22:15:23Z","updated_at":"2019-09-24T22:18:48Z","author_association":"MEMBER","body":"@MarshallOfSound I'm not sure that's warranted. 99% of cases where IPC is used, the new version should still work fine. Only in weird cases where it only kind of semi-works currently are problematic.\r\n\r\nFor example. The `new-window` event has as one of its arguments the `options` parameter, which is the options passed to `new BrowserWindow()`. One of these options is `webContents`, which specifies which WebContents will go in the new window. For WebViews, the `new-window` event is proxied over to the host frame. However, during that transmission, the `webContents` key stops being an actual `WebContents`. Is anything depending on that key being there in the webview host? I don't think so. Can anything actually useful be done with it there? Again, I don't think so. The fact that it's there is an accident, and it never really performed any kind of useful function.\r\n\r\nAlso, it's trivial to get something close to the old behavior with the transformation `x => JSON.parse(JSON.stringify(x))`, as long as `x` isn't cyclic (but if it was, the cyclic bit is getting `null`ed out currently anyway).\r\n\r\n**tldr** most people wouldn't need to fix anything if this sort of usage started throwing an error, and for those that do, the fix is easy."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/534778673","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-534778673","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":534778673,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDc3ODY3Mw==","user":{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false},"created_at":"2019-09-24T22:52:11Z","updated_at":"2019-09-24T22:52:11Z","author_association":"MEMBER","body":"> if this sort of usage started throwing an error\r\n\r\nMy only concern here was that you can't glance at a bit of code and say \"that's gonna cause a problem\". In fact I don't think you could describe the kinds of things that would cause this problem very easily at all. That's the only reason I'm advocating for a deprecation cycle, it will take time for people to find all the edge cases in their app that might do this. Maybe 4 versions was a bit over-eager 🤷‍♂But it should definitely go through a cycle where the old code still works but tells you you're doing something bad."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/535169992","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-535169992","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":535169992,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNTE2OTk5Mg==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-25T19:14:29Z","updated_at":"2019-09-25T19:14:29Z","author_association":"MEMBER","body":"The things which will throw exceptions with structured clone that don't with base::Value serialization:\r\n- DOM objects (`Element`, `Location`, etc.)\r\n- special Node objects like `process.env` or http internals\r\n- special Electron API objects like WebContents\r\n- functions\r\n\r\nI've updated the PR to fall back to the base::Value-based serialization if structured clone fails, and emit a deprecation warning."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/535186584","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-535186584","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":535186584,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNTE4NjU4NA==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-25T19:57:30Z","updated_at":"2019-09-25T19:57:30Z","author_association":"MEMBER","body":"The last remaining tricky thing is that sending a `Buffer` will result in the other side receiving a `Uint8Array`. Without patching V8, I don't see a good way to get around this. Fortunately, you can wrap a `Buffer` around a `Uint8Array` quite easily:\r\n\r\n```\r\nconst uint8Array = await ipcRenderer.invoke('return-a-buffer')\r\nconst buf = Buffer.from(uint8Array.buffer)\r\n```"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/535187110","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-535187110","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":535187110,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNTE4NzExMA==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-25T19:58:39Z","updated_at":"2019-09-25T19:58:39Z","author_association":"MEMBER","body":"Taking off the [wip] as I believe this is ready for full review."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/538499039","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-538499039","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":538499039,"node_id":"MDEyOklzc3VlQ29tbWVudDUzODQ5OTAzOQ==","user":{"login":"miniak","id":1281234,"node_id":"MDQ6VXNlcjEyODEyMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1281234?v=4","gravatar_id":"","url":"https://api.github.com/users/miniak","html_url":"https://github.com/miniak","followers_url":"https://api.github.com/users/miniak/followers","following_url":"https://api.github.com/users/miniak/following{/other_user}","gists_url":"https://api.github.com/users/miniak/gists{/gist_id}","starred_url":"https://api.github.com/users/miniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miniak/subscriptions","organizations_url":"https://api.github.com/users/miniak/orgs","repos_url":"https://api.github.com/users/miniak/repos","events_url":"https://api.github.com/users/miniak/events{/privacy}","received_events_url":"https://api.github.com/users/miniak/received_events","type":"User","site_admin":false},"created_at":"2019-10-04T17:54:45Z","updated_at":"2019-10-04T17:55:03Z","author_association":"MEMBER","body":"this will allow us to simplify the serialization in the `remote` module. #20427"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/540117270","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-540117270","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":540117270,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDExNzI3MA==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-10-09T17:59:11Z","updated_at":"2019-10-09T17:59:11Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> IPC between main and renderer processes now uses the Structured Clone Algorithm."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/540619766","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-540619766","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":540619766,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDYxOTc2Ng==","user":{"login":"Xylobol","id":40412285,"node_id":"MDQ6VXNlcjQwNDEyMjg1","avatar_url":"https://avatars3.githubusercontent.com/u/40412285?v=4","gravatar_id":"","url":"https://api.github.com/users/Xylobol","html_url":"https://github.com/Xylobol","followers_url":"https://api.github.com/users/Xylobol/followers","following_url":"https://api.github.com/users/Xylobol/following{/other_user}","gists_url":"https://api.github.com/users/Xylobol/gists{/gist_id}","starred_url":"https://api.github.com/users/Xylobol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xylobol/subscriptions","organizations_url":"https://api.github.com/users/Xylobol/orgs","repos_url":"https://api.github.com/users/Xylobol/repos","events_url":"https://api.github.com/users/Xylobol/events{/privacy}","received_events_url":"https://api.github.com/users/Xylobol/received_events","type":"User","site_admin":false},"created_at":"2019-10-10T14:40:42Z","updated_at":"2019-10-10T14:40:42Z","author_association":"NONE","body":"For anyone else interested, these changes have landed in nightly - https://github.com/electron/nightlies/releases/tag/v8.0.0-nightly.20191009"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/545339910","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-545339910","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":545339910,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTMzOTkxMA==","user":{"login":"gdavidkov","id":5815794,"node_id":"MDQ6VXNlcjU4MTU3OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5815794?v=4","gravatar_id":"","url":"https://api.github.com/users/gdavidkov","html_url":"https://github.com/gdavidkov","followers_url":"https://api.github.com/users/gdavidkov/followers","following_url":"https://api.github.com/users/gdavidkov/following{/other_user}","gists_url":"https://api.github.com/users/gdavidkov/gists{/gist_id}","starred_url":"https://api.github.com/users/gdavidkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdavidkov/subscriptions","organizations_url":"https://api.github.com/users/gdavidkov/orgs","repos_url":"https://api.github.com/users/gdavidkov/repos","events_url":"https://api.github.com/users/gdavidkov/events{/privacy}","received_events_url":"https://api.github.com/users/gdavidkov/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T08:50:33Z","updated_at":"2019-10-23T08:50:33Z","author_association":"NONE","body":"Will this be backported to 6.x?"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/545494783","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-545494783","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":545494783,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ5NDc4Mw==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T15:17:41Z","updated_at":"2019-10-23T15:17:41Z","author_association":"MEMBER","body":"No, since it is a breaking change.\n"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/612301761","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-612301761","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":612301761,"node_id":"MDEyOklzc3VlQ29tbWVudDYxMjMwMTc2MQ==","user":{"login":"Slapbox","id":6835891,"node_id":"MDQ6VXNlcjY4MzU4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6835891?v=4","gravatar_id":"","url":"https://api.github.com/users/Slapbox","html_url":"https://github.com/Slapbox","followers_url":"https://api.github.com/users/Slapbox/followers","following_url":"https://api.github.com/users/Slapbox/following{/other_user}","gists_url":"https://api.github.com/users/Slapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/Slapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slapbox/subscriptions","organizations_url":"https://api.github.com/users/Slapbox/orgs","repos_url":"https://api.github.com/users/Slapbox/repos","events_url":"https://api.github.com/users/Slapbox/events{/privacy}","received_events_url":"https://api.github.com/users/Slapbox/received_events","type":"User","site_admin":false},"created_at":"2020-04-11T02:28:50Z","updated_at":"2020-04-11T02:28:50Z","author_association":"CONTRIBUTOR","body":"This PR is noted as a **_Breaking Changes_** for Electron 8.0.0 & 9.0.0 betas. Is there any difference in the IPC between versions 8 and 9?"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/612959454","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-612959454","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":612959454,"node_id":"MDEyOklzc3VlQ29tbWVudDYxMjk1OTQ1NA==","user":{"login":"pushkin-","id":6374473,"node_id":"MDQ6VXNlcjYzNzQ0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/6374473?v=4","gravatar_id":"","url":"https://api.github.com/users/pushkin-","html_url":"https://github.com/pushkin-","followers_url":"https://api.github.com/users/pushkin-/followers","following_url":"https://api.github.com/users/pushkin-/following{/other_user}","gists_url":"https://api.github.com/users/pushkin-/gists{/gist_id}","starred_url":"https://api.github.com/users/pushkin-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushkin-/subscriptions","organizations_url":"https://api.github.com/users/pushkin-/orgs","repos_url":"https://api.github.com/users/pushkin-/repos","events_url":"https://api.github.com/users/pushkin-/events{/privacy}","received_events_url":"https://api.github.com/users/pushkin-/received_events","type":"User","site_admin":false},"created_at":"2020-04-13T15:54:22Z","updated_at":"2020-04-13T15:54:22Z","author_association":"NONE","body":"@Slapbox I believe the plan in 8 is to use the new algorithm, but if it fails, emit a warning and fallback to the old algorithm.\r\n\r\nIn Electron 9, they're going remove the fallback and warning and serializing bad data will start throwing exceptions."}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-21497-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/21497/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 03 Sep 2020 15:54:46 GMT","etag":"W/\"31c54a4c2a8fe380adf297472e01eca3\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"B8DA:223D:2B3CDE:9066A9:5F5111C6","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4975","x-ratelimit-reset":"1599149937","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/565251264","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-565251264","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":565251264,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NTI1MTI2NA==","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"created_at":"2019-12-13T00:41:22Z","updated_at":"2019-12-13T00:41:22Z","author_association":"MEMBER","body":"```\r\nwebContents module getAllWebContents() API returns an array of web contents - returns an array of web contents\r\n```\r\nhas died, but will ✅ when green:)","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/565499161","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-565499161","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":565499161,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NTQ5OTE2MQ==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-12-13T16:06:15Z","updated_at":"2019-12-13T16:06:15Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> Added workaround for nativeWindowOpen hang.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600784768","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600784768","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600784768,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc4NDc2OA==","user":{"login":"loc","id":1815863,"node_id":"MDQ6VXNlcjE4MTU4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1815863?v=4","gravatar_id":"","url":"https://api.github.com/users/loc","html_url":"https://github.com/loc","followers_url":"https://api.github.com/users/loc/followers","following_url":"https://api.github.com/users/loc/following{/other_user}","gists_url":"https://api.github.com/users/loc/gists{/gist_id}","starred_url":"https://api.github.com/users/loc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loc/subscriptions","organizations_url":"https://api.github.com/users/loc/orgs","repos_url":"https://api.github.com/users/loc/repos","events_url":"https://api.github.com/users/loc/events{/privacy}","received_events_url":"https://api.github.com/users/loc/received_events","type":"User","site_admin":false},"created_at":"2020-03-18T18:12:54Z","updated_at":"2020-03-18T18:12:54Z","author_association":"MEMBER","body":"/trop run backport-to 8-x-y","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600784783","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600784783","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600784783,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc4NDc4Mw==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-18T18:12:55Z","updated_at":"2020-03-18T18:12:55Z","author_association":"CONTRIBUTOR","body":"@loc is not authorized to run PR backports.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600796101","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600796101","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600796101,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc5NjEwMQ==","user":{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false},"created_at":"2020-03-18T18:37:32Z","updated_at":"2020-03-18T18:37:32Z","author_association":"MEMBER","body":"/trop run backport-to 8-x-y\r\n\r\n","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600796116","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600796116","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600796116,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc5NjExNg==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-18T18:37:34Z","updated_at":"2020-03-18T18:37:34Z","author_association":"CONTRIBUTOR","body":"The backport process for this PR has been manually initiated -\nsending your commits to \"8-x-y\"!","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600796152","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600796152","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600796152,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc5NjE1Mg==","user":{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false},"created_at":"2020-03-18T18:37:39Z","updated_at":"2020-03-18T18:37:39Z","author_association":"MEMBER","body":"/trop run backport-to 9-x-y\r\n\r\n","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600796163","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600796163","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600796163,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc5NjE2Mw==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-18T18:37:41Z","updated_at":"2020-03-18T18:37:41Z","author_association":"CONTRIBUTOR","body":"The backport process for this PR has been manually initiated -\nsending your commits to \"9-x-y\"!","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600796434","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600796434","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600796434,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc5NjQzNA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-18T18:38:14Z","updated_at":"2020-03-18T18:38:14Z","author_association":"CONTRIBUTOR","body":"I have automatically backported this PR to \"8-x-y\", please check out #22749","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/600796529","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-600796529","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":600796529,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMDc5NjUyOQ==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-18T18:38:24Z","updated_at":"2020-03-18T18:38:24Z","author_association":"CONTRIBUTOR","body":"I have automatically backported this PR to \"9-x-y\", please check out #22750","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/603552760","html_url":"https://github.com/electron/electron/pull/21497#issuecomment-603552760","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","id":603552760,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMzU1Mjc2MA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-24T23:14:27Z","updated_at":"2020-03-24T23:14:27Z","author_association":"CONTRIBUTOR","body":"@loc has manually backported this PR to \"master\", please check out #22825","performed_via_github_app":null}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-21891-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/21891/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 04:07:22 GMT","etag":"W/\"f3361c5c493edbcc6774be228131a636\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"8F4E:231E:52E8BF:8AF8CD:5ECC95F9","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4997","x-ratelimit-reset":"1590469446","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/579570143","html_url":"https://github.com/electron/electron/pull/21891#issuecomment-579570143","issue_url":"https://api.github.com/repos/electron/electron/issues/21891","id":579570143,"node_id":"MDEyOklzc3VlQ29tbWVudDU3OTU3MDE0Mw==","user":{"login":"bitdisaster","id":5191943,"node_id":"MDQ6VXNlcjUxOTE5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5191943?v=4","gravatar_id":"","url":"https://api.github.com/users/bitdisaster","html_url":"https://github.com/bitdisaster","followers_url":"https://api.github.com/users/bitdisaster/followers","following_url":"https://api.github.com/users/bitdisaster/following{/other_user}","gists_url":"https://api.github.com/users/bitdisaster/gists{/gist_id}","starred_url":"https://api.github.com/users/bitdisaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitdisaster/subscriptions","organizations_url":"https://api.github.com/users/bitdisaster/orgs","repos_url":"https://api.github.com/users/bitdisaster/repos","events_url":"https://api.github.com/users/bitdisaster/events{/privacy}","received_events_url":"https://api.github.com/users/bitdisaster/received_events","type":"User","site_admin":false},"created_at":"2020-01-29T02:58:25Z","updated_at":"2020-01-29T02:58:25Z","author_association":"MEMBER","body":"@zcbenz I solved the mac/linux problem a bit differently. @MarshallOfSound recommended the use of converter to me and I like the approach. Does the typedef via conditional compiling work for you to?"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/580589854","html_url":"https://github.com/electron/electron/pull/21891#issuecomment-580589854","issue_url":"https://api.github.com/repos/electron/electron/issues/21891","id":580589854,"node_id":"MDEyOklzc3VlQ29tbWVudDU4MDU4OTg1NA==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-01-31T05:37:07Z","updated_at":"2020-01-31T05:37:07Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> Added GUID parameter to Tray API to avoid system tray icon demotion on Windows "}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-21946-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/21946/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:25:45 GMT","etag":"W/\"39d435c37eaa842b37a0eda92327599c\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"CC2C:4CE8:C1843:2309CE:5ECD4303","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4974","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/580558534","html_url":"https://github.com/electron/electron/pull/21946#issuecomment-580558534","issue_url":"https://api.github.com/repos/electron/electron/issues/21946","id":580558534,"node_id":"MDEyOklzc3VlQ29tbWVudDU4MDU1ODUzNA==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-01-31T02:49:17Z","updated_at":"2020-01-31T02:49:17Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> Fixed a potential crash on faulty `deviceName`s in `webContents.print()`."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/580558572","html_url":"https://github.com/electron/electron/pull/21946#issuecomment-580558572","issue_url":"https://api.github.com/repos/electron/electron/issues/21946","id":580558572,"node_id":"MDEyOklzc3VlQ29tbWVudDU4MDU1ODU3Mg==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-01-31T02:49:31Z","updated_at":"2020-01-31T02:49:31Z","author_association":"CONTRIBUTOR","body":"I was unable to backport this PR to \"7-1-x\" cleanly;\n you will need to perform this backport manually."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/580558582","html_url":"https://github.com/electron/electron/pull/21946#issuecomment-580558582","issue_url":"https://api.github.com/repos/electron/electron/issues/21946","id":580558582,"node_id":"MDEyOklzc3VlQ29tbWVudDU4MDU1ODU4Mg==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-01-31T02:49:34Z","updated_at":"2020-01-31T02:49:34Z","author_association":"CONTRIBUTOR","body":"I was unable to backport this PR to \"6-1-x\" cleanly;\n you will need to perform this backport manually."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/580558614","html_url":"https://github.com/electron/electron/pull/21946#issuecomment-580558614","issue_url":"https://api.github.com/repos/electron/electron/issues/21946","id":580558614,"node_id":"MDEyOklzc3VlQ29tbWVudDU4MDU1ODYxNA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-01-31T02:49:43Z","updated_at":"2020-01-31T02:49:43Z","author_association":"CONTRIBUTOR","body":"I have automatically backported this PR to \"8-x-y\", please check out #21982"},{"url":"https://api.github.com/repos/electron/electron/issues/comments/581509606","html_url":"https://github.com/electron/electron/pull/21946#issuecomment-581509606","issue_url":"https://api.github.com/repos/electron/electron/issues/21946","id":581509606,"node_id":"MDEyOklzc3VlQ29tbWVudDU4MTUwOTYwNg==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-02-03T16:52:05Z","updated_at":"2020-02-03T16:52:05Z","author_association":"CONTRIBUTOR","body":"@codebytere has manually backported this PR to \"7-1-x\", please check out #22012"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-22750-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/22750/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 17:01:55 GMT","etag":"W/\"89f9bf1ce7fb984e50e64f9d80c482cb\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"B828:443A:D1E7FE:149D73A:5ECD4B7D","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4990","x-ratelimit-reset":"1590514321","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/602930802","html_url":"https://github.com/electron/electron/pull/22750#issuecomment-602930802","issue_url":"https://api.github.com/repos/electron/electron/issues/22750","id":602930802,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMjkzMDgwMg==","user":{"login":"loc","id":1815863,"node_id":"MDQ6VXNlcjE4MTU4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1815863?v=4","gravatar_id":"","url":"https://api.github.com/users/loc","html_url":"https://github.com/loc","followers_url":"https://api.github.com/users/loc/followers","following_url":"https://api.github.com/users/loc/following{/other_user}","gists_url":"https://api.github.com/users/loc/gists{/gist_id}","starred_url":"https://api.github.com/users/loc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loc/subscriptions","organizations_url":"https://api.github.com/users/loc/orgs","repos_url":"https://api.github.com/users/loc/repos","events_url":"https://api.github.com/users/loc/events{/privacy}","received_events_url":"https://api.github.com/users/loc/received_events","type":"User","site_admin":false},"created_at":"2020-03-24T00:23:09Z","updated_at":"2020-03-24T00:23:09Z","author_association":"MEMBER","body":"@zcbenz okay, I believe this is good to go."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/603592578","html_url":"https://github.com/electron/electron/pull/22750#issuecomment-603592578","issue_url":"https://api.github.com/repos/electron/electron/issues/22750","id":603592578,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMzU5MjU3OA==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-25T01:40:16Z","updated_at":"2020-03-25T01:40:16Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> Added workaround for nativeWindowOpen hang."}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-22770-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/22770/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 03 Sep 2020 15:54:54 GMT","etag":"W/\"bfb3660eda8a4e7c2308b04c26ae9ce8\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"B8EC:28D5:D5B5D0:234FC38:5F5111CE","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4971","x-ratelimit-reset":"1599149937","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/602947315","html_url":"https://github.com/electron/electron/pull/22770#issuecomment-602947315","issue_url":"https://api.github.com/repos/electron/electron/issues/22770","id":602947315,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMjk0NzMxNQ==","user":{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"created_at":"2020-03-24T01:15:16Z","updated_at":"2020-03-24T01:15:16Z","author_association":"MEMBER","body":"Do you mind rebasing this PR on master? We now require semicolon in JS files.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/603185839","html_url":"https://github.com/electron/electron/pull/22770#issuecomment-603185839","issue_url":"https://api.github.com/repos/electron/electron/issues/22770","id":603185839,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMzE4NTgzOQ==","user":{"login":"CezaryKulakowski","id":50166166,"node_id":"MDQ6VXNlcjUwMTY2MTY2","avatar_url":"https://avatars2.githubusercontent.com/u/50166166?v=4","gravatar_id":"","url":"https://api.github.com/users/CezaryKulakowski","html_url":"https://github.com/CezaryKulakowski","followers_url":"https://api.github.com/users/CezaryKulakowski/followers","following_url":"https://api.github.com/users/CezaryKulakowski/following{/other_user}","gists_url":"https://api.github.com/users/CezaryKulakowski/gists{/gist_id}","starred_url":"https://api.github.com/users/CezaryKulakowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CezaryKulakowski/subscriptions","organizations_url":"https://api.github.com/users/CezaryKulakowski/orgs","repos_url":"https://api.github.com/users/CezaryKulakowski/repos","events_url":"https://api.github.com/users/CezaryKulakowski/events{/privacy}","received_events_url":"https://api.github.com/users/CezaryKulakowski/received_events","type":"User","site_admin":false},"created_at":"2020-03-24T11:30:17Z","updated_at":"2020-03-24T11:30:17Z","author_association":"CONTRIBUTOR","body":"@zcbenz I've made a rebase to the newest master. I've also squashed two commits into one.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/603601083","html_url":"https://github.com/electron/electron/pull/22770#issuecomment-603601083","issue_url":"https://api.github.com/repos/electron/electron/issues/22770","id":603601083,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMzYwMTA4Mw==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-25T02:13:47Z","updated_at":"2020-03-25T02:13:47Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> don't allow window to go behind menu bar on mac","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/603601148","html_url":"https://github.com/electron/electron/pull/22770#issuecomment-603601148","issue_url":"https://api.github.com/repos/electron/electron/issues/22770","id":603601148,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMzYwMTE0OA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-25T02:14:04Z","updated_at":"2020-03-25T02:14:04Z","author_association":"CONTRIBUTOR","body":"I have automatically backported this PR to \"9-x-y\", please check out #22828","performed_via_github_app":null}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-22828-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/22828/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:42:42 GMT","etag":"W/\"9da63627de4ed4f8b7929f66f9b6aa2b\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"C9A8:3A3F:B1FB:13DF6:5ECD46FB","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4994","x-ratelimit-reset":"1590514322","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/603916187","html_url":"https://github.com/electron/electron/pull/22828#issuecomment-603916187","issue_url":"https://api.github.com/repos/electron/electron/issues/22828","id":603916187,"node_id":"MDEyOklzc3VlQ29tbWVudDYwMzkxNjE4Nw==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-03-25T15:45:36Z","updated_at":"2020-03-25T15:45:36Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> don't allow window to go behind menu bar on mac"}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-25052-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/25052/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 03 Sep 2020 15:54:54 GMT","etag":"W/\"86c96edda270ca498d8b3c3fd7c079b0\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"B8EA:64CE:5E86CFB:A058421:5F5111CD","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4972","x-ratelimit-reset":"1599149937","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/676831184","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-676831184","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":676831184,"node_id":"MDEyOklzc3VlQ29tbWVudDY3NjgzMTE4NA==","user":{"login":"deepak1556","id":964386,"node_id":"MDQ6VXNlcjk2NDM4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/964386?v=4","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"created_at":"2020-08-20T00:41:18Z","updated_at":"2020-08-20T00:41:18Z","author_association":"MEMBER","body":"From spy++\r\n\r\n**Before**\r\n\r\nRectangle - (-8, -8)-(2568, 1408), 2576x1416 (Maximized)\r\nRestored Rect - (880, 400)-(1680, 1000), 800x600\r\nClient Rect - (7, 7)-(2569, 1409), 2562x1402\r\n\r\n**After**\r\n\r\nRectangle - (-8, -8)-(2568, 1408), 2576x1416 (Maximized)\r\nRestored Rect - (880, 400)-(1680, 1000), 800x600\r\nClient Rect - (8, 0)-(2568, 1408), 2560x1408","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/677938407","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-677938407","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":677938407,"node_id":"MDEyOklzc3VlQ29tbWVudDY3NzkzODQwNw==","user":{"login":"deepak1556","id":964386,"node_id":"MDQ6VXNlcjk2NDM4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/964386?v=4","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"created_at":"2020-08-20T22:27:46Z","updated_at":"2020-08-20T22:27:46Z","author_association":"MEMBER","body":"@zcbenz this is ready for review. Thanks!","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683626788","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683626788","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683626788,"node_id":"MDEyOklzc3VlQ29tbWVudDY4MzYyNjc4OA==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T07:55:53Z","updated_at":"2020-08-31T07:55:53Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> Fixes the following issues for frameless when maximized on Windows","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683626883","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683626883","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683626883,"node_id":"MDEyOklzc3VlQ29tbWVudDY4MzYyNjg4Mw==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T07:56:07Z","updated_at":"2020-08-31T07:56:07Z","author_association":"CONTRIBUTOR","body":"I was unable to backport this PR to \"10-x-y\" cleanly;\n you will need to perform this backport manually.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683626908","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683626908","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683626908,"node_id":"MDEyOklzc3VlQ29tbWVudDY4MzYyNjkwOA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T07:56:10Z","updated_at":"2020-08-31T07:56:10Z","author_association":"CONTRIBUTOR","body":"I was unable to backport this PR to \"11-x-y\" cleanly;\n you will need to perform this backport manually.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683626930","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683626930","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683626930,"node_id":"MDEyOklzc3VlQ29tbWVudDY4MzYyNjkzMA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T07:56:13Z","updated_at":"2020-08-31T07:56:13Z","author_association":"CONTRIBUTOR","body":"I was unable to backport this PR to \"8-x-y\" cleanly;\n you will need to perform this backport manually.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683626954","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683626954","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683626954,"node_id":"MDEyOklzc3VlQ29tbWVudDY4MzYyNjk1NA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T07:56:16Z","updated_at":"2020-08-31T07:56:16Z","author_association":"CONTRIBUTOR","body":"I was unable to backport this PR to \"9-x-y\" cleanly;\n you will need to perform this backport manually.","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683895142","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683895142","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683895142,"node_id":"MDEyOklzc3VlQ29tbWVudDY4Mzg5NTE0Mg==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T16:42:53Z","updated_at":"2020-08-31T16:42:53Z","author_association":"CONTRIBUTOR","body":"@deepak1556 has manually backported this PR to \"10-x-y\", please check out #25216","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683896065","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683896065","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683896065,"node_id":"MDEyOklzc3VlQ29tbWVudDY4Mzg5NjA2NQ==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T16:44:28Z","updated_at":"2020-08-31T16:44:28Z","author_association":"CONTRIBUTOR","body":"@deepak1556 has manually backported this PR to \"11-x-y\", please check out #25217","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683897246","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683897246","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683897246,"node_id":"MDEyOklzc3VlQ29tbWVudDY4Mzg5NzI0Ng==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T16:46:21Z","updated_at":"2020-08-31T16:46:21Z","author_association":"CONTRIBUTOR","body":"@deepak1556 has manually backported this PR to \"9-x-y\", please check out #25218","performed_via_github_app":null},{"url":"https://api.github.com/repos/electron/electron/issues/comments/683898368","html_url":"https://github.com/electron/electron/pull/25052#issuecomment-683898368","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","id":683898368,"node_id":"MDEyOklzc3VlQ29tbWVudDY4Mzg5ODM2OA==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T16:48:17Z","updated_at":"2020-08-31T16:48:17Z","author_association":"CONTRIBUTOR","body":"@deepak1556 has manually backported this PR to \"8-x-y\", please check out #25219","performed_via_github_app":null}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-issue-25216-comments

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/25216/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 02 Sep 2020 15:55:20 GMT","etag":"W/\"dc98adeb828ec1f60e0be31a73a31f30\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"E876:6741:2819ABF:5CAD2C6:5F4FC068","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4943","x-ratelimit-reset":"1599063118","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/684017257","html_url":"https://github.com/electron/electron/pull/25216#issuecomment-684017257","issue_url":"https://api.github.com/repos/electron/electron/issues/25216","id":684017257,"node_id":"MDEyOklzc3VlQ29tbWVudDY4NDAxNzI1Nw==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2020-08-31T20:22:50Z","updated_at":"2020-08-31T20:22:50Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n> * Fixes the following issues for frameless when maximized on Windows:\r\n> * fix unreachable task bar when auto hidden with position top\r\n> * fix 1px extending to secondary monitor\r\n> * fix 1px overflowing into taskbar at certain resolutions\r\n> * fix white line on top of window under 4k resolutions","performed_via_github_app":null}]}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-20214

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/2fad53e66b1a2cb6f7dad88fe9bb62d7a461fe98/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:31:06 GMT","etag":"W/\"a02a824c8e984accc4fa3c78f76c0ab3\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"C1E2:5089:126DC:28ABA:5ECD4449","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4971","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/20214","id":316715466,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NzE1NDY2","html_url":"https://github.com/electron/electron/pull/20214","diff_url":"https://github.com/electron/electron/pull/20214.diff","patch_url":"https://github.com/electron/electron/pull/20214.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","number":20214,"state":"closed","locked":false,"title":"refactor: use v8 serialization for ipc","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\n\r\nBREAKING CHANGE\r\n\r\nThis changes IPC communication to use v8's [Structured Clone](https://html.spec.whatwg.org/multipage/structured-data.html#safe-passing-of-structured-data) algorithm instead of using the `base::Value` serialization defined in `native_mate_converters/v8_value_converter.cc`. This is be faster, more featureful, and less surprising than the existing logic, since it more-or-less matches the logic that backs `postMessage`.\r\n\r\nThis brings about a 2x performance boost for large buffers and complex objects. Latency for small messages is not significantly affected.\r\n\r\nUser-observable differences from the existing IPC API:\r\n- It's about 2x faster.\r\n- `NaN`, `Infinity`, and `undefined` are transferred as such, rather than being converted to `null`.\r\n- Cyclic objects can be transmitted.\r\n- `Set` and `Map`, `Error`, `RegExp`, `Date` and `BigInt` can be transmitted.\r\n- `Buffer` will be converted to `Uint8Array`.\r\n- Typed arrays (`Float32Array` and friends) will be transmitted as they are, instead of being converted to `Buffer`.\r\n- Sparse arrays will be transferred as sparse arrays, instead of being converted to dense arrays with `null`s.\r\n\r\n> **NOTE**: Objects that aren't serializable with V8's Structured Clone algorithm, such as functions, DOM objects, special Node/Electron objects like `process.env` or `WebContents`, or any objects containing such items will be serialized with the old `base::Value`-based algorithm. However, this behavior is deprecated and will throw an exception beginning with Electron 9.\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [x] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: IPC between main and renderer processes now uses the Structured Clone Algorithm.","created_at":"2019-09-12T03:41:25Z","updated_at":"2020-04-13T15:54:22Z","closed_at":"2019-10-09T17:59:09Z","merged_at":"2019-10-09T17:59:09Z","merge_commit_sha":"2fad53e66b1a2cb6f7dad88fe9bb62d7a461fe98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/20214/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/20214/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/20214/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/55076a368ea11a3408e390067b7cfe420707eb7d","head":{"label":"electron:cloneable-message-ipc","ref":"cloneable-message-ipc","sha":"55076a368ea11a3408e390067b7cfe420707eb7d","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"fe956f87ec6628f93bda11785e7860b97c61b085","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/20214"},"html":{"href":"https://github.com/electron/electron/pull/20214"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/20214"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/20214/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/20214/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/20214/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/55076a368ea11a3408e390067b7cfe420707eb7d"}},"author_association":"MEMBER"}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-20620

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/467409458e716c68b35fa935d556050ca6bed1c4/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 15:50:00 GMT","etag":"W/\"4541690410aaff6d5131f40248d2aa1c\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"BF14:68F2:966D8C:1003C0D:5ECD3AA7","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4991","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/20620","id":329363864,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MzYzODY0","html_url":"https://github.com/electron/electron/pull/20620","diff_url":"https://github.com/electron/electron/pull/20620.diff","patch_url":"https://github.com/electron/electron/pull/20620.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/20620","number":20620,"state":"closed","locked":false,"title":"build: add support for automated minor releases","user":{"login":"jkleinsc","id":609052,"node_id":"MDQ6VXNlcjYwOTA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/609052?v=4","gravatar_id":"","url":"https://api.github.com/users/jkleinsc","html_url":"https://github.com/jkleinsc","followers_url":"https://api.github.com/users/jkleinsc/followers","following_url":"https://api.github.com/users/jkleinsc/following{/other_user}","gists_url":"https://api.github.com/users/jkleinsc/gists{/gist_id}","starred_url":"https://api.github.com/users/jkleinsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkleinsc/subscriptions","organizations_url":"https://api.github.com/users/jkleinsc/orgs","repos_url":"https://api.github.com/users/jkleinsc/repos","events_url":"https://api.github.com/users/jkleinsc/events{/privacy}","received_events_url":"https://api.github.com/users/jkleinsc/received_events","type":"User","site_admin":true},"body":"#### Description of Change\r\n<!--\r\nThank you for your Pull Request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nContributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md\r\n-->\r\nStarting with the 8-x series we are going to switch to having an 8-x-y branch from which we can publish 8-0-x releases as well as (if necessary) 8-x-y releases. This means that if we want to release a minor version we will no longer have to create a new branch for that minor. \r\n\r\nThis PR changes our release scripts to allow for minor bumps. There will need to be corresponding changes made to sudowoodo and trop to support this change.\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: <!-- Please add a one-line description for app developers to read in the release notes, or `no-notes` if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/master/README.md#examples -->no-notes\r\n","created_at":"2019-10-17T16:54:58Z","updated_at":"2019-10-23T18:07:14Z","closed_at":"2019-10-23T18:07:10Z","merged_at":"2019-10-23T18:07:10Z","merge_commit_sha":"467409458e716c68b35fa935d556050ca6bed1c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/20620/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/20620/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/20620/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/3e83f35e702d90667842c15781f84dcb786673a8","head":{"label":"electron:support-n-x-y-branches","ref":"support-n-x-y-branches","sha":"3e83f35e702d90667842c15781f84dcb786673a8","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:39:23Z","pushed_at":"2020-05-26T15:46:58Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82995,"watchers_count":82995,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1223,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1223,"watchers":82995,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"86258c6cff88c60d730c0d1f050bb68c12c41d99","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:39:23Z","pushed_at":"2020-05-26T15:46:58Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82995,"watchers_count":82995,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1223,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1223,"watchers":82995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/20620"},"html":{"href":"https://github.com/electron/electron/pull/20620"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/20620"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/20620/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/20620/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/20620/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/3e83f35e702d90667842c15781f84dcb786673a8"}},"author_association":"MEMBER"}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-21497

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/pulls/21497","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 17:01:48 GMT","etag":"W/\"66ad2a5e4202abfacd060a1036483261\"","last-modified":"Mon, 13 Apr 2020 15:37:46 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"B826:7ED8:A60D75:11C4A36:5ECD4B75","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4991","x-ratelimit-reset":"1590514322","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/21497","id":352640324,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyNjQwMzI0","html_url":"https://github.com/electron/electron/pull/21497","diff_url":"https://github.com/electron/electron/pull/21497.diff","patch_url":"https://github.com/electron/electron/pull/21497.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/21497","number":21497,"state":"closed","locked":false,"title":"fix: workaround for hang when preventDefault-ing nativeWindowOpen (7-1-x)","user":{"login":"loc","id":1815863,"node_id":"MDQ6VXNlcjE4MTU4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1815863?v=4","gravatar_id":"","url":"https://api.github.com/users/loc","html_url":"https://github.com/loc","followers_url":"https://api.github.com/users/loc/followers","following_url":"https://api.github.com/users/loc/following{/other_user}","gists_url":"https://api.github.com/users/loc/gists{/gist_id}","starred_url":"https://api.github.com/users/loc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loc/subscriptions","organizations_url":"https://api.github.com/users/loc/orgs","repos_url":"https://api.github.com/users/loc/repos","events_url":"https://api.github.com/users/loc/events{/privacy}","received_events_url":"https://api.github.com/users/loc/received_events","type":"User","site_admin":false},"body":"### Description of Change\r\nAddresses the same issues as #21236, except without replacing the current API and cleaning up the involved code paths. Briefly, the issue is that canceling a `nativeWindowOpen`-ed window in the `new-window` event causes a hang because the WebContents is already initializing. This change adds a hook earlier, so we can cancel before it starts loading.\r\n\r\n#21236 is the \"right way\", this change is because we need the workaround sooner than time allows. We'd prefer not to rush the addition of a new API!\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Added workaround for nativeWindowOpen hang.\r\n","created_at":"2019-12-12T22:31:07Z","updated_at":"2020-04-13T15:37:46Z","closed_at":"2019-12-13T16:06:12Z","merged_at":"2019-12-13T16:06:12Z","merge_commit_sha":"1edfffae2552818daa163294450d16f093a16a6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1283062224,"node_id":"MDU6TGFiZWwxMjgzMDYyMjI0","url":"https://api.github.com/repos/electron/electron/labels/fast-track%20%F0%9F%9A%85","name":"fast-track 🚅","color":"ed0707","default":false,"description":"Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases"},{"id":1634462328,"node_id":"MDU6TGFiZWwxNjM0NDYyMzI4","url":"https://api.github.com/repos/electron/electron/labels/merged/8-x-y","name":"merged/8-x-y","color":"61a3c6","default":false,"description":"PR was merged to the \"8-x-y\" branch."},{"id":1831709348,"node_id":"MDU6TGFiZWwxODMxNzA5MzQ4","url":"https://api.github.com/repos/electron/electron/labels/merged/9-x-y","name":"merged/9-x-y","color":"61a3c6","default":false,"description":""},{"id":1982961443,"node_id":"MDU6TGFiZWwxOTgyOTYxNDQz","url":"https://api.github.com/repos/electron/electron/labels/merged/master","name":"merged/master","color":"61a3c6","default":false,"description":""}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/21497/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/21497/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/21497/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/525ce7926585df7a5dc7895bcf9e426317e4c31d","head":{"label":"electron:loc/native-window-open-hang-7-1-x","ref":"loc/native-window-open-hang-7-1-x","sha":"525ce7926585df7a5dc7895bcf9e426317e4c31d","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:7-1-x","ref":"7-1-x","sha":"8f728af13ae8a8481ba1ada6679c507895913a67","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/21497"},"html":{"href":"https://github.com/electron/electron/pull/21497"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/21497"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/21497/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/21497/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/21497/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/525ce7926585df7a5dc7895bcf9e426317e4c31d"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false},"comments":11,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":54,"deletions":0,"changed_files":3}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-21591

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/8bc0c92137f4a77dc831ca644a86a3e48b51a11e/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 04:04:13 GMT","etag":"W/\"ec4682709ef52766317ea4b47c247d68\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"811A:6500:2B2B5B:60C764:5ECC9537","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4998","x-ratelimit-reset":"1590469445","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/21591","id":355863062,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1ODYzMDYy","html_url":"https://github.com/electron/electron/pull/21591","diff_url":"https://github.com/electron/electron/pull/21591.diff","patch_url":"https://github.com/electron/electron/pull/21591.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/21591","number":21591,"state":"closed","locked":false,"title":"feat: [extensions] background pages","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\nThis adds support for lazy background pages when building with ENABLE_ELECTRON_EXTENSIONS. One step closer to a functional React DevTools!\r\n\r\nNB. no release notes because this feature is still behind the ENABLE_ELECTRON_EXTENSIONS flag, which is not enabled in Electron release builds.\r\n\r\nRef #19447\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] PR description included and stakeholders cc'd\r\n- [ ] `npm test` passes\r\n- [ ] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [ ] relevant documentation is changed or added\r\n- [ ] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [ ] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: none\r\n","created_at":"2019-12-20T19:06:41Z","updated_at":"2020-01-13T22:56:03Z","closed_at":"2020-01-13T22:55:58Z","merged_at":"2020-01-13T22:55:58Z","merge_commit_sha":"8bc0c92137f4a77dc831ca644a86a3e48b51a11e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/21591/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/21591/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/21591/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/391bf72b0bdad568d8e36300e47c8c3915ab751e","head":{"label":"electron:extensions-background-pages","ref":"extensions-background-pages","sha":"391bf72b0bdad568d8e36300e47c8c3915ab751e","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T03:18:11Z","pushed_at":"2020-05-26T02:52:23Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75421,"stargazers_count":82973,"watchers_count":82973,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11130,"open_issues":1224,"watchers":82973,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"7161b2f57c8a0da87d8e2d54f240c16f5b2afe4b","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T03:18:11Z","pushed_at":"2020-05-26T02:52:23Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75421,"stargazers_count":82973,"watchers_count":82973,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11130,"open_issues":1224,"watchers":82973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/21591"},"html":{"href":"https://github.com/electron/electron/pull/21591"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/21591"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/21591/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/21591/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/21591/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/391bf72b0bdad568d8e36300e47c8c3915ab751e"}},"author_association":"MEMBER"}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-21891

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/89eb309d0b22bd4aec058ffaf983e81e56a5c378/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 04:04:06 GMT","etag":"W/\"442672ace5270531a2ffdc83b3b51f20\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"8118:3989:536BFA:8CED70:5ECC9535","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4999","x-ratelimit-reset":"1590469446","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/21891","id":367058148,"node_id":"MDExOlB1bGxSZXF1ZXN0MzY3MDU4MTQ4","html_url":"https://github.com/electron/electron/pull/21891","diff_url":"https://github.com/electron/electron/pull/21891.diff","patch_url":"https://github.com/electron/electron/pull/21891.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/21891","number":21891,"state":"closed","locked":false,"title":"feat: allow GUID parameter to avoid systray demotion on Windows ","user":{"login":"bitdisaster","id":5191943,"node_id":"MDQ6VXNlcjUxOTE5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5191943?v=4","gravatar_id":"","url":"https://api.github.com/users/bitdisaster","html_url":"https://github.com/bitdisaster","followers_url":"https://api.github.com/users/bitdisaster/followers","following_url":"https://api.github.com/users/bitdisaster/following{/other_user}","gists_url":"https://api.github.com/users/bitdisaster/gists{/gist_id}","starred_url":"https://api.github.com/users/bitdisaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitdisaster/subscriptions","organizations_url":"https://api.github.com/users/bitdisaster/orgs","repos_url":"https://api.github.com/users/bitdisaster/repos","events_url":"https://api.github.com/users/bitdisaster/events{/privacy}","received_events_url":"https://api.github.com/users/bitdisaster/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\nEnhances the Tray API on Windows to avoid demotion of the icon position in the system tray. With normal usage of the Windows API https://docs.microsoft.com/en-us/windows/win32/api/shellapi/ns-shellapi-notifyicondataa a user customized position of the icon is linked to the absolute file path of the executable. If the path changes, mostly by updater frameworks such Squirrel.Windows, the position is lost, and the icon will be placed back in the overflow area.\r\nHowever, the combination of a code signed binary and GUID parameter can make the positioning of the icon persistent even if the path to the executable changes.\r\nThe use of the GUID parameter also fixes a behavior where the position of a second or third icon will be lost on each restart of the App. Even if the path has not changed. \r\n\r\nI’m aware of a previous attempt https://github.com/electron/electron/pull/2328 to introduce the GUID parameter. The reason why it failed and had to be rolled back is bases on Microsofts somewhat incomplete/confusing documentation. A couple of gotchas:\r\n\r\n- The GUID is not a replacement/alternative for the uID. The uID parameter is still needed to identify the icon via Hwnd messages. \r\n- The GUID parameter is no global Id for the app that seeks to create icons in the system tray. Each icon needs its own GUID if multiple icons are created.\r\n- The GUID is best used in combination with a code signed binary. Once it is used with code signature, the GUID is permanently bound to it.\r\n- The code signature has to contain CN, OU, O in the subject line. \r\n- The GUID parameter can be used with none code signed binary. However, now the GUID is permanently bound to the path of the binary. If the path changes and the same GUID is used the creation the Tray icon will fail. Since the GUID was statically derived from the AppUserModelId, PR 2328 had to be reverted because it broke all Apps without code signature when they updated and changed there executable path.\r\n\r\nBased on above behaviors of the Windows API its best to make this an opt-in. The developer has to be aware of the behavior/requirements using the GUID parameter. It also allows the mitigation of unexpected problems with the Tray creation by providing a new GUID.\r\n\r\n<!--\r\nThank you for your Pull Request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nContributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] PR description included and stakeholders cc'd\r\n- [X] `npm test` passes\r\n- [X] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [X] relevant documentation is changed or added\r\n- [X] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Added GUID parameter to Tray API to avoid system tray icon demotion on Windows <!-- Please add a one-line description for app developers to read in the release notes, or `no-notes` if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/master/README.md#examples -->\r\n","created_at":"2020-01-24T23:45:33Z","updated_at":"2020-01-31T05:37:07Z","closed_at":"2020-01-31T05:37:04Z","merged_at":"2020-01-31T05:37:04Z","merge_commit_sha":"89eb309d0b22bd4aec058ffaf983e81e56a5c378","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MarshallOfSound","id":6634592,"node_id":"MDQ6VXNlcjY2MzQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6634592?v=4","gravatar_id":"","url":"https://api.github.com/users/MarshallOfSound","html_url":"https://github.com/MarshallOfSound","followers_url":"https://api.github.com/users/MarshallOfSound/followers","following_url":"https://api.github.com/users/MarshallOfSound/following{/other_user}","gists_url":"https://api.github.com/users/MarshallOfSound/gists{/gist_id}","starred_url":"https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarshallOfSound/subscriptions","organizations_url":"https://api.github.com/users/MarshallOfSound/orgs","repos_url":"https://api.github.com/users/MarshallOfSound/repos","events_url":"https://api.github.com/users/MarshallOfSound/events{/privacy}","received_events_url":"https://api.github.com/users/MarshallOfSound/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/21891/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/21891/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/21891/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/e72c7ec1aa0d52e4fe5a6d77f1fa558c0dde6e4d","head":{"label":"bitdisaster:fix-systray-demotion-on-windows","ref":"fix-systray-demotion-on-windows","sha":"e72c7ec1aa0d52e4fe5a6d77f1fa558c0dde6e4d","user":{"login":"bitdisaster","id":5191943,"node_id":"MDQ6VXNlcjUxOTE5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5191943?v=4","gravatar_id":"","url":"https://api.github.com/users/bitdisaster","html_url":"https://github.com/bitdisaster","followers_url":"https://api.github.com/users/bitdisaster/followers","following_url":"https://api.github.com/users/bitdisaster/following{/other_user}","gists_url":"https://api.github.com/users/bitdisaster/gists{/gist_id}","starred_url":"https://api.github.com/users/bitdisaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitdisaster/subscriptions","organizations_url":"https://api.github.com/users/bitdisaster/orgs","repos_url":"https://api.github.com/users/bitdisaster/repos","events_url":"https://api.github.com/users/bitdisaster/events{/privacy}","received_events_url":"https://api.github.com/users/bitdisaster/received_events","type":"User","site_admin":false},"repo":{"id":216672113,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY2NzIxMTM=","name":"electron","full_name":"bitdisaster/electron","private":false,"owner":{"login":"bitdisaster","id":5191943,"node_id":"MDQ6VXNlcjUxOTE5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5191943?v=4","gravatar_id":"","url":"https://api.github.com/users/bitdisaster","html_url":"https://github.com/bitdisaster","followers_url":"https://api.github.com/users/bitdisaster/followers","following_url":"https://api.github.com/users/bitdisaster/following{/other_user}","gists_url":"https://api.github.com/users/bitdisaster/gists{/gist_id}","starred_url":"https://api.github.com/users/bitdisaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitdisaster/subscriptions","organizations_url":"https://api.github.com/users/bitdisaster/orgs","repos_url":"https://api.github.com/users/bitdisaster/repos","events_url":"https://api.github.com/users/bitdisaster/events{/privacy}","received_events_url":"https://api.github.com/users/bitdisaster/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bitdisaster/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":true,"url":"https://api.github.com/repos/bitdisaster/electron","forks_url":"https://api.github.com/repos/bitdisaster/electron/forks","keys_url":"https://api.github.com/repos/bitdisaster/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitdisaster/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitdisaster/electron/teams","hooks_url":"https://api.github.com/repos/bitdisaster/electron/hooks","issue_events_url":"https://api.github.com/repos/bitdisaster/electron/issues/events{/number}","events_url":"https://api.github.com/repos/bitdisaster/electron/events","assignees_url":"https://api.github.com/repos/bitdisaster/electron/assignees{/user}","branches_url":"https://api.github.com/repos/bitdisaster/electron/branches{/branch}","tags_url":"https://api.github.com/repos/bitdisaster/electron/tags","blobs_url":"https://api.github.com/repos/bitdisaster/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitdisaster/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitdisaster/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitdisaster/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitdisaster/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/bitdisaster/electron/languages","stargazers_url":"https://api.github.com/repos/bitdisaster/electron/stargazers","contributors_url":"https://api.github.com/repos/bitdisaster/electron/contributors","subscribers_url":"https://api.github.com/repos/bitdisaster/electron/subscribers","subscription_url":"https://api.github.com/repos/bitdisaster/electron/subscription","commits_url":"https://api.github.com/repos/bitdisaster/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitdisaster/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitdisaster/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitdisaster/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitdisaster/electron/contents/{+path}","compare_url":"https://api.github.com/repos/bitdisaster/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitdisaster/electron/merges","archive_url":"https://api.github.com/repos/bitdisaster/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitdisaster/electron/downloads","issues_url":"https://api.github.com/repos/bitdisaster/electron/issues{/number}","pulls_url":"https://api.github.com/repos/bitdisaster/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/bitdisaster/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/bitdisaster/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitdisaster/electron/labels{/name}","releases_url":"https://api.github.com/repos/bitdisaster/electron/releases{/id}","deployments_url":"https://api.github.com/repos/bitdisaster/electron/deployments","created_at":"2019-10-21T21:53:10Z","updated_at":"2020-01-20T18:30:37Z","pushed_at":"2020-01-28T23:56:20Z","git_url":"git://github.com/bitdisaster/electron.git","ssh_url":"git@github.com:bitdisaster/electron.git","clone_url":"https://github.com/bitdisaster/electron.git","svn_url":"https://github.com/bitdisaster/electron","homepage":"https://electronjs.org","size":68832,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"28fb2b7ed5c96fdae559ea015e99f3acb6b12023","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T03:18:11Z","pushed_at":"2020-05-26T02:52:23Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75421,"stargazers_count":82973,"watchers_count":82973,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11130,"open_issues":1224,"watchers":82973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/21891"},"html":{"href":"https://github.com/electron/electron/pull/21891"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/21891"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/21891/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/21891/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/21891/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/e72c7ec1aa0d52e4fe5a6d77f1fa558c0dde6e4d"}},"author_association":"MEMBER"}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-21946

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/2955c67c4ea712fa22773ac9113709fc952bfd49/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:25:38 GMT","etag":"W/\"7be19eed3b62d434bcbc8ed63e9c6fe9\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"CC2A:2EDB:AF2650:12289C2:5ECD4301","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4975","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/21946","id":368254138,"node_id":"MDExOlB1bGxSZXF1ZXN0MzY4MjU0MTM4","html_url":"https://github.com/electron/electron/pull/21946","diff_url":"https://github.com/electron/electron/pull/21946.diff","patch_url":"https://github.com/electron/electron/pull/21946.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/21946","number":21946,"state":"closed","locked":false,"title":"fix: prevent print crash on bad deviceName","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"body":"#### Description of Change\r\n\r\nOn [Windows](https://source.chromium.org/chromium/chromium/src/+/master:printing/printing_context_win.cc;l=157?originalUrl=https:%2F%2Fcs.chromium.org%2F) and [macOS](https://source.chromium.org/chromium/chromium/src/+/master:printing/printing_context_mac.mm;l=226?originalUrl=https:%2F%2Fcs.chromium.org%2F), Chromium's printing code will crash if a `deviceName` is provided, but is invalid on the network, i.e does not correspond to a printer that the caller machine is aware of. This bug has been present for a long time, but after playing around a bit I've determined that it's possible to catch faulty `deviceName`s by pulling out some of the printer validation code from Chromium. This PR adds that check for Windows and macOS as well as tests for the same.\r\n\r\nTested with:\r\n```js\r\nwin.webContents.on('did-finish-load', () => {\r\n win.webContents.print({deviceName: 'bad-printer-name'}, (success, reason) => {\r\n console.log(`printing ${success ? 'did' : 'did not'} succeed: ${reason}`)\r\n })\r\n})\r\n```\r\n\r\ncc @ckerr @zcbenz \r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [x] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Fixed a potential crash on faulty `deviceName`s in `webContents.print()`.\r\n","created_at":"2020-01-28T22:02:08Z","updated_at":"2020-05-18T18:15:29Z","closed_at":"2020-01-31T02:49:14Z","merged_at":"2020-01-31T02:49:14Z","merge_commit_sha":"2955c67c4ea712fa22773ac9113709fc952bfd49","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ckerr","id":70381,"node_id":"MDQ6VXNlcjcwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/70381?v=4","gravatar_id":"","url":"https://api.github.com/users/ckerr","html_url":"https://github.com/ckerr","followers_url":"https://api.github.com/users/ckerr/followers","following_url":"https://api.github.com/users/ckerr/following{/other_user}","gists_url":"https://api.github.com/users/ckerr/gists{/gist_id}","starred_url":"https://api.github.com/users/ckerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckerr/subscriptions","organizations_url":"https://api.github.com/users/ckerr/orgs","repos_url":"https://api.github.com/users/ckerr/repos","events_url":"https://api.github.com/users/ckerr/events{/privacy}","received_events_url":"https://api.github.com/users/ckerr/received_events","type":"User","site_admin":true}],"requested_teams":[],"labels":[{"id":1657635084,"node_id":"MDU6TGFiZWwxNjU3NjM1MDg0","url":"https://api.github.com/repos/electron/electron/labels/merged/7-1-x","name":"merged/7-1-x","color":"61a3c6","default":false,"description":"PR was merged to the \"7-1-x\" branch."},{"id":1634462328,"node_id":"MDU6TGFiZWwxNjM0NDYyMzI4","url":"https://api.github.com/repos/electron/electron/labels/merged/8-x-y","name":"merged/8-x-y","color":"61a3c6","default":false,"description":"PR was merged to the \"8-x-y\" branch."}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/21946/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/21946/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/21946/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/858dbc690b159ecf767e6ae55e476f73ead931f6","head":{"label":"electron:sanity-check-devicename","ref":"sanity-check-devicename","sha":"858dbc690b159ecf767e6ae55e476f73ead931f6","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:02:47Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"0979bfc9c1a3ad2d9a8d32eb63db6940d278ff02","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:02:47Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75428,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/21946"},"html":{"href":"https://github.com/electron/electron/pull/21946"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/21946"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/21946/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/21946/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/21946/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/858dbc690b159ecf767e6ae55e476f73ead931f6"}},"author_association":"MEMBER"}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-22750

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/a6ff42c190cb5caf8f3e217748e49183a951491b/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 17:01:40 GMT","etag":"W/\"0efacfb47a3fe381a80ea2cc1cfc1bab\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"B824:2157:A9EDEF:128DDCF:5ECD4B73","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4992","x-ratelimit-reset":"1590514322","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/22750","id":390602476,"node_id":"MDExOlB1bGxSZXF1ZXN0MzkwNjAyNDc2","html_url":"https://github.com/electron/electron/pull/22750","diff_url":"https://github.com/electron/electron/pull/22750.diff","patch_url":"https://github.com/electron/electron/pull/22750.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/22750","number":22750,"state":"closed","locked":false,"title":"fix: workaround for hang when preventDefault-ing nativeWindowOpen","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #21497\n\nSee that PR for details.\n\n\r\nNotes: Added workaround for nativeWindowOpen hang.\r\n","created_at":"2020-03-18T18:38:17Z","updated_at":"2020-03-25T01:40:17Z","closed_at":"2020-03-25T01:40:13Z","merged_at":"2020-03-25T01:40:13Z","merge_commit_sha":"a6ff42c190cb5caf8f3e217748e49183a951491b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"loc","id":1815863,"node_id":"MDQ6VXNlcjE4MTU4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1815863?v=4","gravatar_id":"","url":"https://api.github.com/users/loc","html_url":"https://github.com/loc","followers_url":"https://api.github.com/users/loc/followers","following_url":"https://api.github.com/users/loc/following{/other_user}","gists_url":"https://api.github.com/users/loc/gists{/gist_id}","starred_url":"https://api.github.com/users/loc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loc/subscriptions","organizations_url":"https://api.github.com/users/loc/orgs","repos_url":"https://api.github.com/users/loc/repos","events_url":"https://api.github.com/users/loc/events{/privacy}","received_events_url":"https://api.github.com/users/loc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/22750/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/22750/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/22750/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/f24780c35de76aabbc24aa9cb4373380081210d8","head":{"label":"electron:trop/9-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556691390","ref":"trop/9-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556691390","sha":"f24780c35de76aabbc24aa9cb4373380081210d8","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"9b14ae770dd5f4bb5ec4cfdb803c40174a8a555e","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/22750"},"html":{"href":"https://github.com/electron/electron/pull/22750"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/22750"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/22750/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/22750/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/22750/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/f24780c35de76aabbc24aa9cb4373380081210d8"}},"author_association":"CONTRIBUTOR"}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-22770

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/pulls/22770","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:42:34 GMT","etag":"W/\"553fb65b1bf6e194fd38605f19e8041f\"","last-modified":"Mon, 04 May 2020 15:46:25 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"C9A6:34CF:A72E:121AD:5ECD46F3","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4995","x-ratelimit-reset":"1590514322","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/22770","id":391093520,"node_id":"MDExOlB1bGxSZXF1ZXN0MzkxMDkzNTIw","html_url":"https://github.com/electron/electron/pull/22770","diff_url":"https://github.com/electron/electron/pull/22770.diff","patch_url":"https://github.com/electron/electron/pull/22770.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/22770","number":22770,"state":"closed","locked":false,"title":"fix: don't allow window to go behind menu bar on mac","user":{"login":"CezaryKulakowski","id":50166166,"node_id":"MDQ6VXNlcjUwMTY2MTY2","avatar_url":"https://avatars2.githubusercontent.com/u/50166166?v=4","gravatar_id":"","url":"https://api.github.com/users/CezaryKulakowski","html_url":"https://github.com/CezaryKulakowski","followers_url":"https://api.github.com/users/CezaryKulakowski/followers","following_url":"https://api.github.com/users/CezaryKulakowski/following{/other_user}","gists_url":"https://api.github.com/users/CezaryKulakowski/gists{/gist_id}","starred_url":"https://api.github.com/users/CezaryKulakowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CezaryKulakowski/subscriptions","organizations_url":"https://api.github.com/users/CezaryKulakowski/orgs","repos_url":"https://api.github.com/users/CezaryKulakowski/repos","events_url":"https://api.github.com/users/CezaryKulakowski/events{/privacy}","received_events_url":"https://api.github.com/users/CezaryKulakowski/received_events","type":"User","site_admin":false},"body":"This change fixes #22667.\r\n\r\nNotes: don't allow window to go behind menu bar on mac\r\n","created_at":"2020-03-19T16:05:51Z","updated_at":"2020-03-25T15:45:36Z","closed_at":"2020-03-25T02:13:44Z","merged_at":"2020-03-25T02:13:44Z","merge_commit_sha":"bdef77bad89f762ecb755c028bb2d166493b9f14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1831709348,"node_id":"MDU6TGFiZWwxODMxNzA5MzQ4","url":"https://api.github.com/repos/electron/electron/labels/merged/9-x-y","name":"merged/9-x-y","color":"61a3c6","default":false,"description":""}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/22770/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/22770/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/22770/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/2b35fc0874c5aa14dc3d2f9948a0c4e936f0d5db","head":{"label":"CezaryKulakowski:issue_22667","ref":"issue_22667","sha":"2b35fc0874c5aa14dc3d2f9948a0c4e936f0d5db","user":{"login":"CezaryKulakowski","id":50166166,"node_id":"MDQ6VXNlcjUwMTY2MTY2","avatar_url":"https://avatars2.githubusercontent.com/u/50166166?v=4","gravatar_id":"","url":"https://api.github.com/users/CezaryKulakowski","html_url":"https://github.com/CezaryKulakowski","followers_url":"https://api.github.com/users/CezaryKulakowski/followers","following_url":"https://api.github.com/users/CezaryKulakowski/following{/other_user}","gists_url":"https://api.github.com/users/CezaryKulakowski/gists{/gist_id}","starred_url":"https://api.github.com/users/CezaryKulakowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CezaryKulakowski/subscriptions","organizations_url":"https://api.github.com/users/CezaryKulakowski/orgs","repos_url":"https://api.github.com/users/CezaryKulakowski/repos","events_url":"https://api.github.com/users/CezaryKulakowski/events{/privacy}","received_events_url":"https://api.github.com/users/CezaryKulakowski/received_events","type":"User","site_admin":false},"repo":{"id":198434535,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg0MzQ1MzU=","name":"electron","full_name":"CezaryKulakowski/electron","private":false,"owner":{"login":"CezaryKulakowski","id":50166166,"node_id":"MDQ6VXNlcjUwMTY2MTY2","avatar_url":"https://avatars2.githubusercontent.com/u/50166166?v=4","gravatar_id":"","url":"https://api.github.com/users/CezaryKulakowski","html_url":"https://github.com/CezaryKulakowski","followers_url":"https://api.github.com/users/CezaryKulakowski/followers","following_url":"https://api.github.com/users/CezaryKulakowski/following{/other_user}","gists_url":"https://api.github.com/users/CezaryKulakowski/gists{/gist_id}","starred_url":"https://api.github.com/users/CezaryKulakowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CezaryKulakowski/subscriptions","organizations_url":"https://api.github.com/users/CezaryKulakowski/orgs","repos_url":"https://api.github.com/users/CezaryKulakowski/repos","events_url":"https://api.github.com/users/CezaryKulakowski/events{/privacy}","received_events_url":"https://api.github.com/users/CezaryKulakowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CezaryKulakowski/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":true,"url":"https://api.github.com/repos/CezaryKulakowski/electron","forks_url":"https://api.github.com/repos/CezaryKulakowski/electron/forks","keys_url":"https://api.github.com/repos/CezaryKulakowski/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CezaryKulakowski/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CezaryKulakowski/electron/teams","hooks_url":"https://api.github.com/repos/CezaryKulakowski/electron/hooks","issue_events_url":"https://api.github.com/repos/CezaryKulakowski/electron/issues/events{/number}","events_url":"https://api.github.com/repos/CezaryKulakowski/electron/events","assignees_url":"https://api.github.com/repos/CezaryKulakowski/electron/assignees{/user}","branches_url":"https://api.github.com/repos/CezaryKulakowski/electron/branches{/branch}","tags_url":"https://api.github.com/repos/CezaryKulakowski/electron/tags","blobs_url":"https://api.github.com/repos/CezaryKulakowski/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CezaryKulakowski/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CezaryKulakowski/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/CezaryKulakowski/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CezaryKulakowski/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/CezaryKulakowski/electron/languages","stargazers_url":"https://api.github.com/repos/CezaryKulakowski/electron/stargazers","contributors_url":"https://api.github.com/repos/CezaryKulakowski/electron/contributors","subscribers_url":"https://api.github.com/repos/CezaryKulakowski/electron/subscribers","subscription_url":"https://api.github.com/repos/CezaryKulakowski/electron/subscription","commits_url":"https://api.github.com/repos/CezaryKulakowski/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/CezaryKulakowski/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/CezaryKulakowski/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/CezaryKulakowski/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/CezaryKulakowski/electron/contents/{+path}","compare_url":"https://api.github.com/repos/CezaryKulakowski/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CezaryKulakowski/electron/merges","archive_url":"https://api.github.com/repos/CezaryKulakowski/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CezaryKulakowski/electron/downloads","issues_url":"https://api.github.com/repos/CezaryKulakowski/electron/issues{/number}","pulls_url":"https://api.github.com/repos/CezaryKulakowski/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/CezaryKulakowski/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/CezaryKulakowski/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CezaryKulakowski/electron/labels{/name}","releases_url":"https://api.github.com/repos/CezaryKulakowski/electron/releases{/id}","deployments_url":"https://api.github.com/repos/CezaryKulakowski/electron/deployments","created_at":"2019-07-23T13:18:19Z","updated_at":"2019-07-23T13:18:27Z","pushed_at":"2020-05-05T12:05:26Z","git_url":"git://github.com/CezaryKulakowski/electron.git","ssh_url":"git@github.com:CezaryKulakowski/electron.git","clone_url":"https://github.com/CezaryKulakowski/electron.git","svn_url":"https://github.com/CezaryKulakowski/electron","homepage":"https://electronjs.org","size":70669,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"4b0d445f7402e241b5b566760bddc905ad4f4a79","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/22770"},"html":{"href":"https://github.com/electron/electron/pull/22770"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/22770"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/22770/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/22770/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/22770/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/2b35fc0874c5aa14dc3d2f9948a0c4e936f0d5db"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":4,"changed_files":2}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-22828

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/0600420bac25439fc2067d51c6aaa4ee11770577/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:42:26 GMT","etag":"W/\"3601649b1f433390bb296fd32be0d785\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"C9A4:6695:0E0D:2D25:5ECD46F2","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4996","x-ratelimit-reset":"1590514322","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/22828","id":393345723,"node_id":"MDExOlB1bGxSZXF1ZXN0MzkzMzQ1NzIz","html_url":"https://github.com/electron/electron/pull/22828","diff_url":"https://github.com/electron/electron/pull/22828.diff","patch_url":"https://github.com/electron/electron/pull/22828.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/22828","number":22828,"state":"closed","locked":false,"title":"fix: don't allow window to go behind menu bar on mac","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Backport of #22770\n\nSee that PR for details.\n\n\r\nNotes: don't allow window to go behind menu bar on mac\r\n","created_at":"2020-03-25T02:14:01Z","updated_at":"2020-03-25T15:45:37Z","closed_at":"2020-03-25T15:45:33Z","merged_at":"2020-03-25T15:45:33Z","merge_commit_sha":"0600420bac25439fc2067d51c6aaa4ee11770577","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1780693018,"node_id":"MDU6TGFiZWwxNzgwNjkzMDE4","url":"https://api.github.com/repos/electron/electron/labels/9-x-y","name":"9-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/22828/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/22828/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/22828/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/5d7b551db68d672816e47da4bf31d7c3cc29b241","head":{"label":"electron:trop/9-x-y-bp-fix-don-t-allow-window-to-go-behind-menu-bar-on-mac-1585102436930","ref":"trop/9-x-y-bp-fix-don-t-allow-window-to-go-behind-menu-bar-on-mac-1585102436930","sha":"5d7b551db68d672816e47da4bf31d7c3cc29b241","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"base":{"label":"electron:9-x-y","ref":"9-x-y","sha":"a6ff42c190cb5caf8f3e217748e49183a951491b","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-05-26T15:59:03Z","pushed_at":"2020-05-26T16:28:49Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":75430,"stargazers_count":82996,"watchers_count":82996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11129,"open_issues":1224,"watchers":82996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/22828"},"html":{"href":"https://github.com/electron/electron/pull/22828"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/22828"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/22828/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/22828/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/22828/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/5d7b551db68d672816e47da4bf31d7c3cc29b241"}},"author_association":"CONTRIBUTOR"}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-25052

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/pulls/25052","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 03 Sep 2020 15:54:53 GMT","etag":"W/\"841bf3d88759e6cf2099f0ab109ba9a8\"","last-modified":"Thu, 03 Sep 2020 02:38:46 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"B8E8:3501:6D7807:1553CD9:5F5111CD","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4973","x-ratelimit-reset":"1599149937","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/25052","id":470529819,"node_id":"MDExOlB1bGxSZXF1ZXN0NDcwNTI5ODE5","html_url":"https://github.com/electron/electron/pull/25052","diff_url":"https://github.com/electron/electron/pull/25052.diff","patch_url":"https://github.com/electron/electron/pull/25052.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/25052","number":25052,"state":"closed","locked":false,"title":"fix: client area inset calculation when maximized for framless windows","user":{"login":"deepak1556","id":964386,"node_id":"MDQ6VXNlcjk2NDM4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/964386?v=4","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\n\r\nFixes the following regressions introduced by https://github.com/electron/electron/pull/21164\r\n\r\nRefs\r\n\r\nhttps://github.com/microsoft/vscode/issues/86260\r\nhttps://github.com/microsoft/vscode/issues/85310\r\nhttps://github.com/microsoft/vscode/issues/85592\r\nhttps://github.com/microsoft/vscode/issues/85655\r\n\r\nAlso fixes a side effect of this bug that caused increased usage of GPU under certain conditions which was identified by teams app.\r\n\r\nGist: https://gist.github.com/deepak1556/6e672eea191d3e5f50e429d312a56446\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [ ] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [ ] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n- [x] This is **NOT A BREAKING CHANGE**. Breaking changes may not be merged to master until 11-x-y is branched.\r\n\r\n#### Release Notes\r\n\r\nNotes: Fixes the following issues for frameless when maximized on Windows\r\n* fix unreachable task bar when auto hidden with position top\r\n* fix 1px extending to secondary monitor\r\n* fix 1px overflowing into taskbar at certain resolutions\r\n* fix white line on top of window under 4k resolutions","created_at":"2020-08-20T00:34:52Z","updated_at":"2020-08-31T20:51:23Z","closed_at":"2020-08-31T07:55:51Z","merged_at":"2020-08-31T07:55:50Z","merge_commit_sha":"068b464e13f5fd881bd72c9e5acf11c391173ea1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":2079356337,"node_id":"MDU6TGFiZWwyMDc5MzU2MzM3","url":"https://api.github.com/repos/electron/electron/labels/merged/10-x-y","name":"merged/10-x-y","color":"61a3c6","default":false,"description":""},{"id":2306506266,"node_id":"MDU6TGFiZWwyMzA2NTA2MjY2","url":"https://api.github.com/repos/electron/electron/labels/merged/11-x-y","name":"merged/11-x-y","color":"ededed","default":false,"description":null},{"id":1634462328,"node_id":"MDU6TGFiZWwxNjM0NDYyMzI4","url":"https://api.github.com/repos/electron/electron/labels/merged/8-x-y","name":"merged/8-x-y","color":"61a3c6","default":false,"description":"PR was merged to the \"8-x-y\" branch."},{"id":1831709348,"node_id":"MDU6TGFiZWwxODMxNzA5MzQ4","url":"https://api.github.com/repos/electron/electron/labels/merged/9-x-y","name":"merged/9-x-y","color":"61a3c6","default":false,"description":""}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/25052/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/25052/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/25052/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/b75aad39f587d13ae4930be1a341abe3a292da75","head":{"label":"electron:robo/fix_inset_calc","ref":"robo/fix_inset_calc","sha":"b75aad39f587d13ae4930be1a341abe3a292da75","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"e8ef1ef252e8f2fb00f13c42d8b1fb08dc99602c","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-03T15:32:22Z","pushed_at":"2020-09-03T15:53:05Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79516,"stargazers_count":85543,"watchers_count":85543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11448,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11448,"open_issues":1382,"watchers":85543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/25052"},"html":{"href":"https://github.com/electron/electron/pull/25052"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/25052"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/25052/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/25052/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/25052/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/b75aad39f587d13ae4930be1a341abe3a292da75"}},"author_association":"MEMBER","active_lock_reason":null,"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"comments":11,"review_comments":3,"maintainer_can_modify":false,"commits":6,"additions":74,"deletions":6,"changed_files":4}}

electron/spec-main/fixtures/release-notes/cache/electron-electron-pull-25216

Line 1 in 99c48c6

{"status":200,"url":"https://api.github.com/repos/electron/electron/commits/61dc1c88fd34a3e8fff80c80ed79d0455970e610/pulls","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 02 Sep 2020 15:55:14 GMT","etag":"W/\"97953e969b52b99e9d7cca09c5420ae7\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.groot-preview; format=json","x-github-request-id":"C1A6:5710:29341EE:5EA9384:5F4FC062","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4955","x-ratelimit-reset":"1599063118","x-xss-protection":"1; mode=block"},"data":{"url":"https://api.github.com/repos/electron/electron/pulls/25216","id":476409290,"node_id":"MDExOlB1bGxSZXF1ZXN0NDc2NDA5Mjkw","html_url":"https://github.com/electron/electron/pull/25216","diff_url":"https://github.com/electron/electron/pull/25216.diff","patch_url":"https://github.com/electron/electron/pull/25216.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/25216","number":25216,"state":"closed","locked":false,"title":"fix: client area inset calculation when maximized for framless windows","user":{"login":"deepak1556","id":964386,"node_id":"MDQ6VXNlcjk2NDM4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/964386?v=4","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"#### Description of Change\r\n\r\nBackports https://github.com/electron/electron/pull/25052\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [ ] `npm test` passes\r\n- [ ] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [ ] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n- [x] This is **NOT A BREAKING CHANGE**. Breaking changes may not be merged to master until 11-x-y is branched.\r\n\r\n#### Release Notes\r\n\r\nNotes:\r\n* Fixes the following issues for frameless when maximized on Windows:\r\n* fix unreachable task bar when auto hidden with position top\r\n* fix 1px extending to secondary monitor\r\n* fix 1px overflowing into taskbar at certain resolutions\r\n* fix white line on top of window under 4k resolutions","created_at":"2020-08-31T16:42:51Z","updated_at":"2020-08-31T20:23:06Z","closed_at":"2020-08-31T20:22:47Z","merged_at":"2020-08-31T20:22:47Z","merge_commit_sha":"61dc1c88fd34a3e8fff80c80ed79d0455970e610","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1858180153,"node_id":"MDU6TGFiZWwxODU4MTgwMTUz","url":"https://api.github.com/repos/electron/electron/labels/10-x-y","name":"10-x-y","color":"8d9ee8","default":false,"description":""},{"id":865096932,"node_id":"MDU6TGFiZWw4NjUwOTY5MzI=","url":"https://api.github.com/repos/electron/electron/labels/backport","name":"backport","color":"ddddde","default":false,"description":"This is a backport PR"}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/electron/electron/pulls/25216/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/25216/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/25216/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/b9a5849e07e0fca6c3ceb66dddac69106d21310a","head":{"label":"electron:robo/bp_25052_10","ref":"robo/bp_25052_10","sha":"b9a5849e07e0fca6c3ceb66dddac69106d21310a","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-02T14:32:43Z","pushed_at":"2020-09-02T15:14:26Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79448,"stargazers_count":85509,"watchers_count":85509,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11445,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1386,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11445,"open_issues":1386,"watchers":85509,"default_branch":"master"}},"base":{"label":"electron:10-x-y","ref":"10-x-y","sha":"615dce32759a5d34797f2445f06622aba1fb6b21","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MjY3","name":"electron","full_name":"electron/electron","private":false,"owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electron/electron","description":":electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2020-09-02T14:32:43Z","pushed_at":"2020-09-02T15:14:26Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":79448,"stargazers_count":85509,"watchers_count":85509,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11445,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1386,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11445,"open_issues":1386,"watchers":85509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/25216"},"html":{"href":"https://github.com/electron/electron/pull/25216"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/25216"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/25216/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/25216/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/25216/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/b9a5849e07e0fca6c3ceb66dddac69106d21310a"}},"author_association":"MEMBER","active_lock_reason":null}}

electron/spec-main/release-notes-spec.ts

Line 95 in 99c48c6

new Commit('2abea22b4bffa1626a521711bacec7cd51425818', "fix: explicitly cancel redirects when mode is 'error' (#20686)"),

electron/spec-main/release-notes-spec.ts

Line 96 in 99c48c6

new Commit('467409458e716c68b35fa935d556050ca6bed1c4', 'build: add support for automated minor releases (#20620)') // merge-base

electron/spec-main/release-notes-spec.ts

Line 100 in 99c48c6

const newBreaking = new Commit('2fad53e66b1a2cb6f7dad88fe9bb62d7a461fe98', 'refactor: use v8 serialization for ipc (#20214)');

electron/spec-main/release-notes-spec.ts

Line 102 in 99c48c6

const newFix = new Commit('0600420bac25439fc2067d51c6aaa4ee11770577', "fix: don't allow window to go behind menu bar on mac (#22828)");

electron/spec-main/release-notes-spec.ts

Line 103 in 99c48c6

const oldFix = new Commit('f77bd19a70ac2d708d17ddbe4dc12745ca3a8577', 'fix: prevent menu gc during popup (#20785)');

electron/spec-main/release-notes-spec.ts

Line 106 in 99c48c6

const newTropFix = new Commit('a6ff42c190cb5caf8f3e217748e49183a951491b', 'fix: workaround for hang when preventDefault-ing nativeWindowOpen (#22750)');

electron/spec-main/release-notes-spec.ts

Line 107 in 99c48c6

const oldTropFix = new Commit('8751f485c5a6c8c78990bfd55a4350700f81f8cd', 'fix: workaround for hang when preventDefault-ing nativeWindowOpen (#22749)');

electron/spec-main/release-notes-spec.ts

Line 110 in 99c48c6

const sublist = new Commit('61dc1c88fd34a3e8fff80c80ed79d0455970e610', 'fix: client area inset calculation when maximized for framless windows (#25052) (#25216)');

electron/spec-main/release-notes-spec.ts

Line 147 in 99c48c6

const testCommit = new Commit('89eb309d0b22bd4aec058ffaf983e81e56a5c378', 'feat: lole u got troled hard (#21891)');

electron/spec/node-spec.js

Line 295 in 99c48c6

const data = 'lG9E+/g4JmRmedDAnihtBD4Dfaha/GFOjd+xUOQI05UtfVX3DjUXvrS98p7kZQwY3LNhdiFo7MY5rGft8yBuDhKuNNag9vRx/44IuClDhdQ=';

electron/spec/node-spec.js

Line 355 in 99c48c6

expect(hash.digest('hex')).to.equal('fa7fec13c624009ab126ebb99eda6525583395fe');

electron/spec/node-spec.js

Line 367 in 99c48c6

require('crypto').createCipheriv('aes-256-cfb', '0123456789abcdef0123456789abcdef', '0123456789abcdef');

electron/spec/node-spec.js

Line 375 in 99c48c6

const key = Buffer.from('0123456789abcdeff1e0d3c2b5a49786', 'hex');

electron/spec/node-spec.js

Line 376 in 99c48c6

const iv = Buffer.from('fedcba9876543210', 'hex');

electron/spec/fixtures/certificates/server.key

Line 1 in 99c48c6

-----BEGIN RSA PRIVATE KEY-----

electron/spec-main/api-session-spec.ts

Line 570 in 99c48c6

expect(await fetch(`http://test:test@127.0.0.1:${port}`)).to.equal('authenticated');

More info on how to fix Hard-Coded Secrets in General.

Insecure Use of Dangerous Function (76)

electron/build/webpack/run-compiler.js

Line 7 in 99c48c6

const config = require(configPath);

electron/npm/cli.js

Line 5 in 99c48c6

var proc = require('child_process')

electron/script/gn-check.js

Line 7 in 99c48c6

const cp = require('child_process');

electron/script/lint.js

Line 4 in 99c48c6

const childProcess = require('child_process');

electron/script/nan-spec-runner.js

Line 1 in 99c48c6

const cp = require('child_process');

electron/script/node-spec-runner.js

Line 1 in 99c48c6

const cp = require('child_process');

electron/script/release/prepare-release.js

Line 9 in 99c48c6

const { execSync } = require('child_process');

electron/script/release/publish-to-npm.js

Line 4 in 99c48c6

const childProcess = require('child_process');

electron/script/release/publish-to-npm.js

Line 64 in 99c48c6

const packageJson = require(path.join(tempDir, 'package.json'));

electron/script/release/release-artifact-cleanup.js

Line 8 in 99c48c6

const { execSync } = require('child_process');

electron/script/release/release.js

Line 15 in 99c48c6

const { execSync } = require('child_process');

electron/script/release/version-bumper.js

Line 117 in 99c48c6

const file = require(filePath);

electron/script/run-if-exists.js

Line 1 in 99c48c6

const cp = require('child_process');

electron/script/spec-runner.js

Line 3 in 99c48c6

const childProcess = require('child_process');

electron/script/start.js

Line 1 in 99c48c6

const cp = require('child_process');

electron/script/yarn.js

Line 1 in 99c48c6

const cp = require('child_process');

electron/script/yarn.js

Line 5 in 99c48c6

const YARN_VERSION = /'yarn_version': '(.+?)'/.exec(fs.readFileSync(path.resolve(__dirname, '../DEPS'), 'utf8'))[1];

electron/spec-main/fixtures/apps/crash/main.js

Line 3 in 99c48c6

const childProcess = require('child_process');

electron/spec-main/fixtures/apps/remote-control/main.js

Line 13 in 99c48c6

const result = await Promise.resolve(eval(js)); // eslint-disable-line no-eval

electron/spec/asar-spec.js

Line 2 in 99c48c6

const ChildProcess = require('child_process');

electron/spec/asar-spec.js

Line 1346 in 99c48c6

ChildProcess.exec('echo ' + echo + ' foo bar', function (error, stdout) {

electron/spec/asar-spec.js

Line 1358 in 99c48c6

return util.promisify(ChildProcess.exec)('echo ' + echo + ' foo bar').then(({ stdout }) => {

electron/spec/chromium-spec.js

Line 7 in 99c48c6

const ChildProcess = require('child_process');

electron/spec/fixtures/module/fork_ping.js

Line 7 in 99c48c6

const child = require('child_process').fork(path.join(__dirname, '/ping.js'));

electron/spec/node-spec.js

Line 1 in 99c48c6

const ChildProcess = require('child_process');

electron/spec/static/main.js

Line 70 in 99c48c6

event.returnValue = eval(script) // eslint-disable-line

electron/spec/ts-smoke/runner.js

Line 2 in 99c48c6

const childProcess = require('child_process')

electron/shell/common/platform_util_win.cc

Line 295 in 99c48c6

ShellExecute(NULL, L"open", dir.value().c_str(), NULL, NULL, SW_SHOW);

electron/vendor/third_party/lss/linux_syscall_support.h

Line 4242 in 99c48c6

LSS_INLINE int LSS_NAME(execv)(const char *path, const char *const argv[]) {

electron/build/dump_syms.py

Line 42 in 99c48c6

symbol_data = subprocess.check_output(args)

electron/build/js2c.py

Line 32 in 99c48c6

subprocess.check_call(

electron/build/npm-run.py

Line 16 in 99c48c6

subprocess.check_output(args, stderr=subprocess.STDOUT)

electron/build/run-in-dir.py

Line 7 in 99c48c6

os.execv(sys.executable, [sys.executable] + argv[2:])

electron/build/run-node.py

Line 11 in 99c48c6

subprocess.check_call(['node', script] + [str(x) for x in sys.argv[2:]])

electron/build/strip_framework.py

Line 10 in 99c48c6

subprocess.check_output(["rm", "-rf", dest])

electron/build/strip_framework.py

Line 12 in 99c48c6

subprocess.check_output(["cp", "-a", source, dest])

electron/build/strip_framework.py

Line 15 in 99c48c6

subprocess.check_output(["rm", "-r", os.path.join(dest, 'Headers')])

electron/build/strip_framework.py

Line 16 in 99c48c6

subprocess.check_output(["rm", "-r", os.path.join(dest, 'Versions', 'Current', 'Headers')])

electron/build/zip.py

Line 56 in 99c48c6

output = subprocess.check_output(argv, stderr=subprocess.STDOUT)

electron/script/dbus_mock.py

Line 27 in 99c48c6

subprocess.check_call(sys.argv[1:])

electron/script/lib/env_util.py

Line 46 in 99c48c6

proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, env=initial)

electron/script/lib/env_util.py

Line 76 in 99c48c6

proc = subprocess.Popen(

electron/script/lib/git.py

Line 63 in 99c48c6

proc = subprocess.Popen(

electron/script/lib/git.py

Line 86 in 99c48c6

return_code = subprocess.call(args)

electron/script/lib/git.py

Line 109 in 99c48c6

return subprocess.check_output(args)

electron/script/lib/git.py

Line 115 in 99c48c6

return subprocess.check_output(args).strip()

electron/script/lib/git.py

Line 121 in 99c48c6

return subprocess.check_call(args)

electron/script/lib/git.py

Line 127 in 99c48c6

subprocess.check_call(args)

electron/script/lib/git.py

Line 144 in 99c48c6

return_code = subprocess.call(args, env=env)

electron/script/lib/git.py

Line 157 in 99c48c6

return subprocess.check_output(args).strip()

electron/script/lib/git.py

Line 168 in 99c48c6

return int(subprocess.check_output(args).strip())

electron/script/lib/git.py

Line 184 in 99c48c6

return subprocess.check_output(args).rsplit('-', 2)[0:2]

electron/script/lib/git.py

Line 218 in 99c48c6

return subprocess.check_output(args)

electron/script/lib/gn.py

Line 23 in 99c48c6

return subprocess.check_output(complete_args)

electron/script/lib/native_tests.py

Line 264 in 99c48c6

returncode = subprocess.call(args, stdout=stdout, stderr=stderr)

electron/script/lib/npm.py

Line 7 in 99c48c6

subprocess.check_call(call_args)

electron/script/lib/npx.py

Line 7 in 99c48c6

subprocess.check_call(call_args)

electron/script/lib/util.py

Line 70 in 99c48c6

web_file = urlopen(url)

electron/script/lib/util.py

Line 160 in 99c48c6

output = subprocess.check_output(argv, stderr=subprocess.STDOUT,

electron/script/lib/util.py

Line 176 in 99c48c6

subprocess.check_call(argv, env=env, cwd=cwd)

electron/script/release/uploaders/upload-index-json.py

Line 31 in 99c48c6

request = urllib2.Request(

electron/script/release/uploaders/upload-index-json.py

Line 36 in 99c48c6

proposed_content = urllib2.urlopen(

electron/script/release/uploaders/upload-symbols.py

Line 49 in 99c48c6

subprocess.check_output([NPX_CMD, '@sentry/cli@1.51.1', 'difutil', 'bundle-sources', symbol_file])

electron/script/release/uploaders/upload.py

Line 163 in 99c48c6

return subprocess.check_output([electron, '--version']).strip()

electron/script/run-clang-format.py

Line 117 in 99c48c6

shell=True)

electron/script/run-clang-format.py

Line 264 in 99c48c6

popen = subprocess.Popen(

electron/script/run-clang-format.py

Line 268 in 99c48c6

shell=True

electron/script/run-gn-format.py

Line 20 in 99c48c6

subprocess.check_call(

electron/script/verify-chromedriver.py

Line 25 in 99c48c6

proc = subprocess.Popen([chromedriver_path],

electron/script/verify-ffmpeg.py

Line 53 in 99c48c6

subprocess.check_call(testargs, env=env)

electron/script/verify-mksnapshot.py

Line 30 in 99c48c6

subprocess.check_call(mkargs + [ SNAPSHOT_SOURCE ], cwd=app_path)

electron/script/verify-mksnapshot.py

Line 38 in 99c48c6

subprocess.check_call(genargs)

electron/script/verify-mksnapshot.py

Line 66 in 99c48c6

subprocess.check_call([electron, test_path])

electron/default_app/main.ts

Line 92 in 99c48c6

try {

electron/lib/asar/fs-wrapper.ts

Line 796 in 99c48c6

if (process.env.ELECTRON_EAGER_ASAR_HOOK_FOR_TESTING) {

electron/spec-main/api-crash-reporter-spec.ts

Line 552 in 99c48c6

const { app } = require('electron');

More info on how to fix Insecure Use of Dangerous Function in Javascript, C, Python and Typescript.

Insecure File Management (371)

electron/build/webpack/run-compiler.js

Line 23 in 99c48c6

let contents = fs.readFileSync(outPath, 'utf8');

electron/build/webpack/run-compiler.js

Line 42 in 99c48c6

fs.writeFileSync(outPath, contents);

electron/build/webpack/webpack.config.base.js

Line 34 in 99c48c6

const flagFile = fs.readFileSync(buildFlagPath, 'utf8');

electron/build/webpack/webpack.config.base.js

Line 76 in 99c48c6

if (!fs.existsSync(entry)) {

electron/docs/fiddles/media/screenshot/take-screenshot/renderer.js

Line 23 in 99c48c6

fs.writeFile(screenshotPath, source.thumbnail.toPNG(), (error) => {

electron/npm/index.js

Line 7 in 99c48c6

if (fs.existsSync(pathFile)) {

electron/npm/index.js

Line 8 in 99c48c6

var executablePath = fs.readFileSync(pathFile, 'utf-8')

electron/npm/install.js

Line 36 in 99c48c6

if (fs.readFileSync(path.join(__dirname, 'dist', 'version'), 'utf-8').replace(/^v/, '') !== version) {

electron/npm/install.js

Line 40 in 99c48c6

if (fs.readFileSync(path.join(__dirname, 'path.txt'), 'utf-8') !== platformPath) {

electron/npm/install.js

Line 49 in 99c48c6

return fs.existsSync(electronPath)

electron/npm/install.js

Line 58 in 99c48c6

fs.writeFile(path.join(__dirname, 'path.txt'), platformPath, err => {

electron/script/check-symlinks.js

Line 17 in 99c48c6

if (!fs.statSync(p).isDirectory()) return;

electron/script/check-symlinks.js

Line 19 in 99c48c6

for (const child of fs.readdirSync(p)) {

electron/script/check-symlinks.js

Line 23 in 99c48c6

realPath = fs.realpathSync(childPath);

electron/script/check-symlinks.js

Line 28 in 99c48c6

let link = fs.readlinkSync(childPath);

electron/script/gen-hunspell-filenames.js

Line 9 in 99c48c6

const allFiles = fs.readdirSync(dictsPath);

electron/script/gen-hunspell-filenames.js

Line 29 in 99c48c6

const currentContent = fs.readFileSync(filenamesPath, 'utf8');

electron/script/gen-hunspell-filenames.js

Line 34 in 99c48c6

fs.writeFileSync(filenamesPath, content);

electron/script/generate-deps-hash.js

Line 17 in 99c48c6

for (const child of fs.readdirSync(dir).sort()) {

electron/script/generate-deps-hash.js

Line 19 in 99c48c6

if (fs.statSync(childPath).isDirectory()) {

electron/script/generate-deps-hash.js

Line 34 in 99c48c6

hasher.update(fs.readFileSync(file));

electron/script/generate-deps-hash.js

Line 44 in 99c48c6

fs.writeFileSync(path.resolve(__dirname, '../.depshash'), hasher.digest('hex'));

electron/script/generate-deps-hash.js

Line 48 in 99c48c6

for (const argFile of fs.readdirSync(argsDir).sort()) {

electron/script/generate-deps-hash.js

Line 49 in 99c48c6

targetContent += `\n${argFile}--${crypto.createHash('SHA1').update(fs.readFileSync(path.resolve(argsDir, argFile))).digest('hex')}`;

electron/script/generate-deps-hash.js

Line 52 in 99c48c6

fs.writeFileSync(path.resolve(__dirname, '../.depshash-target'), targetContent);

electron/script/generate-version-json.js

Line 7 in 99c48c6

const currentVersion = fs.readFileSync(path.resolve(__dirname, '../ELECTRON_VERSION'), 'utf8').trim();

electron/script/generate-version-json.js

Line 22 in 99c48c6

fs.writeFileSync(outputPath, JSON.stringify({

electron/script/gn-asar.js

Line 45 in 99c48c6

fs.writeFileSync(newLocation, fs.readFileSync(file));

electron/script/lib/s3put.js

Line 28 in 99c48c6

Body: fs.createReadStream(file),

electron/script/lib/utils.js

Line 37 in 99c48c6

if (fs.existsSync(outPath)) {

electron/script/lib/utils.js

Line 47 in 99c48c6

if (fs.existsSync(outPath)) {

electron/script/lint.js

Line 137 in 99c48c6

for (const patchTarget of fs.readdirSync(patchesDir)) {

electron/script/lint.js

Line 141 in 99c48c6

if (!fs.existsSync(targetConfig)) continue;

electron/script/lint.js

Line 143 in 99c48c6

const config = JSON.parse(fs.readFileSync(targetConfig, 'utf8'));

electron/script/lint.js

Line 147 in 99c48c6

if (!fs.existsSync(targetPatchesDir)) throw new Error(`target patch directory: "${targetPatchesDir}" does not exist`);

electron/script/lint.js

Line 150 in 99c48c6

if (!fs.existsSync(dotPatchesPath)) throw new Error(`.patches file: "${dotPatchesPath}" does not exist`);

electron/script/lint.js

Line 153 in 99c48c6

const patchFileList = fs.readFileSync(dotPatchesPath, 'utf8').trim().split('\n');

electron/script/lint.js

Line 162 in 99c48c6

for (const file of fs.readdirSync(targetPatchesDir)) {

electron/script/lint.js

Line 181 in 99c48c6

const patchText = fs.readFileSync(f, 'utf8');

electron/script/lint.js

Line 255 in 99c48c6

if (!fs.existsSync(ignorePath)) continue;

electron/script/nan-spec-runner.js

Line 50 in 99c48c6

const testsToRun = fs.readdirSync(path.resolve(NAN_DIR, 'test', 'js'))

electron/script/node-spec-runner.js

Line 69 in 99c48c6

fs.mkdirSync(JUNIT_DIR);

electron/script/node-spec-runner.js

Line 71 in 99c48c6

fs.createReadStream(

electron/script/node-spec-runner.js

Line 74 in 99c48c6

fs.createWriteStream(path.resolve(JUNIT_DIR, 'nodejs.xml'))

electron/script/release/notes/notes.js

Line 239 in 99c48c6

if (fs.existsSync(filename)) {

electron/script/release/notes/notes.js

Line 240 in 99c48c6

return JSON.parse(fs.readFileSync(filename, 'utf8'));

electron/script/release/notes/notes.js

Line 245 in 99c48c6

fs.writeFileSync(filename, JSON.stringify(response));

electron/script/release/notes/notes.js

Line 394 in 99c48c6

if (!fs.existsSync(cacheDir)) {

electron/script/release/notes/notes.js

Line 395 in 99c48c6

fs.mkdirSync(cacheDir);

electron/script/release/publish-to-npm.js

Line 58 in 99c48c6

fs.writeFileSync(

electron/script/release/publish-to-npm.js

Line 60 in 99c48c6

fs.readFileSync(path.join(ELECTRON_DIR, noThirdSegment ? '' : 'npm', name))

electron/script/release/publish-to-npm.js

Line 68 in 99c48c6

fs.writeFileSync(

electron/script/release/publish-to-npm.js

Line 104 in 99c48c6

fs.writeFileSync(path.join(tempDir, 'electron.d.ts'), body);

electron/script/release/publish-to-npm.js

Line 121 in 99c48c6

const currentJson = JSON.parse(fs.readFileSync(path.join(tempDir, 'package.json'), 'utf8'));

electron/script/release/publish-to-npm.js

Line 125 in 99c48c6

fs.writeFileSync(

electron/script/release/release.js

Line 288 in 99c48c6

'content-length': fs.statSync(filePath).size

electron/script/release/release.js

Line 290 in 99c48c6

data: fs.createReadStream(filePath),

electron/script/release/release.js

Line 300 in 99c48c6

temp.open(fileName, (err, info) => {

electron/script/release/release.js

Line 305 in 99c48c6

fs.writeFileSync(info.fd, checksums);

electron/script/release/release.js

Line 458 in 99c48c6

fs.statSync(fileDirectory);

electron/script/release/release.js

Line 460 in 99c48c6

fs.mkdirSync(fileDirectory);

electron/script/release/uploaders/upload-to-github.js

Line 22 in 99c48c6

const size = fs.statSync(filePath).size;

electron/script/release/uploaders/upload-to-github.js

Line 44 in 99c48c6

data: fs.createReadStream(filePath),

electron/script/release/version-bumper.js

Line 13 in 99c48c6

const writeFile = promisify(fs.writeFile);

electron/script/release/version-bumper.js

Line 14 in 99c48c6

const readFile = promisify(fs.readFile);

electron/script/release/version-utils.js

Line 9 in 99c48c6

const readFile = promisify(fs.readFile);

electron/script/run-if-exists.js

Line 7 in 99c48c6

if (fs.existsSync(checkPath)) {

electron/script/spec-runner.js

Line 67 in 99c48c6

if (!fs.existsSync(path.resolve(__dirname, '../electron.d.ts'))) {

electron/script/spec-runner.js

Line 87 in 99c48c6

return fs.existsSync(specHashPath)

electron/script/spec-runner.js

Line 88 in 99c48c6

? fs.readFileSync(specHashPath, 'utf8').split('\n')

electron/script/spec-runner.js

Line 93 in 99c48c6

fs.writeFileSync(specHashPath, `${newSpecHash}\n${newSpecInstallHash}`);

electron/script/spec-runner.js

Line 227 in 99c48c6

if (fs.existsSync(path.resolve(dir, 'node_modules'))) {

electron/script/spec-runner.js

Line 242 in 99c48c6

for (const nodeModule of fs.readdirSync(path.resolve(dir, 'node_modules'))) {

electron/script/spec-runner.js

Line 243 in 99c48c6

if (fs.existsSync(path.resolve(dir, 'node_modules', nodeModule, 'binding.gyp'))) {

electron/script/spec-runner.js

Line 258 in 99c48c6

hasher.update(fs.readFileSync(path.resolve(__dirname, '../spec/package.json')));

electron/script/spec-runner.js

Line 259 in 99c48c6

hasher.update(fs.readFileSync(path.resolve(__dirname, '../spec-main/package.json')));

electron/script/spec-runner.js

Line 260 in 99c48c6

hasher.update(fs.readFileSync(path.resolve(__dirname, '../spec/yarn.lock')));

electron/script/spec-runner.js

Line 261 in 99c48c6

hasher.update(fs.readFileSync(path.resolve(__dirname, '../spec-main/yarn.lock')));

electron/script/spec-runner.js

Line 262 in 99c48c6

hasher.update(fs.readFileSync(path.resolve(__dirname, '../script/spec-runner.js')));

electron/script/spec-runner.js

Line 267 in 99c48c6

if (!fs.existsSync(specNodeModulesPath)) {

electron/script/yarn.js

Line 5 in 99c48c6

const YARN_VERSION = /'yarn_version': '(.+?)'/.exec(fs.readFileSync(path.resolve(__dirname, '../DEPS'), 'utf8'))[1];

electron/spec-main/fixtures/auto-update/update-json/index.js

Line 19 in 99c48c6

feedUrl = `${fs.readFileSync(urlPath, 'utf8')}/${app.getVersion()}`;

electron/spec-main/fixtures/auto-update/update-json/index.js

Line 21 in 99c48c6

fs.writeFileSync(urlPath, `${feedUrl}/updated`);

electron/spec-main/fixtures/auto-update/update/index.js

Line 19 in 99c48c6

feedUrl = `${fs.readFileSync(urlPath, 'utf8')}/${app.getVersion()}`;

electron/spec-main/fixtures/auto-update/update/index.js

Line 21 in 99c48c6

fs.writeFileSync(urlPath, `${feedUrl}/updated`);

electron/spec/api-process-spec.js

Line 97 in 99c48c6

fs.unlinkSync(filePath);

electron/spec/api-process-spec.js

Line 106 in 99c48c6

const stats = fs.statSync(filePath);

electron/spec/api-shell-spec.js

Line 47 in 99c48c6

fs.unlinkSync(tmpShortcut);

electron/spec/api-shell-spec.js

Line 52 in 99c48c6

expect(fs.existsSync(tmpShortcut)).to.be.true();

electron/spec/asar-spec.js

Line 32 in 99c48c6

expect(fs.existsSync(file)).to.be.true();

electron/spec/asar-spec.js

Line 39 in 99c48c6

fs.readFileSync(path.join(process.resourcesPath, 'default_app.asar', 'main.js'));

electron/spec/asar-spec.js

Line 46 in 99c48c6

expect(fs.readFileSync(file1).toString().trim()).to.equal('file1');

electron/spec/asar-spec.js

Line 48 in 99c48c6

expect(fs.readFileSync(file2).toString().trim()).to.equal('file2');

electron/spec/asar-spec.js

Line 50 in 99c48c6

expect(fs.readFileSync(file3).toString().trim()).to.equal('file3');

electron/spec/asar-spec.js

Line 55 in 99c48c6

const buffer = fs.readFileSync(file);

electron/spec/asar-spec.js

Line 62 in 99c48c6

expect(fs.readFileSync(p).toString().trim()).to.equal('file1');

electron/spec/asar-spec.js

Line 67 in 99c48c6

expect(fs.readFileSync(p1).toString().trim()).to.equal('file1');

electron/spec/asar-spec.js

Line 69 in 99c48c6

expect(fs.readFileSync(p2).toString().trim()).to.equal('file1');

electron/spec/asar-spec.js

Line 75 in 99c48c6

fs.readFileSync(p);

electron/spec/asar-spec.js

Line 82 in 99c48c6

fs.readFile(p, function (error) {

electron/spec/asar-spec.js

Line 91 in 99c48c6

expect(fs.readFileSync(p).toString().trim()).to.equal('a');

electron/spec/asar-spec.js

Line 96 in 99c48c6

expect(fs.readFileSync(p).toString().trim()).to.equal('file');

electron/spec/asar-spec.js

Line 103 in 99c48c6

fs.readFile(p, function (err, content) {

electron/spec/asar-spec.js

Line 116 in 99c48c6

fs.readFile(p, function (err, content) {

electron/spec/asar-spec.js

Line 129 in 99c48c6

fs.readFile(p, 'utf8', function (err, content) {

electron/spec/asar-spec.js

Line 142 in 99c48c6

fs.readFile(p, function (err, content) {

electron/spec/asar-spec.js

Line 155 in 99c48c6

fs.readFile(p, function (err, content) {

electron/spec/asar-spec.js

Line 168 in 99c48c6

fs.readFile(p, function (err) {

electron/spec/asar-spec.js

Line 182 in 99c48c6

const content = await fs.promises.readFile(p);

electron/spec/asar-spec.js

Line 188 in 99c48c6

const content = await fs.promises.readFile(p);

electron/spec/asar-spec.js

Line 194 in 99c48c6

const content = await fs.promises.readFile(p, 'utf8');

electron/spec/asar-spec.js

Line 200 in 99c48c6

const content = await fs.promises.readFile(p);

electron/spec/asar-spec.js

Line 206 in 99c48c6

const content = await fs.promises.readFile(p);

electron/spec/asar-spec.js

Line 212 in 99c48c6

await expectToThrowErrorWithCode(() => fs.promises.readFile(p), 'ENOENT');

electron/spec/asar-spec.js

Line 223 in 99c48c6

expect(fs.readFileSync(p).equals(fs.readFileSync(dest))).to.be.true();

electron/spec/asar-spec.js

Line 237 in 99c48c6

expect(fs.readFileSync(p).equals(fs.readFileSync(dest))).to.be.true();

electron/spec/asar-spec.js

Line 251 in 99c48c6

expect(fs.readFileSync(p).equals(fs.readFileSync(dest))).to.be.true();

electron/spec/asar-spec.js

Line 258 in 99c48c6

expect(fs.readFileSync(p).equals(fs.readFileSync(dest))).to.be.true();

electron/spec/asar-spec.js

Line 267 in 99c48c6

expect(fs.readFileSync(p).equals(fs.readFileSync(dest))).to.be.true();

electron/spec/asar-spec.js

Line 274 in 99c48c6

expect(fs.readFileSync(p).equals(fs.readFileSync(dest))).to.be.true();

electron/spec/asar-spec.js

Line 281 in 99c48c6

fs.lstatSync(p);

electron/spec/asar-spec.js

Line 282 in 99c48c6

fs.lstatSync(p + '/');

electron/spec/asar-spec.js

Line 287 in 99c48c6

const stats = fs.lstatSync(p);

electron/spec/asar-spec.js

Line 296 in 99c48c6

const stats = fs.lstatSync(p, { bigint: false });

electron/spec/asar-spec.js

Line 308 in 99c48c6

const stats = fs.lstatSync(p);

electron/spec/asar-spec.js

Line 321 in 99c48c6

const stats = fs.lstatSync(p);

electron/spec/asar-spec.js

Line 334 in 99c48c6

const stats = fs.lstatSync(p);

electron/spec/asar-spec.js

Line 347 in 99c48c6

const stats = fs.lstatSync(p);

electron/spec/asar-spec.js

Line 361 in 99c48c6

fs.lstatSync(p);

electron/spec/asar-spec.js

Line 370 in 99c48c6

fs.lstat(p + '/', done);

electron/spec/asar-spec.js

Line 375 in 99c48c6

fs.lstat(p, function (err, stats) {

electron/spec/asar-spec.js

Line 391 in 99c48c6

fs.lstat(p, { bigint: false }, function (err, stats) {

electron/spec/asar-spec.js

Line 407 in 99c48c6

fs.lstat(p, function (err, stats) {

electron/spec/asar-spec.js

Line 423 in 99c48c6

fs.lstat(p, function (err, stats) {

electron/spec/asar-spec.js

Line 439 in 99c48c6

fs.lstat(p, function (err, stats) {

electron/spec/asar-spec.js

Line 455 in 99c48c6

fs.lstat(p, function (err, stats) {

electron/spec/asar-spec.js

Line 471 in 99c48c6

fs.lstat(p, function (err) {

electron/spec/asar-spec.js

Line 485 in 99c48c6

await fs.promises.lstat(p + '/');

electron/spec/asar-spec.js

Line 490 in 99c48c6

const stats = await fs.promises.lstat(p);

electron/spec/asar-spec.js

Line 499 in 99c48c6

const stats = await fs.promises.lstat(p, { bigint: false });

electron/spec/asar-spec.js

Line 508 in 99c48c6

const stats = await fs.promises.lstat(p);

electron/spec/asar-spec.js

Line 517 in 99c48c6

const stats = await fs.promises.lstat(p);

electron/spec/asar-spec.js

Line 526 in 99c48c6

const stats = await fs.promises.lstat(p);

electron/spec/asar-spec.js

Line 535 in 99c48c6

const stats = await fs.promises.lstat(p);

electron/spec/asar-spec.js

Line 544 in 99c48c6

await expectToThrowErrorWithCode(() => fs.promises.lstat(p), 'ENOENT');

electron/spec/asar-spec.js

Line 550 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 552 in 99c48c6

const r = fs.realpathSync(path.join(parent, p));

electron/spec/asar-spec.js

Line 557 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 559 in 99c48c6

const r = fs.realpathSync(path.join(parent, p));

electron/spec/asar-spec.js

Line 564 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 566 in 99c48c6

const r = fs.realpathSync(path.join(parent, p));

electron/spec/asar-spec.js

Line 571 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 573 in 99c48c6

const r = fs.realpathSync(path.join(parent, p));

electron/spec/asar-spec.js

Line 578 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 580 in 99c48c6

const r = fs.realpathSync(path.join(parent, p));

electron/spec/asar-spec.js

Line 585 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 587 in 99c48c6

const r = fs.realpathSync(path.join(parent, p));

electron/spec/asar-spec.js

Line 592 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 595 in 99c48c6

fs.realpathSync(path.join(parent, p));

electron/spec/asar-spec.js

Line 654 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 656 in 99c48c6

fs.realpath(path.join(parent, p), (err, r) => {

electron/spec/asar-spec.js

Line 668 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 670 in 99c48c6

fs.realpath(path.join(parent, p), (err, r) => {

electron/spec/asar-spec.js

Line 682 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 684 in 99c48c6

fs.realpath(path.join(parent, p), (err, r) => {

electron/spec/asar-spec.js

Line 696 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 698 in 99c48c6

fs.realpath(path.join(parent, p), (err, r) => {

electron/spec/asar-spec.js

Line 710 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 712 in 99c48c6

fs.realpath(path.join(parent, p), (err, r) => {

electron/spec/asar-spec.js

Line 724 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 726 in 99c48c6

fs.realpath(path.join(parent, p), (err, r) => {

electron/spec/asar-spec.js

Line 738 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 740 in 99c48c6

fs.realpath(path.join(parent, p), err => {

electron/spec/asar-spec.js

Line 753 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 755 in 99c48c6

const r = await fs.promises.realpath(path.join(parent, p));

electron/spec/asar-spec.js

Line 760 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 762 in 99c48c6

const r = await fs.promises.realpath(path.join(parent, p));

electron/spec/asar-spec.js

Line 767 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 769 in 99c48c6

const r = await fs.promises.realpath(path.join(parent, p));

electron/spec/asar-spec.js

Line 774 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 776 in 99c48c6

const r = await fs.promises.realpath(path.join(parent, p));

electron/spec/asar-spec.js

Line 781 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 783 in 99c48c6

const r = await fs.promises.realpath(path.join(parent, p));

electron/spec/asar-spec.js

Line 788 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 790 in 99c48c6

const r = await fs.promises.realpath(path.join(parent, p));

electron/spec/asar-spec.js

Line 795 in 99c48c6

const parent = fs.realpathSync(asarDir);

electron/spec/asar-spec.js

Line 797 in 99c48c6

await expectToThrowErrorWithCode(() => fs.promises.realpath(path.join(parent, p)), 'ENOENT');

electron/spec/asar-spec.js

Line 903 in 99c48c6

const dirs = fs.readdirSync(p);

electron/spec/asar-spec.js

Line 909 in 99c48c6

const dirs = fs.readdirSync(p);

electron/spec/asar-spec.js

Line 915 in 99c48c6

const dirs = fs.readdirSync(p, { withFileTypes: true });

electron/spec/asar-spec.js

Line 925 in 99c48c6

const dirs = fs.readdirSync(p);

electron/spec/asar-spec.js

Line 932 in 99c48c6

fs.readdirSync(p);

electron/spec/asar-spec.js

Line 940 in 99c48c6

fs.readdir(p, function (err, dirs) {

electron/spec/asar-spec.js

Line 954 in 99c48c6

fs.readdir(p, { withFileTypes: true }, (err, dirs) => {

electron/spec/asar-spec.js

Line 972 in 99c48c6

fs.readdir(p, function (err, dirs) {

electron/spec/asar-spec.js

Line 985 in 99c48c6

fs.readdir(p, function (err, dirs) {

electron/spec/asar-spec.js

Line 998 in 99c48c6

fs.readdir(p, function (err) {

electron/spec/asar-spec.js

Line 1012 in 99c48c6

const dirs = await fs.promises.readdir(p);

electron/spec/asar-spec.js

Line 1018 in 99c48c6

const dirs = await fs.promises.readdir(p, { withFileTypes: true });

electron/spec/asar-spec.js

Line 1028 in 99c48c6

const dirs = await fs.promises.readdir(p);

electron/spec/asar-spec.js

Line 1034 in 99c48c6

const dirs = await fs.promises.readdir(p);

electron/spec/asar-spec.js

Line 1040 in 99c48c6

await expectToThrowErrorWithCode(() => fs.promises.readdir(p), 'ENOENT');

electron/spec/asar-spec.js

Line 1050 in 99c48c6

const fd = fs.openSync(p, 'r');

electron/spec/asar-spec.js

Line 1061 in 99c48c6

fs.openSync(p);

electron/spec/asar-spec.js

Line 1069 in 99c48c6

fs.open(p, 'r', function (err, fd) {

electron/spec/asar-spec.js

Line 1082 in 99c48c6

fs.open(p, 'r', function (err) {

electron/spec/asar-spec.js

Line 1096 in 99c48c6

const fh = await fs.promises.open(p, 'r');

electron/spec/asar-spec.js

Line 1105 in 99c48c6

await expectToThrowErrorWithCode(() => fs.promises.open(p, 'r'), 'ENOENT');

electron/spec/asar-spec.js

Line 1112 in 99c48c6

fs.mkdir(p, function (err) {

electron/spec/asar-spec.js

Line 1126 in 99c48c6

await expectToThrowErrorWithCode(() => fs.promises.mkdir(p), 'ENOTDIR');

electron/spec/asar-spec.js

Line 1134 in 99c48c6

fs.mkdirSync(p);

electron/spec/asar-spec.js

Line 1143 in 99c48c6

fs.exists(p, function (exists) {

electron/spec/asar-spec.js

Line 1156 in 99c48c6

fs.exists(p, function (exists) {

electron/spec/asar-spec.js

Line 1169 in 99c48c6

util.promisify(fs.exists)(p).then(exists => {

electron/spec/asar-spec.js

Line 1182 in 99c48c6

util.promisify(fs.exists)(p).then(exists => {

electron/spec/asar-spec.js

Line 1196 in 99c48c6

expect(fs.existsSync(p)).to.be.true();

electron/spec/asar-spec.js

Line 1201 in 99c48c6

expect(fs.existsSync(p)).to.be.false();

electron/spec/asar-spec.js

Line 1332 in 99c48c6

expect(content).to.equal(fs.readFileSync(file).toString());

electron/spec/asar-spec.js

Line 1486 in 99c48c6

fs.readFileSync(file);

electron/spec/asar-spec.js

Line 1489 in 99c48c6

fs.lstatSync(file);

electron/spec/asar-spec.js

Line 1492 in 99c48c6

fs.realpathSync(file);

electron/spec/asar-spec.js

Line 1495 in 99c48c6

fs.readdirSync(dir);

electron/spec/asar-spec.js

Line 1502 in 99c48c6

fs.readFile(file, function (error) {

electron/spec/asar-spec.js

Line 1504 in 99c48c6

fs.lstat(file, function (error) {

electron/spec/asar-spec.js

Line 1506 in 99c48c6

fs.realpath(file, function (error) {

electron/spec/asar-spec.js

Line 1508 in 99c48c6

fs.readdir(dir, function (error) {

electron/spec/asar-spec.js

Line 1520 in 99c48c6

await expect(fs.promises.readFile(file)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/asar-spec.js

Line 1521 in 99c48c6

await expect(fs.promises.lstat(file)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/asar-spec.js

Line 1522 in 99c48c6

await expect(fs.promises.realpath(file)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/asar-spec.js

Line 1523 in 99c48c6

await expect(fs.promises.readdir(dir)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/asar-spec.js

Line 1529 in 99c48c6

const content1 = fs.readFileSync(asar);

electron/spec/asar-spec.js

Line 1530 in 99c48c6

const content2 = originalFs.readFileSync(asar);

electron/spec/asar-spec.js

Line 1533 in 99c48c6

fs.readdirSync(asar);

electron/spec/asar-spec.js

Line 1666 in 99c48c6

const stats = originalFs.statSync(file);

electron/spec/asar-spec.js

Line 1679 in 99c48c6

originalFs.createReadStream(path.join(asarDir, 'a.asar'));

electron/spec/asar-spec.js

Line 1685 in 99c48c6

originalFs.rmdirSync(deleteDir, { recursive: true });

electron/spec/asar-spec.js

Line 1687 in 99c48c6

expect(fs.existsSync(deleteDir)).to.be.false();

electron/spec/asar-spec.js

Line 1701 in 99c48c6

expect(gfs.readFileSync(p).toString().trim()).to.equal('file1');

electron/spec/asar-spec.js

Line 1704 in 99c48c6

expect(fs.readdir).to.not.equal(gfs.readdir);

electron/spec/chromium-spec.js

Line 61 in 99c48c6

const b = window.open(`file://${fixtures}/pages/window-opener-node.html`, '', 'nodeIntegration=no,show=no');

electron/spec/chromium-spec.js

Line 69 in 99c48c6

const b = window.open(`file://${fixtures}/pages/window-open-size.html`, '', 'show=no');

electron/spec/chromium-spec.js

Line 87 in 99c48c6

const b = window.open(windowUrl, '', 'nodeIntegration=no,show=no');

electron/spec/chromium-spec.js

Line 103 in 99c48c6

const b = window.open(windowUrl, '', 'webviewTag=no,nodeIntegration=yes,show=no');

electron/spec/chromium-spec.js

Line 115 in 99c48c6

const b = window.open(`file://${fixtures}/pages/window-open-size.html`, '', 'show=no,width=' + size.width + ',height=' + size.height);

electron/spec/chromium-spec.js

Line 143 in 99c48c6

const b = window.open(`file://${fixtures}/pages/window-opener.html`, '', 'show=no');

electron/spec/chromium-spec.js

Line 163 in 99c48c6

const b = window.open(`file://${fixtures}/pages/window-opener-postMessage.html`, '', 'show=no');

electron/spec/chromium-spec.js

Line 199 in 99c48c6

res.end(fs.readFileSync(filePath, 'utf8'));

electron/spec/chromium-spec.js

Line 213 in 99c48c6

const b = window.open(serverURL, '', 'show=no');

electron/spec/fixtures/module/asar.js

Line 3 in 99c48c6

process.send(fs.readFileSync(file).toString());

electron/spec/fixtures/module/no-asar.js

Line 4 in 99c48c6

const stats = fs.statSync(path.join(__dirname, '..', 'test.asar', 'a.asar'));

electron/spec/node-spec.js

Line 149 in 99c48c6

fs.readFile(__filename, () => {

electron/spec/node-spec.js

Line 171 in 99c48c6

fs.readFile(__filename, () => {

electron/spec/node-spec.js

Line 181 in 99c48c6

fs.createReadStream(url);

electron/spec/static/main.js

Line 8 in 99c48c6

require('fs').rmdirSync(app.getPath('userData'), { recursive: true });

electron/spec/static/main.js

Line 58 in 99c48c6

fs.appendFileSync(outputToFile, output + '\n');

electron/spec/static/main.js

Line 160 in 99c48c6

fs.readFile(__filename, () => {

electron/spec/static/main.js

Line 169 in 99c48c6

fs.readFile(__filename, () => {

electron/vendor/third_party/lss/linux_syscall_support.h

Line 3458 in 99c48c6

LSS_INLINE _syscall3(int, readlink, const char*, p,

electron/vendor/third_party/lss/linux_syscall_support.h

Line 4427 in 99c48c6

LSS_INLINE int LSS_NAME(readlink)(const char *pathname, char *buffer,

electron/default_app/main.ts

Line 89 in 99c48c6

let appPath;

electron/lib/asar/fs-wrapper.ts

Line 225 in 99c48c6

const logPath = path.join(require('os').tmpdir(), logFilename);

electron/lib/asar/fs-wrapper.ts

Line 273 in 99c48c6


electron/lib/asar/fs-wrapper.ts

Line 281 in 99c48c6

// Do not distinguish links for now.

electron/lib/asar/fs-wrapper.ts

Line 294 in 99c48c6

// Do not distinguish links for now.

electron/lib/asar/fs-wrapper.ts

Line 297 in 99c48c6


electron/lib/asar/fs-wrapper.ts

Line 528 in 99c48c6

const realPath = archive.copyFileOut(filePath);

electron/lib/asar/fs-wrapper.ts

Line 543 in 99c48c6


electron/lib/asar/fs-wrapper.ts

Line 560 in 99c48c6

const realPath = archive.copyFileOut(filePath);

electron/lib/asar/fs-wrapper.ts

Line 635 in 99c48c6


electron/lib/asar/fs-wrapper.ts

Line 688 in 99c48c6

const realPath = archive.copyFileOut(filePath);

electron/lib/asar/fs-wrapper.ts

Line 743 in 99c48c6


electron/lib/browser/api/app.ts

Line 93 in 99c48c6

try {

electron/lib/browser/init.ts

Line 86 in 99c48c6


electron/script/codesign/gen-trust.ts

Line 8 in 99c48c6


electron/script/codesign/gen-trust.ts

Line 35 in 99c48c6


electron/script/gen-filenames.ts

Line 8 in 99c48c6


electron/script/gen-filenames.ts

Line 11 in 99c48c6

.concat(

electron/script/gen-filenames.ts

Line 15 in 99c48c6


electron/script/gen-filenames.ts

Line 88 in 99c48c6


electron/spec-main/api-app-spec.ts

Line 39 in 99c48c6

const options = {

electron/spec-main/api-app-spec.ts

Line 40 in 99c48c6

key: fs.readFileSync(path.join(certPath, 'server.key')),

electron/spec-main/api-app-spec.ts

Line 42 in 99c48c6

ca: [

electron/spec-main/api-app-spec.ts

Line 43 in 99c48c6

fs.readFileSync(path.join(certPath, 'rootCA.pem')),

electron/spec-main/api-app-spec.ts

Line 258 in 99c48c6

beforeEach(done => {

electron/spec-main/api-app-spec.ts

Line 270 in 99c48c6

} else {

electron/spec-main/api-app-spec.ts

Line 825 in 99c48c6

const paths = [

electron/spec-main/api-app-spec.ts

Line 826 in 99c48c6

fs.existsSync(app.getPath('exe')),

electron/spec-main/api-app-spec.ts

Line 827 in 99c48c6

fs.existsSync(app.getPath('home')),

electron/spec-main/api-app-spec.ts

Line 872 in 99c48c6


electron/spec-main/api-app-spec.ts

Line 874 in 99c48c6

app.setPath('music', badPath);

electron/spec-main/api-app-spec.ts

Line 1299 in 99c48c6

}

electron/spec-main/api-app-spec.ts

Line 1313 in 99c48c6

} else {

electron/spec-main/api-autoupdater-darwin-spec.ts

Line 47 in 99c48c6

const plistPath = path.resolve(newPath, 'Contents', 'Info.plist');

electron/spec-main/api-autoupdater-darwin-spec.ts

Line 49 in 99c48c6

plistPath,

electron/spec-main/api-autoupdater-darwin-spec.ts

Line 125 in 99c48c6

const appPJPath = path.resolve(secondAppPath, 'Contents', 'Resources', 'app', 'package.json');

electron/spec-main/api-autoupdater-darwin-spec.ts

Line 127 in 99c48c6

appPJPath,

electron/spec-main/api-browser-window-spec.ts

Line 101 in 99c48c6

const test = path.join(fixtures, 'api', 'unload');

electron/spec-main/api-browser-window-spec.ts

Line 102 in 99c48c6

const content = fs.readFileSync(test);

electron/spec-main/api-browser-window-spec.ts

Line 186 in 99c48c6

const test = path.join(fixtures, 'api', 'close');

electron/spec-main/api-browser-window-spec.ts

Line 187 in 99c48c6

const content = fs.readFileSync(test).toString();

electron/spec-main/api-browser-window-spec.ts

Line 262 in 99c48c6

const filePath = path.join(fixtures, 'pages', 'a.html');

electron/spec-main/api-browser-window-spec.ts

Line 285 in 99c48c6

const parsedData = qs.parse(body);

electron/spec-main/api-browser-window-spec.ts

Line 2637 in 99c48c6

mimeType: 'text/html',

electron/spec-main/api-browser-window-spec.ts

Line 3165 in 99c48c6

try {

electron/spec-main/api-browser-window-spec.ts

Line 3166 in 99c48c6

fs.unlinkSync(savePageCssPath);

electron/spec-main/api-browser-window-spec.ts

Line 3167 in 99c48c6

fs.unlinkSync(savePageJsPath);

electron/spec-main/api-browser-window-spec.ts

Line 3168 in 99c48c6

fs.unlinkSync(savePageHtmlPath);

electron/spec-main/api-browser-window-spec.ts

Line 3169 in 99c48c6

fs.rmdirSync(path.join(savePageDir, 'save_page_files'));

electron/spec-main/api-browser-window-spec.ts

Line 3181 in 99c48c6


electron/spec-main/api-browser-window-spec.ts

Line 3182 in 99c48c6

expect(fs.existsSync(savePageHtmlPath)).to.be.true('html path');

electron/spec-main/api-browser-window-spec.ts

Line 3183 in 99c48c6

expect(fs.existsSync(savePageJsPath)).to.be.true('js path');

electron/spec-main/api-content-tracing-spec.ts

Line 20 in 99c48c6

beforeEach(() => {

electron/spec-main/api-content-tracing-spec.ts

Line 21 in 99c48c6

if (fs.existsSync(outputFilePath)) {

electron/spec-main/api-content-tracing-spec.ts

Line 29 in 99c48c6

const getFileSizeInKiloBytes = (filePath: string) => {

electron/spec-main/api-content-tracing-spec.ts

Line 39 in 99c48c6


electron/spec-main/api-content-tracing-spec.ts

Line 54 in 99c48c6


electron/spec-main/api-content-tracing-spec.ts

Line 77 in 99c48c6


electron/spec-main/api-content-tracing-spec.ts

Line 104 in 99c48c6

expect(path).to.be.a('string').that.is.not.empty('result path');

electron/spec-main/api-content-tracing-spec.ts

Line 143 in 99c48c6

const path = await contentTracing.stopRecording();

electron/spec-main/api-context-bridge-spec.ts

Line 73 in 99c48c6

dir = tmpDir;

electron/spec-main/api-crash-reporter-spec.ts

Line 121 in 99c48c6

try {

electron/spec-main/api-crash-reporter-spec.ts

Line 396 in 99c48c6

try {

electron/spec-main/api-crash-reporter-spec.ts

Line 397 in 99c48c6

fs.rmdirSync(dir, { recursive: true });

electron/spec-main/api-net-log-spec.ts

Line 54 in 99c48c6

try {

electron/spec-main/api-net-log-spec.ts

Line 55 in 99c48c6

if (fs.existsSync(dumpFile)) {

electron/spec-main/api-net-log-spec.ts

Line 57 in 99c48c6

}

electron/spec-main/api-net-log-spec.ts

Line 58 in 99c48c6

if (fs.existsSync(dumpFileDynamic)) {

electron/spec-main/api-net-log-spec.ts

Line 73 in 99c48c6


electron/spec-main/api-net-log-spec.ts

Line 101 in 99c48c6

await testNetLog().stopLogging();

electron/spec-main/api-net-log-spec.ts

Line 102 in 99c48c6

expect(fs.existsSync(dumpFileDynamic)).to.be.true('dump file exists');

electron/spec-main/api-net-log-spec.ts

Line 118 in 99c48c6

await testNetLog().stopLogging();

electron/spec-main/api-net-log-spec.ts

Line 119 in 99c48c6

expect(fs.existsSync(dumpFileDynamic)).to.be.true('dump file exists');

electron/spec-main/api-net-log-spec.ts

Line 133 in 99c48c6

await emittedOnce(appProcess, 'exit');

electron/spec-main/api-net-log-spec.ts

Line 148 in 99c48c6

await emittedOnce(appProcess, 'exit');

electron/spec-main/api-net-log-spec.ts

Line 149 in 99c48c6

expect(fs.existsSync(dumpFile)).to.be.true('dump file exists');

electron/spec-main/api-net-log-spec.ts

Line 162 in 99c48c6

await emittedOnce(appProcess, 'exit');

electron/spec-main/api-protocol-spec.ts

Line 195 in 99c48c6

const filePath = path.join(fixturesPath, 'test.asar', 'a.asar', 'file1');

electron/spec-main/api-protocol-spec.ts

Line 197 in 99c48c6

const normalPath = path.join(fixturesPath, 'pages', 'a.html');

electron/spec-main/api-protocol-spec.ts

Line 932 in 99c48c6

if (request.url.includes('/video.webm')) {

electron/spec-main/api-protocol-spec.ts

Line 946 in 99c48c6

};

electron/spec-main/api-protocol-spec.ts

Line 954 in 99c48c6

},

electron/spec-main/api-protocol-spec.ts

Line 958 in 99c48c6

} else {

electron/spec-main/api-service-workers-spec.ts

Line 30 in 99c48c6

}

electron/spec-main/api-session-spec.ts

Line 455 in 99c48c6

const options = {

electron/spec-main/api-session-spec.ts

Line 456 in 99c48c6

key: fs.readFileSync(path.join(certPath, 'server.key')),

electron/spec-main/api-session-spec.ts

Line 458 in 99c48c6

ca: [

electron/spec-main/api-session-spec.ts

Line 459 in 99c48c6

fs.readFileSync(path.join(certPath, 'rootCA.pem')),

electron/spec-main/api-session-spec.ts

Line 619 in 99c48c6

expect(item.getContentDisposition()).to.equal(contentDisposition);

electron/spec-main/api-session-spec.ts

Line 620 in 99c48c6

expect(fs.existsSync(downloadFilePath)).to.equal(true);

electron/spec-main/api-session-spec.ts

Line 885 in 99c48c6

expect(completedItem.getTotalBytes()).to.equal(14022);

electron/spec-main/api-shell-spec.ts

Line 69 in 99c48c6

const filename = path.join(dir, 'temp-to-be-deleted');

electron/spec-main/api-shell-spec.ts

Line 72 in 99c48c6

expect(result).to.be.true();

electron/spec-main/api-shell-spec.ts

Line 84 in 99c48c6

const tempPath = path.join(dir, 'locked-file');

electron/spec-main/api-shell-spec.ts

Line 119 in 99c48c6

const filename = path.join(dir, 'temp-to-be-deleted');

electron/spec-main/api-shell-spec.ts

Line 121 in 99c48c6

await shell.trashItem(filename);

electron/spec-main/api-web-contents-spec.ts

Line 1579 in 99c48c6

try {

electron/spec-main/api-web-contents-spec.ts

Line 1587 in 99c48c6

await w.webContents.takeHeapSnapshot(filePath);

electron/spec-main/chromium-spec.ts

Line 31 in 99c48c6

const options = {

electron/spec-main/chromium-spec.ts

Line 32 in 99c48c6

key: fs.readFileSync(path.join(certPath, 'server.key')),

electron/spec-main/chromium-spec.ts

Line 34 in 99c48c6

ca: [

electron/spec-main/chromium-spec.ts

Line 35 in 99c48c6

fs.readFileSync(path.join(certPath, 'rootCA.pem')),

electron/spec-main/chromium-spec.ts

Line 452 in 99c48c6


electron/spec-main/chromium-spec.ts

Line 1384 in 99c48c6

describe('iframe using HTML fullscreen API while window is OS-fullscreened', () => {

electron/spec-main/crash-spec.ts

Line 40 in 99c48c6

});

electron/spec-main/crash-spec.ts

Line 47 in 99c48c6

const args = [fixture];

electron/spec-main/crash-spec.ts

Line 48 in 99c48c6

if (fs.existsSync(argsFile)) {

electron/spec-main/extensions-spec.ts

Line 96 in 99c48c6

const extensionPath = path.join(fixtures, 'extensions', 'red-bg');

electron/spec-main/modules-spec.ts

Line 37 in 99c48c6

const fixture = path.join(fixtures, 'module', 'echo-renamed.js');

electron/spec-main/modules-spec.ts

Line 41 in 99c48c6

} finally {

electron/spec-main/security-warnings-spec.ts

Line 32 in 99c48c6


electron/spec-main/security-warnings-spec.ts

Line 43 in 99c48c6

More info on how to fix Insecure File Management in Javascript, C and Typescript.

Insecure Use of Regular Expressions (13)

electron/script/release/notes/notes.js

Line 384 in 99c48c6

.match(/(?:.*\/)?(.*)/)[1] // 'remote/origins/10-x-y' -> '10-x-y'

electron/script/release/prepare-release.js

Line 186 in 99c48c6

const lastCommitWasRelease = new RegExp('^Bump v[0-9.]*(-beta[0-9.]*)?(-nightly[0-9.]*)?$', 'g');

electron/spec-main/index.js

Line 95 in 99c48c6

? new RegExp(process.env.npm_config_match, 'g')

electron/spec/asar-spec.js

Line 1487 in 99c48c6

}).to.throw(new RegExp(errorName));

electron/spec/asar-spec.js

Line 1490 in 99c48c6

}).to.throw(new RegExp(errorName));

electron/spec/asar-spec.js

Line 1493 in 99c48c6

}).to.throw(new RegExp(errorName));

electron/spec/asar-spec.js

Line 1496 in 99c48c6

}).to.throw(new RegExp(errorName));

electron/spec/asar-spec.js

Line 1520 in 99c48c6

await expect(fs.promises.readFile(file)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/asar-spec.js

Line 1521 in 99c48c6

await expect(fs.promises.lstat(file)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/asar-spec.js

Line 1522 in 99c48c6

await expect(fs.promises.realpath(file)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/asar-spec.js

Line 1523 in 99c48c6

await expect(fs.promises.readdir(dir)).to.be.eventually.rejectedWith(Error, new RegExp(errorName));

electron/spec/node-spec.js

Line 101 in 99c48c6

.and.matches(/^\d+\.\d+\.\d+(\S*)?$/);

electron/spec/node-spec.js

Line 407 in 99c48c6

.and.matches(/^\d+\.\d+\.\d+(\S*)?$/);

More info on how to fix Insecure Use of Regular Expressions in Javascript.

Vulnerable Libraries (1)
Insecure Processing of Data (69)
Insecure Access Control (10)
Insecure Use of Language/Framework API (11)
Insecure Use of Crypto (2)

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@kadirselcuk kadirselcuk merged commit 577d567 into master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kadirselcuk kadirselcuk

Labels
⤵️ pull bug Something isn't working build chai coffeescript definitions dependencies Pull requests that update a dependency file depfu documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request env express extra fs good first issue Good for newcomers guide help wanted Extra attention is needed import invalid This doesn't seem right loader Mend: dependency security vulnerability Security vulnerability detected by WhiteSource merge-conflict Resolve conflicts manually Mergify mkdirp octicons parser plugin question Further information is requested reporter reporters rest sdk security fix Security fix generated by WhiteSource semver shx staged standard temp typescript uuid webpack wontfix This will not be worked on yargs
Projects
None yet
Milestone
No milestone
0 participants