-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue where service stop
does not work in linux
systems. Closes #653
#654
Conversation
db/stop_database.go
Outdated
|
||
if !exitSuccessful { | ||
log.Printf("[ERROR] ** > Failed to stop service\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want all this logging in production code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be at TRACE instead? so we can enable it as required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code should never be executed . If it comes here, then we will get this as a BIG RED FLAG!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the same, I don't think we want a wall of ERROR lines - we could print a single error line, and then format the remaining information in to an error report which is printed underneath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
When the service fails to stop, the following log is printed out:
|
…y return data instead of an empty row (turbot#654)
No description provided.