Fixes issue where refresh connections was not running when service was already running. Closes #3734 #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidaguerre
requested changes
Aug 10, 2023
| @@ -324,8 +324,8 @@ jobs: | |||
| - "blank_aggregators" | |||
| - "search_path" | |||
| - "chaos_and_query" | |||
| - "dynamic_schema" | |||
| - "dynamic_aggregators" | |||
| # - "dynamic_schema" | |||
There was a problem hiding this comment.
rather than comment them out, please skip the tests with a reason and a link to the issue
kaidaguerre
requested changes
Aug 10, 2023
| # Aggregating two connections with same table and same columns defined. | ||
| @test "dynamic aggregator - same table and columns" { | ||
| skip "re-design without STEAMPIPE_SYNC_REFRESH" |
There was a problem hiding this comment.
comment should read currently does not pass due to bug: <link to issue>
kaidaguerre
deleted the
3734-refresh-connections-do-not-happen-when-service-is-already-running
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.