Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small suggested updates to the steampipe service * output #812

Closed
e-gineer opened this issue Aug 27, 2021 · 3 comments · Fixed by #826
Closed

Small suggested updates to the steampipe service * output #812

e-gineer opened this issue Aug 27, 2021 · 3 comments · Fixed by #826
Assignees

Comments

@e-gineer
Copy link
Contributor

For steampipe service here is the sequence of output I see:

~/src/steampipe-plugin-fastly $ steampipe service start

Steampipe database service is now running:

	Host(s):  localhost, 127.0.0.1, 192.168.7.220
	Port:     9193
	Database: steampipe
	User:     steampipe
	Password: 0068-XXXX-XXXX
	SSL:      on

Connection string:

	postgres://steampipe:0068-XXXX-XXXX@localhost:9193/steampipe?sslmode=require

Managing Steampipe service:

	# Get status of the service
	steampipe service status
	
	# Restart the service
	steampipe service restart

	# Stop the service
	steampipe service stop
	

~/src/steampipe-plugin-fastly $ 
~/src/steampipe-plugin-fastly $ steampipe service stop
Steampipe database service stopped
~/src/steampipe-plugin-fastly $ steampipe service status
Steampipe database service is NOT running
~/src/steampipe-plugin-fastly $ 

Suggestions:

  • Use two spaces instead of tabs to indent the text.
  • Remove ?sslmode=require, it's preferred anyway and we don't technically require it.
  • Remove SSL: on line, we provide no way to disable it anyway.
  • Double line gap at the end should be a single line gap only.
  • Managing Steampipe service: should be Managing the Steampipe service:
  • References to database service should just be service (simpler)
  • Steampipe database service stopped message should be Steampipe service stopped [port 9193].
  • Steampipe database service is NOT running message should be Steampipe service is not running [port 9193].
@binaek
Copy link
Contributor

binaek commented Sep 1, 2021

@e-gineer

on the last point:

  • Steampipe database service is NOT running message should be Steampipe service is not running [port 9193].

This message comes up when there's no service running. We do not have a statefile here.

Should we put in the default port here?

@e-gineer
Copy link
Contributor Author

@binaek89 I think when running steampipe service status we should know which port we'd expect it to be on? (We must since we can do steampipe service start.) So we can just use that? Is that the default port you mention?

@binaek
Copy link
Contributor

binaek commented Sep 15, 2021

@e-gineer we know of the port that the service is running on when it is running, but when it's not, and we say that the service is not running, should we mention the default port?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants