Interactive console becomes unresponsive after ";" query

[aidansteele]

Description: When I enter a line of only a semicolon into the interactive query console, it becomes unresponsive. Ctrl+C and Ctrl+D no longer work. The only option is to Ctrl+Z and then manually SIGKILL the steampipe and postgres processes.

Potential cause:

This code is executed when a query is only the semicolon character:

steampipe/interactive/interactive_client.go

Lines 411 to 415 in b7aa42c

	// if the line is ONLY a semicolon, do nothing and restart interactive session
	if strings.TrimSpace(query) == ";" {
	c.restartInteractiveSession()
	return "", nil
	}

It appears to shortcircuit the typical query execution path, so the main REPL hangs here forever:

steampipe/interactive/interactive_client.go

Lines 121 to 123 in b7aa42c

	// wait for the resultsStreamer to have streamed everything out
	// this is to be sure the previous command has completed streaming
	c.resultsStreamer.Wait()

A workaround: Elsewhere in the file there is a workaround to return control back to the main REPL. Pasting this workaround (c.resultsStreamer.Done()) in the first code excerpt does appear to "fix" this bug:

steampipe/interactive/interactive_client.go

Lines 153 to 155 in b7aa42c

	// HACK mark result streamer as done so we do not wait for it before restarting prompt
	// TODO would be better if result stream checked if it was started
	c.resultsStreamer.Done()

Discussion: To be honest, I'm not 100% sure what the purpose of the "do nothing and restart interactive session" functionality is - so I can't submit a PR that I'm confident is the correct way to fix this. Hope this bug report helps nonetheless.

[binaek]

@aidansteele Thank you for the detailed information on the issue. This will be a great help when debugging the issue

We recently did a major refactor of the interactive prompt.

This must have crept in then.

We will take a look into this and publish a fix.

[kaidaguerre]

@aidansteele many thanks for digging into this issue. I have released a fix in version Steampipe version 0.7.1

As @binaek89 mentioned, we have been overhauling the interactive prompt and there is a little more rationalisation still required.

The fix you identified is the good tactical solution and that is essentially what I have implemented for now. Medium term, I will be looking at simplifying the result streamer to remove underlying issue.