Enable strict null checking #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: after merging the latest changes from master, this generates one more interesting error, that shows a possible null return that I think is worth review/discussion. I don't understand from the comments if null is an expected return type for this function. |
|
I'm leaving the interesting errors in place for discussion. They do not block code generation or test success. |
|
Hmm, perhaps because I merged out-of-order, but right now this generates two implicit any errors: My last checkin fixed these. |
sharwell
reviewed
Oct 9, 2016
| @@ -125,7 +125,10 @@ class IterableAdapter<T> implements Iterable<T>, IterableIterator<T> { | |||
| [Symbol.iterator]() { this._iterator = this.collection.iterator(); return this;} | |||
|
|
|||
| next(): IteratorResult<T> { | |||
| if (!this._iterator.hasNext()) return { done: true, value: undefined }; | |||
| if (!this._iterator.hasNext()) { | |||
| // A bit of a hack needed here, tracking under https://github.com/Microsoft/TypeScript/issues/11375 | |||
This was referenced Oct 10, 2016
|
I think you said you'd handle this. P.S. Perhaps we should eliminate the |
Note this version generates some errors, all of which seem valid to me. If we adopt this, it seems like it could replace the @NotNull decorator.
sharwell
added a commit
that referenced
this pull request
Oct 10, 2016
This change is based on work originally completed by @BurtHarris in #26.
sharwell
added a commit
that referenced
this pull request
Oct 10, 2016
This work is based on changes by @BurtHarris in #26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14. I think you'll like this Sam.
Note this version generates some errors (of the form
error TS2531: Object is possibly 'null') all of which seem valid to me. If we adopt this, it seems like it could replace the@NotNulldecorator. (All errors are non-fatal, the tests still run.)Seems like if we want to use this, the sooner the better.