Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell hooks env vars #128

Merged
merged 2 commits into from
Apr 10, 2024
Merged

shell hooks env vars #128

merged 2 commits into from
Apr 10, 2024

Conversation

MarkoMin
Copy link
Contributor

Described what variables are available in the hooks.
Described that shell_hooks_env exist.

dont merge before erlang/rebar3#2872 gets merged

Closes erlang/rebar3#2847

@MarkoMin
Copy link
Contributor Author

REBAR_APP_DIRS and REBAR_SRC_DIRS will change behavior if erlang/rebar3#2872 gets merged, but they weren't documented before therefore I don't consider this a backward incompatibility. Should we have a notice like "this behavior is from v 3.23.0"?

@ferd
Copy link
Collaborator

ferd commented Mar 25, 2024

Yeah I think it would make sense to mention "starting with v3.23.0, the variables are documented as supporting the following:..."

ferd
ferd approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be merged when the other PR goes in.

@ferd ferd merged commit 4ff4210 into tsloughter:master Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hooks env variables documentation
2 participants
@MarkoMin @ferd