Fix: #343 - LLamaSharpEmbeddings Exception: EmbeddingMode must be true

[SrNandu]

Fixes #343

Fixed by passing the EmbeddingMode configuration from LlamaSharpConfiguration to the ModelParams. Also this propery is setted true in the FromPath() static method, otherwise this method will crash too.

Summary by CodeRabbit

• New Features
  • Introduced a new EmbeddingMode property to enhance the configuration of embeddings.
  • Added initialization and assignment for the EmbeddingMode property, allowing users to set embedding modes more flexibly.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

The LLamaSharpEmbeddings.cs file was updated to reorder import statements and introduce a new property EmbeddingMode in the LLamaSharpConfiguration class. This property is now initialized in the FromPath method and utilized in the constructor to prevent an exception.

Changes

File Path	Change Summary
src/Providers/LLamaSharp/src/LLamaSharpEmbeddings.cs	Reordered using statements, added EmbeddingMode to LLamaSharpConfiguration, initialized it in FromPath method, and utilized it in constructor.

Sequence Diagram(s)

The changes are too straightforward and varied to be encapsulated in a single sequence diagram. Therefore, no sequence diagram is provided.

Assessment against linked issues

Objective	Addressed	Explanation
EmbeddingMode must be true when creating LLamaSharpEmbeddings (#343)	✅

In fields of code, the rabbit roves,
EmbeddingMode where logic hoves.
With imports set and paths defined,
The Llama's course is now refined.
Debugging trails we deftly close,
In binary poems, our joy arose.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6c84131 and b9c62d2.

Files selected for processing (1)

• src/Providers/LLamaSharp/src/LLamaSharpEmbeddings.cs (3 hunks)

Additional comments not posted (2)

src/Providers/LLamaSharp/src/LLamaSharpEmbeddings.cs (2)

26-27: The addition of EmbeddingMode = true in the FromPath method correctly aligns with the PR objective to ensure the model operates in embedding mode, thus preventing the previously reported exception.

---

47-47: The assignment of Embeddings = configuration.EmbeddingMode in the constructor ensures that the EmbeddingMode setting is correctly propagated to the model parameters, aligning with the PR objectives to fix the embedding mode exception.

[HavenDV]

Thank you very much for your contribution. Please write me your name in discord if you want and I will add you to the list of contrubutors and dev channel discussing development and immediate plans
You can join using https://discord.gg/Ca2xhfBf3v