-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of MongoDBAtlasVectorCollection #280
Conversation
WalkthroughThe update involves the creation of the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@ceejeeb Thanks a lot for the PR, please check my suggested fixes and accept it if it makes sense |
: VectorCollection(name, id), IVectorCollection | ||
{ | ||
protected IMongoContext MongoContext { get; } = mongoContext; | ||
protected IMongoCollection<Vector> mongoCollection => MongoContext.GetCollection<Vector>(Name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider caching the
mongoCollection
to avoid repeated database calls.
Comment from a bot, but perhaps it’s worth moving IMongoCollection to the constructor? And the Database implementation will contain the IMongoContext itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have assigned the collection into a private member at time of constructor. Also remove the handle to the MongoContext as it is no longer need once constructed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Co-authored-by: Konstantin S. <havendv@gmail.com>
Co-authored-by: Konstantin S. <havendv@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
|
Thank you very much for your contribution. Please write me your name in discord if you want and I will add you to the list of contrubutors and dev channel discussing development and immediate plans |
You are welcome. I hope I can contribute more. |
Please join https://discord.gg/Ca2xhfBf3v |
Summary by CodeRabbit