Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added Amazon Bedrock models #264

Merged
merged 1 commit into from
Apr 28, 2024
Merged

feat: added Amazon Bedrock models #264

merged 1 commit into from
Apr 28, 2024

Conversation

curlyfro
Copy link
Contributor

@curlyfro curlyfro commented Apr 28, 2024 •
edited by coderabbitai bot
Loading

added Claude3 Opus
added Llama3 8B Instruct
added Llama3 70B Instruct
added Mistral Large
fixed default tokens

Summary by CodeRabbit

  • New Features
    • Introduced new AI models in the Anthropic and Meta namespaces with updated identifiers.
  • Refactor
    • Updated class names and inheritance structures for better alignment and clarity in the Amazon Bedrock provider namespace.
  • Chores
    • Adjusted the maximum token limits across various chat settings to standardize interaction capabilities.

@curlyfro
feat: added Amazon Bedrock models
d46f74d 
added Claude3 Opus
added Llama3 8B Instruct
added Llama3 70B Instruct
added Mistral Large
fixed default tokens
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 28, 2024 •
edited
Loading

Walkthrough

This update encompasses a series of class renamings and inheritance adjustments across various models in the Amazon Bedrock provider. Additionally, there are significant reductions in the MaxTokens settings for multiple chat settings classes, aligning them to a new standard of 4000 tokens. New classes have also been introduced, expanding the functionality and specificity of the provider's offerings.

Changes

File Path Change Summary
.../MetaLlamaChatModel.cs Renamed MetaLlama2ChatModel to MetaLlamaChatModel.
.../MistralModel.cs Renamed MistralInstructChatModel to MistralModel.
.../Chat/Settings/...ChatSettings.cs Standardized MaxTokens to 4000 across various settings classes.
.../Predefined/Anthropic.cs Added Claude3OpusModel, updated inheritance details.
.../Predefined/Meta.cs Added new models, updated IDs, and changed inheritance for existing models.
.../Predefined/Mistral.cs Renamed classes, updated their inheritance to MistralModel.

🐰✨
Changes abound, code does hop,
From fields so green, to mountain top.
MaxTokens fall, like autumn leaves,
New classes spring, as nature weaves.
Oh, merry code, dance your new beat,
With every line, a feat complete! 🌟
🐰💻

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8cc02eb and d46f74d.
Files selected for processing (10)
  • src/Providers/Amazon.Bedrock/src/Chat/MetaLlamaChatModel.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Chat/MistralModel.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/Ai21LabsJurassic2ChatSettings.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/AmazonTitanChatSettings.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/AnthropicChatSettings.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/MetaLlama2ChatSettings.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/MistralInstructChatSettings.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Predefined/Anthropic.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Predefined/Meta.cs (1 hunks)
  • src/Providers/Amazon.Bedrock/src/Predefined/Mistral.cs (1 hunks)
Files skipped from review due to trivial changes (3)
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/AmazonTitanChatSettings.cs
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/AnthropicChatSettings.cs
  • src/Providers/Amazon.Bedrock/src/Chat/Settings/MetaLlama2ChatSettings.cs
Additional comments not posted (13)
src/Providers/Amazon.Bedrock/src/Predefined/Mistral.cs (2)

6-6: Ensure the identifier for Mistral7BInstruct is consistent with other model naming conventions.

10-10: The identifier for Mistral8x7BInstruct seems appropriate. Confirm that the versioning is correct.

src/Providers/Amazon.Bedrock/src/Predefined/Meta.cs (5)

7-7: Confirm the identifier for Llama2With13BModel matches the expected format and versioning.

11-11: Ensure the identifier for Llama2With70BModel is consistent with other model naming conventions.

15-15: The identifier for Llama2WithChat13BModel seems appropriate. Confirm that the versioning is correct.

23-23: Check if the identifier for Llama3With8BInstructBModel is correctly formatted and versioned.

27-27: Ensure the identifier for Llama3With70BInstructBModel is consistent with other model naming conventions.

src/Providers/Amazon.Bedrock/src/Predefined/Anthropic.cs (2)

22-22: Confirm the identifier for Claude3HaikuModel matches the expected format and versioning.

26-26: Ensure the identifier for Claude3OpusModel is consistent with other model naming conventions.

src/Providers/Amazon.Bedrock/src/Chat/Settings/MistralInstructChatSettings.cs (1)

12-12: The MaxTokens value has been standardized to 4000, aligning with the PR objectives. Confirm that this change is reflected across all relevant settings classes.

src/Providers/Amazon.Bedrock/src/Chat/Settings/Ai21LabsJurassic2ChatSettings.cs (1)

12-12: The MaxTokens value has been standardized to 4000, aligning with the PR objectives. Confirm that this change is reflected across all relevant settings classes.

src/Providers/Amazon.Bedrock/src/Chat/MetaLlamaChatModel.cs (1)

11-11: Ensure that the MetaLlamaChatModel class is correctly inheriting and implementing the necessary methods. Confirm that the identifiers and settings used are consistent with the PR objectives.

src/Providers/Amazon.Bedrock/src/Chat/MistralModel.cs (1)

11-11: Ensure that the MistralModel class is correctly inheriting and implementing the necessary methods. Confirm that the identifiers and settings used are consistent with the PR objectives.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Apr 28, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@HavenDV HavenDV enabled auto-merge (squash) April 28, 2024 19:50
coderabbitai[bot]
coderabbitai bot reviewed Apr 28, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

src/Providers/Amazon.Bedrock/src/Predefined/Mistral.cs
: MistralModel(provider, id: "mistral.mistral-large-2402-v1:0");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The identifier for MistralLarge uses a different format. Standardize the identifier format across all models for consistency.

src/Providers/Amazon.Bedrock/src/Predefined/Meta.cs

/// <inheritdoc />
public class Llama2WithChat70BModel(BedrockProvider provider)
: MetaLlamaChatModel(provider, id: "meta.llama2-70b-chat-v1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The identifier for Llama2WithChat70BModel uses a different format. Standardize the identifier format across all models for consistency.

@HavenDV HavenDV disabled auto-merge April 28, 2024 19:55
@HavenDV HavenDV merged commit fd62eb9 into tryAGI:main Apr 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curlyfro @HavenDV