fix: prevent dependabot verison updates (+ husky fixes) #867
Conversation
- React should not auto update on major version updates - Bump storybook to current dep version - Prevent USWDS auto updates
brandonlenz
requested review from
ahobson,
gidjin,
haworku,
sarboc,
suzubara and
tinyels
as code owners
brandonlenz
changed the title
…/react-uswds into bl-dependabot-ignore-versions
There was a problem hiding this comment.
@brandonlenz I'm not seeing the uswds dependency in the diff anymore, did it get removed by accident? I think once that's added back this is good to go!
Nice catch! Added it back in ac10252 |
.husky/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| _ | |||
There was a problem hiding this comment.
Actually, I'm not so sure I did everything required here. In #877 the patch notes mentions updating from husky 4 to 5 being more involved:
Migrating
Important Husky v5 brings a lot of improvements but is also very different from v4. Git hooks won't work if you only upgrade husky dependency, existing config needs to be migrated too.
The best way to switch to v5 is to follow the new installation instructions and migrate existing hooks command using husky add.
I found https://github.com/typicode/husky-4-to-5 via typicode/husky#854 (comment)
There was a problem hiding this comment.
@suzubara @ahobson Okay, so the husky 5 docs don't cover the implementation of how husky 5 works (under the hood) very well. Basically they no longer use package.json, and instead rely on scripts in the .husky directory. Everything is updated in accordance with the Husky 5 docs now via 58b6d22
|
Re-running ci because the happo diff, while concerning, shouldn't be caused by this type of PR. Hopefully it's just a happo fluke. Edit: seems like it was |
brandonlenz
changed the title
Summary
Dependabot recently performed an update to React for a major version change. We would like to prevent that in the future.
Additionally, uswds should be updated manually, so it has been added to the dependabot ignore list.