Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Project's example doesn't seem to compile/run #1931

Closed
wants to merge 9 commits into from
Closed

fix: Project's example doesn't seem to compile/run #1931

wants to merge 9 commits into from

Conversation

hgarfinkle
Copy link
Contributor

Summary

Fixes an issue where the example app wouldn't build. This was due to some breaking changes introduced in react-router-dom v6.

Related Issues or PRs

closes #1922

How To Test

navigate to /example
yarn install && yarn build
should not break or return errors

Screenshots (optional)

@hgarfinkle hgarfinkle requested a review from a user March 25, 2022 23:15
@brandonlenz brandonlenz changed the title [fix] Project's example doesn't seem to compile/run fix: Project's example doesn't seem to compile/run Mar 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022 •
edited
Loading

Warnings
⚠️

Changes were made to package.json, but not to yarn.lock - Perhaps you need to run yarn install?

Generated by 🚫 dangerJS against 4bdbda0

kimallen
kimallen previously approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@kimallen kimallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to run a ci-test to make sure it builds.

The example app ran for me!

@haworku haworku mentioned this pull request Apr 19, 2022
Closed
@hgarfinkle hgarfinkle added the type: automerge PR will be merged automatically i.e., by a bot or action label Apr 19, 2022
@hgarfinkle
Copy link
Contributor Author

Build checks are breaking because the dependency react-scripts:5.0.0 requires at least Node 14, and we're checking against Node 12.

@kodiakhq kodiakhq bot removed the type: automerge PR will be merged automatically i.e., by a bot or action label Jun 17, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 17, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the type: automerge label.

@rogeruiz
Copy link
Contributor

Closing this as we've removed the example app from the project in #2162

@rogeruiz rogeruiz closed this Jun 17, 2022
@rogeruiz rogeruiz deleted the ig-1922-fix-project-example branch June 17, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimallen kimallen kimallen left review comments

@suzubara suzubara Awaiting requested review from suzubara

@gidjin gidjin Awaiting requested review from gidjin

@haworku haworku Awaiting requested review from haworku

@ahobson ahobson Awaiting requested review from ahobson

@brandonlenz brandonlenz Awaiting requested review from brandonlenz

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

@rogeruiz rogeruiz Awaiting requested review from rogeruiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Project's example doesn't seem to compile/run
5 participants
@hgarfinkle @rogeruiz @kimallen @trussworks-infra-zz @haworku