feat: Add ability to pass through heading props #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure classNames are not destructive when passed
brandonlenz
changed the title
brandonlenz
requested review from
ahobson,
gidjin,
haworku,
sarboc,
SirenaBorracha and
suzubara
as code owners
hgarfinkle
previously approved these changes
Feb 3, 2022
haworku
approved these changes
Feb 14, 2022
haworku
approved these changes
Feb 17, 2022
haworku
approved these changes
Feb 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to pass through props to the heading element.
Also restructures classNames internally so that we don't destructively assign classNames to elements if their passthrough props include a
className.This is important for being able to set accessible identifiers on the various elements (for instance using
aria-labelledbyand referencing theidof the heading element)How To Test
Tested by locally pulling in dependency into my Truss project.
Also added unit tests.
No user facing changes. Backwards compatible, unless users were clobbering the default classNames with the various passthrough props we made available, but that feels more like fixing a bug than anything to me.