Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add size enum prop to Address #265

Closed
ahobson opened this issue Jun 18, 2020 · 0 comments · Fixed by #269
Closed

[feat] Add size enum prop to Address #265

ahobson opened this issue Jun 18, 2020 · 0 comments · Fixed by #269
Assignees
@ahobson

Comments

@ahobson
Copy link
Contributor

ahobson commented Jun 18, 2020

Does your feature request relate to a specific USWDS feature?
Footer component - specifically the <Address/> subcomponent.

Is your feature request related to a problem? Please describe.
Discussion of problem is in #187.

Describe the solution you'd like

  • Add new size prop.
  • Deprecate big, medium, slim props in favor of new prop.
  • Add new tests and adjust stories as needed.

This work should look very similar to #229.

Describe alternatives you've considered
n/a, we converged on a solution for handling these cases in the linked issue.
@ahobson ahobson self-assigned this Jun 18, 2020
ahobson pushed a commit that referenced this issue Jun 19, 2020
feat(Address): convert to enum size prop, deprecate boolean
a36891b 
* closes #265
@ahobson ahobson mentioned this issue Jun 19, 2020
Merged
ahobson pushed a commit that referenced this issue Jun 24, 2020
feat(Address): convert to enum size prop, deprecate boolean
be5d62c 
* closes #265
ahobson added a commit that referenced this issue Jun 24, 2020
@ahobson
feat(Address): convert to enum size prop, deprecate boolean (#269)
952bb71 
* closes #265
@haworku haworku mentioned this issue Jun 29, 2020
Merged
haworku pushed a commit that referenced this issue Jun 29, 2020
@ahobson @haworku
feat(Address): convert to enum size prop, deprecate boolean (#269)
d0912f0 
* closes #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahobson ahobson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Address): convert to enum size prop, deprecate boolean trussworks/react-uswds
1 participant
@ahobson