feat: Remove example app #2162
Merged
feat: Remove example app #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haworku
added
the
type: example
haworku
requested review from
suzubara,
gidjin,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
|
I have to fix the Danger check here. It sees that package.json was modified, but it shouldn't be reporting changes being made to the contributors section. |
|
@rogeruiz thanks for diagnosing |
This was referenced Jun 22, 2022
This was referenced Jun 22, 2022
Merged
gidjin
added a commit
that referenced
this pull request
Jul 13, 2022
## [3.1.0](3.0.2...3.1.0) (2022-07-13) ### Features * Remove example app ([#2162](#2162)) ([1eb579e](1eb579e)) * USWDS 2.13.3 ([#2175](#2175)) ([fdeefc6](fdeefc6)) ### Bug Fixes * Danger contributors check ([#2167](#2167)) ([c05fe06](c05fe06)) * Emit headingLevel type and do not emit type declarations for tests ([#2134](#2134)) ([a4501dd](a4501dd)) * export SummaryBoxHeading and SummaryBoxContent ([#2100](#2100)) ([141ba8e](141ba8e)) ### Documentation & Examples * Callout outside contributors process ([#1969](#1969)) ([7881191](7881191)) * Update releasing docs ([#2018](#2018)) ([6849dda](6849dda))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
/exampleand references to the example app. We use storybook for primary documentation and implementation examples.Related Issues or PRs
#2001 some discussion here of the benefits of this change
How To Test
Library compiles and tests pass. No references to the example app remain that could confuse future contributors or maintainers.